All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: Calling i2c set speed twice for i2c_mux_bus
Date: Thu, 9 Apr 2020 16:03:37 +0200	[thread overview]
Message-ID: <d606a21c-3537-43e7-712f-0a32713eded9@xilinx.com> (raw)

Hi Heiko and Simon,

I have find out one bug in i2c class. I am using zcu104 revC board which
has dts in mainline where i2c1 has i2c mux with some channels.
In DT clock-frequency = <400000>; is specified and it is read in
i2c_post_probe(). But i2c_mux_bus_drv is also UCLASS_I2C which means
that post probe is called for it too. And because clock-frequency
property is not there default 100k is used.

I think that is bug and should be fixed.
Heiko: Are you aware about this issue?

Simon: I think that make sense to use some flags to skip calling
post_probe in this case. Or any suggestion how to fix it would be great.

Thanks,
Michal

             reply	other threads:[~2020-04-09 14:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 14:03 Michal Simek [this message]
2020-04-09 16:25 ` Calling i2c set speed twice for i2c_mux_bus Simon Glass
2020-04-10  6:21   ` Michal Simek
2020-04-10  5:11 ` Heiko Schocher
2020-04-10  6:46   ` Michal Simek
2020-04-10  8:49     ` Heiko Schocher
2020-04-15  6:40       ` Michal Simek
2020-05-05  8:26         ` Michal Simek
2020-05-06  3:43           ` Simon Glass
2020-05-06 14:47             ` Simon Glass
2020-05-07  8:18               ` Michal Simek
2020-05-07 10:02                 ` Heiko Schocher
2020-05-11 13:36                   ` Michal Simek
2020-05-11 14:37                     ` Heiko Schocher
2020-05-11 20:28                       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d606a21c-3537-43e7-712f-0a32713eded9@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.