From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95084C43603 for ; Wed, 11 Dec 2019 20:30:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 704972077B for ; Wed, 11 Dec 2019 20:30:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 704972077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 01BE26E06B; Wed, 11 Dec 2019 20:30:15 +0000 (UTC) X-Greylist: delayed 346 seconds by postgrey-1.36 at gabe; Wed, 11 Dec 2019 20:30:12 UTC Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id C26956E06B for ; Wed, 11 Dec 2019 20:30:12 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 12:25:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,303,1571727600"; d="scan'208";a="225664174" Received: from cataylo2-ubuntu18-10.jf.intel.com (HELO [10.7.199.54]) ([10.7.199.54]) by orsmga002.jf.intel.com with ESMTP; 11 Dec 2019 12:25:22 -0800 To: intel-gfx@lists.freedesktop.org References: <20191206071422.27138-1-lucas.demarchi@intel.com> <20191206071422.27138-2-lucas.demarchi@intel.com> From: Clinton Taylor Message-ID: Date: Wed, 11 Dec 2019 12:25:22 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191206071422.27138-2-lucas.demarchi@intel.com> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: use clk_off name to avoid double negation X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 12/5/19 11:14 PM, Lucas De Marchi wrote: > Instead of "ungated" use the same name for the variable as the bitfield, > making it clearer what's the intent of the checks. > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c > index 3433b0bf4f44..586a0019b9c7 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -3012,12 +3012,10 @@ static void icl_sanitize_port_clk_off(struct drm_i915_private *dev_priv, > val = I915_READ(ICL_DPCLKA_CFGCR0); > for_each_port_masked(port, port_mask) { > enum phy phy = intel_port_to_phy(dev_priv, port); > + bool ddi_clk_off = val & icl_dpclka_cfgcr0_clk_off(dev_priv, > + phy); > > - bool ddi_clk_ungated = !(val & > - icl_dpclka_cfgcr0_clk_off(dev_priv, > - phy)); > - > - if (ddi_clk_needed == ddi_clk_ungated) > + if (ddi_clk_needed == !ddi_clk_off) > continue; > > /* Sanity prevails. Reviewed-by: Clint Taylor -Clint _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx