From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C323CA9EAE for ; Mon, 21 Oct 2019 02:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9B0721897 for ; Mon, 21 Oct 2019 02:52:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JvI3M1rW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726973AbfJUCwK (ORCPT ); Sun, 20 Oct 2019 22:52:10 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:42288 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbfJUCwK (ORCPT ); Sun, 20 Oct 2019 22:52:10 -0400 Received: by mail-pg1-f194.google.com with SMTP id f14so6809703pgi.9; Sun, 20 Oct 2019 19:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3YcbFlGeukZjRaHUc52Yo3oow3dwGRvRToPt56X0JRM=; b=JvI3M1rWTuzFM3iSmyK6InPBkB4WEv/pU/GpE+bjUHjj0Fa0/IK2SCua5cuAieKgIo 7YAOfmLd8d/Q0vaQ1aZLg3xVzse2dRHE2I54Lnp9iOMXSmhtA2q7mwytiY1cpkpEx+FB BfpLRHkL/PbuJQ9P2DcZOZbHXwEKbORTuVuwqPLQT6XytdE3jU92IcdW3/bJzISHaRlr ZSbVoELp5O1s7gYzkDL0hC3zCtSgYYLMYHxymywZWZMTHE1r+NJtcyxA2aelZRdL1kyt rRUg55BMbWbt4PpcWAObWrgPR8KjlD20exC1VVOjcbFy8ejMAhHX8YXbLfKMxmLyUjOM EKlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3YcbFlGeukZjRaHUc52Yo3oow3dwGRvRToPt56X0JRM=; b=MlvXGfv3o1IqFw5OfX0a2+WHTEJVM3ngUMm+tuEI+KocULekGjGfSnbsrjr3ZtQGsj afY8qXNtE5ZpPXiARU4kU7TzAxF9Fv2lqClAw9LIT+Urb4eOLR1dN1sF/SAZP197pa0D 5NbQY6vvr1bYX/XwH8DkYKMrkj1j4osTnp8dglbeVRcQpbr0brYWO8QeX9+Ebm2buS39 5AX0EP+KSQfqQ20Pksui2LxLGIKSwUc5VW83m7j6NHYv+56IoJbM8lQ7Lbgy6V02gtFg e2dHD2Japwq800KlNfv98DSlDupWIkuFTIO3YBs97NwgIwy6JUcns/v1kPG2FZTKrz5T pRAA== X-Gm-Message-State: APjAAAUsVu3NDRJSqI3mybi8UVP9fQeEBkeEX4r3EEwS3nZWIv68UAkv NvDGWi2i5Fh8xJD5rzew+zKEpP0E X-Google-Smtp-Source: APXvYqx4a0OcWArwZ1Ln4fo0J8+fBzMMIz1WvSurss5T1G2/AgEkcePxTyFSqRtUr1xm460o3vP3iw== X-Received: by 2002:a63:e056:: with SMTP id n22mr22410398pgj.73.1571626329018; Sun, 20 Oct 2019 19:52:09 -0700 (PDT) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id c8sm14454465pfi.117.2019.10.20.19.52.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Oct 2019 19:52:08 -0700 (PDT) Subject: Re: [PATCH net-next 13/16] net: dsa: mv88e6xxx: use ports list to map bridge To: Vivien Didelot , "David S. Miller" Cc: linux-kernel@vger.kernel.org, Andrew Lunn , netdev@vger.kernel.org References: <20191020031941.3805884-1-vivien.didelot@gmail.com> <20191020031941.3805884-14-vivien.didelot@gmail.com> From: Florian Fainelli Message-ID: Date: Sun, 20 Oct 2019 19:52:07 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20191020031941.3805884-14-vivien.didelot@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/19/2019 8:19 PM, Vivien Didelot wrote: > Instead of digging into the other dsa_switch structures of the fabric > and relying too much on the dsa_to_port helper, use the new list > of switch fabric ports to remap the Port VLAN Map of local bridge > group members or remap the Port VLAN Table entry of external bridge > group members. > > Signed-off-by: Vivien Didelot > --- [snip] > - for (port = 0; port < ds->num_ports; ++port) { > - if (dsa_to_port(ds, port)->bridge_dev == br) { > - err = mv88e6xxx_pvt_map(chip, dev, port); > + list_for_each_entry(dp, &dst->ports, list) { > + /* Remap the Port VLAN Map of local bridge group members and > + * remap the PVT entry of external bridge group members. > + */ If you do a v2, I would tend to put these comments under the appropriate branches taken below for clarify although the code is actually clearer this want than it was before IMHO, so up to you :) Reviewed-by: Florian Fainelli -- Florian