From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH RFC 2/3] mmc: core: add new cap for 3.3V only DDR MMCs Date: Thu, 11 Aug 2016 13:57:50 +0200 Message-ID: References: <1470488140-10104-1-git-send-email-stefan.wahren@i2se.com> <1470488140-10104-3-git-send-email-stefan.wahren@i2se.com> <0e38d62a-b3d0-30ca-fca9-bb740ae54d0a@denx.de> <16443443.114784.752d0f22-93a7-46e8-bb14-c884787aaea3.open-xchange@email.1und1.de> <7284d9a4-164d-dd2d-b9a0-dd1de6c76274@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jaehoon Chung , Shawn Lin , Rob Herring , Ulf Hansson , Mark Rutland , Fabio Estevam , Marek Vasut Cc: Dong Aisheng , devicetree@vger.kernel.org, Otavio Salvador , Holger Schurig , linux-mmc@vger.kernel.org, Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org QW0gMTEuMDguMjAxNiB1bSAxMzoxMiBzY2hyaWViIEphZWhvb24gQ2h1bmc6Cj4gT24gMDgvMDcv MjAxNiAxMTowNyBBTSwgU2hhd24gTGluIHdyb3RlOgo+PiDlnKggMjAxNi84LzYgMjI6MTgsIFN0 ZWZhbiBXYWhyZW4g5YaZ6YGTOgo+Pj4gSGkgTWFyZWssCj4+Pgo+Pj4+IE1hcmVrIFZhc3V0IDxt YXJleEBkZW54LmRlPiBoYXQgYW0gNi4gQXVndXN0IDIwMTYgdW0gMTU6MTQgZ2VzY2hyaWViZW46 Cj4+Pj4KPj4+Pgo+Pj4+IE9uIDA4LzA2LzIwMTYgMDI6NTUgUE0sIFN0ZWZhbiBXYWhyZW4gd3Jv dGU6Cj4+Pj4+IFRoaXMgcGF0Y2ggYmFzZWQgb24gdGhlIHdvcmsgb2YgRmFiaW8gRXN0ZXZhbToK Pj4+Pj4gIltQQVRDSCB2Ml0gbW1jOiBjb3JlOiBEbyBub3Qgc2V0IG1tYyB2b2x0YWdlIHRvIDEu OFYgd2hlbgo+Pj4+PiAnbm8tMS04LXYnIGlzIHByZXNlbnQiCj4+Pj4+Cj4+Pj4+IEl0IGFkZHMg dGhlIHN1cHBvcnQgZm9yIDMuM1Ygb25seSBERFIgTU1DIGhvc3RzLgo+Pj4+Cj4+Pj4gRG8gc3Vj aCBjYXJkcyBldmVuIGV4aXN0ID8gRG8geW91IGhhdmUgYSBsaW5rIHdoZXJlIEkgY2FuIGZpbmQg c29tZSA/Cj4+Pgo+Pj4gaSBuZXZlciBzYWlkIGFueXRoaW5nIGFib3V0IFNEIGNhcmRzLiBJIG1l YW4gZU1NQyBtb2R1bGVzIHdoaWNoIHVzdWFsbHkgaGF2ZSA4Cj4+PiBkYXRhIHBpbnMgbGlrZSB0 aGlzIG9uZSBbMV0uCj4+Pgo+Pj4gUGxlYXNlIGRvbid0IGJsYW1lIG1lIGlmIGl0J3Mgbm90IGNv bXBhdGlibGUgdG8gaS5NWDI4LiBJdCdzIG9ubHkgYW4gZXhhbXBsZS4KPj4+Cj4+PiBbMV0gLQo+ Pj4gaHR0cDovL2RhdGFzaGVldC5vY3RvcGFydC5jb20vVEhHQk0zRzREMUZCQUlHSDJILVRvc2hp YmEtZGF0YXNoZWV0LTIwNzQ4ODgwLnBkZgo+Pgo+Pgo+PiBJIGRvd25sb2FkIHRoZSBkYXRhc2hl ZXQgeW91IG1lbnRpb25lZCwgYW5kIEkgZXhwbGljaXRseSBzZWUgaXQKPj4gZGVzY3JpYmUgMVY4 IGV2ZXJ5d2hlcmUsIGVzcGVjaWFsbHkgZm9yIHRoZSBzZWN0aW9uIG9mICJFTEVDVFJJQ0FMCj4+ IENIQVJBQ1RFUklTVElDUyIuCj4+Cj4+IEkgbmV2ZXIgc2VlIG9uZSBlTU1DIGNsYWltaW5nIERE UjUyIGNhcGFiaWxpdHkgYnV0IGRvZXNuJ3Qgc3VwcG9ydCAxVjgKPj4gc28gZmFyLiBDb3VsZCB5 b3Uga2luZGx5IHNoYXJlIG1lIHRoZSBwYXJ0IG51bWJlciBvZiB0aGUgZU1NQyB5b3UgYXJlCj4+ IHVzaW5nPyA6KQo+Pgo+Pj4KPj4+Pgo+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBTdGVmYW4gV2FocmVu IDxzdGVmYW4ud2FocmVuQGkyc2UuY29tPgo+Pj4+PiAtLS0KPj4+Pj4gIGRyaXZlcnMvbW1jL2Nv cmUvaG9zdC5jICB8ICAgIDIgKysKPj4+Pj4gIGRyaXZlcnMvbW1jL2NvcmUvbW1jLmMgICB8ICAg IDYgKysrKysrCj4+Pj4+ICBpbmNsdWRlL2xpbnV4L21tYy9ob3N0LmggfCAgICAxICsKPj4+Pj4g IDMgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspCj4+Pj4+Cj4+Pj4+IENoYW5nZXMgdG8g RmFiaW8ncyBwYXRjaDoKPj4+Pj4gLSByZWJhc2UgdG8gY3VycmVudCBsaW51eC1uZXh0Cj4+Pj4+ IC0gcmVuYW1lIERUIHByb3BlcnR5IHRvIG1tYy1kZHItM18zdgo+Pj4+PiAtIHVzZSBFWFRfQ1NE X0NBUkRfVFlQRV9ERFJfNTIgaW5zdGVhZCBvZiBuZXcgZGVmaW5lCj4+Pj4+Cj4+Pj4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL21tYy9jb3JlL2hvc3QuYyBiL2RyaXZlcnMvbW1jL2NvcmUvaG9zdC5j Cj4+Pj4+IGluZGV4IDk4ZjI1ZmYuLjRjOTcxZGUgMTAwNjQ0Cj4+Pj4+IC0tLSBhL2RyaXZlcnMv bW1jL2NvcmUvaG9zdC5jCj4+Pj4+ICsrKyBiL2RyaXZlcnMvbW1jL2NvcmUvaG9zdC5jCj4+Pj4+ IEBAIC0zMDEsNiArMzAxLDggQEAgaW50IG1tY19vZl9wYXJzZShzdHJ1Y3QgbW1jX2hvc3QgKmhv c3QpCj4+Pj4+ICAgICAgaWYgKG9mX3Byb3BlcnR5X3JlYWRfYm9vbChucCwgIndha2V1cC1zb3Vy Y2UiKSB8fAo+Pj4+PiAgICAgICAgICBvZl9wcm9wZXJ0eV9yZWFkX2Jvb2wobnAsICJlbmFibGUt c2Rpby13YWtldXAiKSkgLyogbGVnYWN5ICovCj4+Pj4+ICAgICAgICAgIGhvc3QtPnBtX2NhcHMg fD0gTU1DX1BNX1dBS0VfU0RJT19JUlE7Cj4+Pj4+ICsgICAgaWYgKG9mX3Byb3BlcnR5X3JlYWRf Ym9vbChucCwgIm1tYy1kZHItM18zdiIpKQo+Pj4+PiArICAgICAgICBob3N0LT5jYXBzMiB8PSBN TUNfQ0FQMl8zXzNWX09OTFlfRERSOwo+Pj4+PiAgICAgIGlmIChvZl9wcm9wZXJ0eV9yZWFkX2Jv b2wobnAsICJtbWMtZGRyLTFfOHYiKSkKPj4+Pj4gICAgICAgICAgaG9zdC0+Y2FwcyB8PSBNTUNf Q0FQXzFfOFZfRERSOwo+Pj4+PiAgICAgIGlmIChvZl9wcm9wZXJ0eV9yZWFkX2Jvb2wobnAsICJt bWMtZGRyLTFfMnYiKSkKPj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbW1jL2NvcmUvbW1jLmMg Yi9kcml2ZXJzL21tYy9jb3JlL21tYy5jCj4+Pj4+IGluZGV4IGYyZDE4NWMuLjhhOTMzZDUgMTAw NjQ0Cj4+Pj4+IC0tLSBhL2RyaXZlcnMvbW1jL2NvcmUvbW1jLmMKPj4+Pj4gKysrIGIvZHJpdmVy cy9tbWMvY29yZS9tbWMuYwo+Pj4+PiBAQCAtMjEwLDYgKzIxMCwxMiBAQCBzdGF0aWMgdm9pZCBt bWNfc2VsZWN0X2NhcmRfdHlwZShzdHJ1Y3QgbW1jX2NhcmQgKmNhcmQpCj4+Pj4+ICAgICAgICAg IGF2YWlsX3R5cGUgfD0gRVhUX0NTRF9DQVJEX1RZUEVfSFNfNTI7Cj4+Pj4+ICAgICAgfQo+Pj4+ Pgo+Pj4+PiArICAgIGlmIChjYXBzMiAmIE1NQ19DQVAyXzNfM1ZfT05MWV9ERFIgJiYKPj4+Pj4g KyAgICAgICAgY2FyZF90eXBlICYgRVhUX0NTRF9DQVJEX1RZUEVfRERSXzFfOFYpIHsKPj4+Pj4g KyAgICAgICAgaHNfbWF4X2R0ciA9IE1NQ19ISUdIX0REUl9NQVhfRFRSOwo+Pj4+PiArICAgICAg ICBhdmFpbF90eXBlIHw9IEVYVF9DU0RfQ0FSRF9UWVBFX0REUl81MjsKPj4+Pj4gKyAgICB9Cj4K PiBkaWQgeW91IGtub3cgRVhUX0NTRF9DQVJEX1RZUEVfRERSXzUyIC0+IFRZUEVfRERSXzFfOFYg YW5kIFRZUEVfRERSXzFfMlY/CgpUaGFua3MgZm9yIHBvaW50aW5nIG91dC4gRmFiaW8ncyBwYXRj aCB3YXMgYmV0dGVyIGhlcmUuCgpBcyBpIHdyb3RlIHRvIFNoYXduIHRoZSBzdWJqZWN0IGxpbmUg aXMgaW5jb3JyZWN0LiBJIHdhbnQgdG8gYWRkIDMuM1YgCm9ubHkgc3VwcG9ydCBmb3IgaG9zdHMg bm90IGZvciAiY2FyZCIuCgpBY2NvcmRpbmcgdG8gdGhlIGNvbW1lbnRzIEVYVF9DU0RfQ0FSRF9U WVBFX0REUl8xXzhWIHN0YW5kcyBmb3IgMS44ViBvciAKMy4zVi4gU28gaSBiZXR0ZXIgYWRkIEVY VF9DU0RfQ0FSRF9UWVBFX0REUl8zXzNWX09OTFkgZXZlbiB0aGUgImNhcmQiIApzdXBwb3J0cyAx LjhWLgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefan.wahren@i2se.com (Stefan Wahren) Date: Thu, 11 Aug 2016 13:57:50 +0200 Subject: [PATCH RFC 2/3] mmc: core: add new cap for 3.3V only DDR MMCs In-Reply-To: References: <1470488140-10104-1-git-send-email-stefan.wahren@i2se.com> <1470488140-10104-3-git-send-email-stefan.wahren@i2se.com> <0e38d62a-b3d0-30ca-fca9-bb740ae54d0a@denx.de> <16443443.114784.752d0f22-93a7-46e8-bb14-c884787aaea3.open-xchange@email.1und1.de> <7284d9a4-164d-dd2d-b9a0-dd1de6c76274@rock-chips.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 11.08.2016 um 13:12 schrieb Jaehoon Chung: > On 08/07/2016 11:07 AM, Shawn Lin wrote: >> ? 2016/8/6 22:18, Stefan Wahren ??: >>> Hi Marek, >>> >>>> Marek Vasut hat am 6. August 2016 um 15:14 geschrieben: >>>> >>>> >>>> On 08/06/2016 02:55 PM, Stefan Wahren wrote: >>>>> This patch based on the work of Fabio Estevam: >>>>> "[PATCH v2] mmc: core: Do not set mmc voltage to 1.8V when >>>>> 'no-1-8-v' is present" >>>>> >>>>> It adds the support for 3.3V only DDR MMC hosts. >>>> >>>> Do such cards even exist ? Do you have a link where I can find some ? >>> >>> i never said anything about SD cards. I mean eMMC modules which usually have 8 >>> data pins like this one [1]. >>> >>> Please don't blame me if it's not compatible to i.MX28. It's only an example. >>> >>> [1] - >>> http://datasheet.octopart.com/THGBM3G4D1FBAIGH2H-Toshiba-datasheet-20748880.pdf >> >> >> I download the datasheet you mentioned, and I explicitly see it >> describe 1V8 everywhere, especially for the section of "ELECTRICAL >> CHARACTERISTICS". >> >> I never see one eMMC claiming DDR52 capability but doesn't support 1V8 >> so far. Could you kindly share me the part number of the eMMC you are >> using? :) >> >>> >>>> >>>>> Signed-off-by: Stefan Wahren >>>>> --- >>>>> drivers/mmc/core/host.c | 2 ++ >>>>> drivers/mmc/core/mmc.c | 6 ++++++ >>>>> include/linux/mmc/host.h | 1 + >>>>> 3 files changed, 9 insertions(+) >>>>> >>>>> Changes to Fabio's patch: >>>>> - rebase to current linux-next >>>>> - rename DT property to mmc-ddr-3_3v >>>>> - use EXT_CSD_CARD_TYPE_DDR_52 instead of new define >>>>> >>>>> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c >>>>> index 98f25ff..4c971de 100644 >>>>> --- a/drivers/mmc/core/host.c >>>>> +++ b/drivers/mmc/core/host.c >>>>> @@ -301,6 +301,8 @@ int mmc_of_parse(struct mmc_host *host) >>>>> if (of_property_read_bool(np, "wakeup-source") || >>>>> of_property_read_bool(np, "enable-sdio-wakeup")) /* legacy */ >>>>> host->pm_caps |= MMC_PM_WAKE_SDIO_IRQ; >>>>> + if (of_property_read_bool(np, "mmc-ddr-3_3v")) >>>>> + host->caps2 |= MMC_CAP2_3_3V_ONLY_DDR; >>>>> if (of_property_read_bool(np, "mmc-ddr-1_8v")) >>>>> host->caps |= MMC_CAP_1_8V_DDR; >>>>> if (of_property_read_bool(np, "mmc-ddr-1_2v")) >>>>> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c >>>>> index f2d185c..8a933d5 100644 >>>>> --- a/drivers/mmc/core/mmc.c >>>>> +++ b/drivers/mmc/core/mmc.c >>>>> @@ -210,6 +210,12 @@ static void mmc_select_card_type(struct mmc_card *card) >>>>> avail_type |= EXT_CSD_CARD_TYPE_HS_52; >>>>> } >>>>> >>>>> + if (caps2 & MMC_CAP2_3_3V_ONLY_DDR && >>>>> + card_type & EXT_CSD_CARD_TYPE_DDR_1_8V) { >>>>> + hs_max_dtr = MMC_HIGH_DDR_MAX_DTR; >>>>> + avail_type |= EXT_CSD_CARD_TYPE_DDR_52; >>>>> + } > > did you know EXT_CSD_CARD_TYPE_DDR_52 -> TYPE_DDR_1_8V and TYPE_DDR_1_2V? Thanks for pointing out. Fabio's patch was better here. As i wrote to Shawn the subject line is incorrect. I want to add 3.3V only support for hosts not for "card". According to the comments EXT_CSD_CARD_TYPE_DDR_1_8V stands for 1.8V or 3.3V. So i better add EXT_CSD_CARD_TYPE_DDR_3_3V_ONLY even the "card" supports 1.8V.