From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932615AbdKOPVO (ORCPT ); Wed, 15 Nov 2017 10:21:14 -0500 Received: from osg.samsung.com ([64.30.133.232]:61168 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932525AbdKOPVE (ORCPT ); Wed, 15 Nov 2017 10:21:04 -0500 Subject: Re: [PATCH v2] cpupowerutils: bench - Fix cpu online check To: Abhishek Goel , trenn@suse.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Shuah Khan References: <20171107094755.49440-1-huntbag@linux.vnet.ibm.com> From: Shuah Khan Message-ID: Date: Wed, 15 Nov 2017 08:21:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171107094755.49440-1-huntbag@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2017 02:47 AM, Abhishek Goel wrote: > cpupower_is_cpu_online was incorrectly checking for 0. This patch fixes > this by checking for 1 when the cpu is online. > > Signed-off-by: Abhishek Goel > --- > v2: Commit message rephrased. > --- > tools/power/cpupower/bench/system.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c > index c25a74a..2bb3eef 100644 > --- a/tools/power/cpupower/bench/system.c > +++ b/tools/power/cpupower/bench/system.c > @@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu) > > dprintf("set %s as cpufreq governor\n", governor); > > - if (cpupower_is_cpu_online(cpu) != 0) { > + if (cpupower_is_cpu_online(cpu) != 1) { > perror("cpufreq_cpu_exists"); > fprintf(stderr, "error: cpu %u does not exist\n", cpu); > return -1; > Thanks. I will queue this up for 4.15-rc2 -- Shuah