From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A16B1C48BE5 for ; Sat, 12 Jun 2021 08:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A4FC61184 for ; Sat, 12 Jun 2021 08:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230411AbhFLIWb (ORCPT ); Sat, 12 Jun 2021 04:22:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229819AbhFLIWa (ORCPT ); Sat, 12 Jun 2021 04:22:30 -0400 Received: from mail-qv1-xf29.google.com (mail-qv1-xf29.google.com [IPv6:2607:f8b0:4864:20::f29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF8DEC061574 for ; Sat, 12 Jun 2021 01:20:30 -0700 (PDT) Received: by mail-qv1-xf29.google.com with SMTP id t6so11957166qvp.5 for ; Sat, 12 Jun 2021 01:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=8Ty9jamoqByHuZWkQK+ZAkMj0mCrAvr4/YXGaEPbHdY=; b=VAX83o2uXpqSrAe/XPT+KXdM+CEpb/6+4lyVBICHZdn6URf2MvQ890CUj6yRrCz2o4 2BThAJAtpl5nRIrlGqiLB+0FwkoowFsYJZVroQ6MnLAmUPFKSSS5hjgSl1iQ8qODzZPW xdl2I+xtR80WvlbvBEnZ4HB2+KvFHahSI2NpOt5O2wGXQAdsrt5gAkRC0VbIpxUQtH4+ qQ2koUQLord7TdV3gUCwAq/Yf7MEniy8TG5LTIYPHy5l32uTiurYZWqig8Fe5gUWnr8+ hwYsqLsemlYQWvJOnhVq6QrUnzqoVz4tezMDVPP/T4mtjCJZwECzjZ/wFy1hiK9HDH3i 1XXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=8Ty9jamoqByHuZWkQK+ZAkMj0mCrAvr4/YXGaEPbHdY=; b=fO0E7Id/KLULFi+jYZ8RuS6c8ce5biW77/52EYqHLGVQhprO+0xSJ8jbc5FXOR9PF+ pZAstsD7YoQTRL4zbGp70PWwoCF4n06lTf/OVfazL/hNEC86DyLKb9LMFmJz9fu0SzS1 GD2u/q2ToAT84fP92+rN0hRb68ql/PUM1nczI4BH4q/qKclPF7brTn6LH5AXiSVaHCF2 garw6RD1cIdmEvhGx5GNuD+zeqs+UzgTZn5GJX7q24YUWccn8/Q8aqXRM+iXhp1/G+0F aVCBJEd93t4M8Ooqt6YGMwPoRsOW9IbXxFUvvtN+DRprc0dctE21lUYLg5vl4yhgBKLv tvJA== X-Gm-Message-State: AOAM53360qyZC11MtJQXXrFOHaMewZgEYFnAqWkNO0QhUdjLDvbJlYyY 7GpHGYIqdveoqrvTMm8vaBeCyA== X-Google-Smtp-Source: ABdhPJyx7HmXzZGSNCp+6dPE7DmcqQ6LohKYAfEK1ahFCzIEj8HSnzIXWW9zNT/rDZR2ECPx+AbRuA== X-Received: by 2002:ad4:424b:: with SMTP id l11mr8746847qvq.58.1623486029784; Sat, 12 Jun 2021 01:20:29 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 16sm5617049qtt.19.2021.06.12.01.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Jun 2021 01:20:29 -0700 (PDT) Date: Sat, 12 Jun 2021 01:20:13 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Alistair Popple cc: Hugh Dickins , Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Naoya Horiguchi , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , Shakeel Butt , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 00/10] mm/thp: fix THP splitting unmap BUGs and related In-Reply-To: <14130393.9bCoogeq7g@nvdebian> Message-ID: References: <1697169.ADtCEf3Xva@nvdebian> <494c929d-5253-58b0-6329-dec8395199cc@google.com> <14130393.9bCoogeq7g@nvdebian> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 12 Jun 2021, Alistair Popple wrote: > On Saturday, 12 June 2021 6:56:36 AM AEST Hugh Dickins wrote: I wonder how I arrived in Queensland - ^^^^ must I quarantine? > > > > > > As to sending my rebased series I suppose it would be best to wait until > > > linux-mm has been updated with whatever other fixes are needed before resending > > > it based on top of that. So far rebasing on this series didn't require too many > > > drastic changes to my v10 series. The most significant was to incorporate your > > > changes to unmap_page(). The remaining were just adding the TTU_SYNC case to > > > try_to_migrate{_one} and a single s/migration_entry_to_page/pfn_swap_entry_to_page/ > > > in huge_memory.c > > > > Yes, I think that's it. But check your try_to_migrate_one(), it may > > want the same range.end vma_address_end() mod I made in try_to_unmap_one(). > > > > And does try_to_migrate_one() still have a comment referring to > > try_to_unmap() when it should say try_to_migrate() there? > > Thanks for the pointers, I had caught both those as well. > > > I've now located the diffs I missed from sending akpm before, > > and diffed the diffs, and those are the points I see there; > > but sending them now will just be a waste of everyones time. > > No substitute for me checking your end result when it comes, > > though I fear to do so since there's much more in your series > > than I can wrap my head around without a lot more education. > > The first few patches in the series (and the ones with conflicts) are > clean-ups, so shouldn't change any behaviour. I'm reasonably confident I caught > everything but would certainly appreciate you checking the end result in the > early patches when I post just to make sure I didn't miss anything. Thanks. > > Also I have been getting bounce responses trying to deliver mail to linux-mm > in case anyone is wondering why these might not be showing up on the mailing > list. Looks to be some kind of mail loop, but not sure if it's at my end or > somewhere else. linux-mm@kvack.org has been having trouble recently. See https://lore.kernel.org/linux-mm/YMJrk81oZa5ArWPw@cmpxchg.org/ There are more messages in that thread, but only one has got out. Hugh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB880C48BCF for ; Sat, 12 Jun 2021 08:20:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 626D861184 for ; Sat, 12 Jun 2021 08:20:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 626D861184 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C8BA86B006C; Sat, 12 Jun 2021 04:20:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3BA46B006E; Sat, 12 Jun 2021 04:20:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB45F6B0070; Sat, 12 Jun 2021 04:20:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 7618B6B006C for ; Sat, 12 Jun 2021 04:20:31 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E444CB9F6 for ; Sat, 12 Jun 2021 08:20:30 +0000 (UTC) X-FDA: 78244375020.16.9B96D9F Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf26.hostedemail.com (Postfix) with ESMTP id C17DD40002C1 for ; Sat, 12 Jun 2021 08:20:26 +0000 (UTC) Received: by mail-qv1-f46.google.com with SMTP id l3so10783926qvl.0 for ; Sat, 12 Jun 2021 01:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=8Ty9jamoqByHuZWkQK+ZAkMj0mCrAvr4/YXGaEPbHdY=; b=VAX83o2uXpqSrAe/XPT+KXdM+CEpb/6+4lyVBICHZdn6URf2MvQ890CUj6yRrCz2o4 2BThAJAtpl5nRIrlGqiLB+0FwkoowFsYJZVroQ6MnLAmUPFKSSS5hjgSl1iQ8qODzZPW xdl2I+xtR80WvlbvBEnZ4HB2+KvFHahSI2NpOt5O2wGXQAdsrt5gAkRC0VbIpxUQtH4+ qQ2koUQLord7TdV3gUCwAq/Yf7MEniy8TG5LTIYPHy5l32uTiurYZWqig8Fe5gUWnr8+ hwYsqLsemlYQWvJOnhVq6QrUnzqoVz4tezMDVPP/T4mtjCJZwECzjZ/wFy1hiK9HDH3i 1XXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=8Ty9jamoqByHuZWkQK+ZAkMj0mCrAvr4/YXGaEPbHdY=; b=jgTFgW6bpqpj5DdROvYnzKLdNsaWQoP7AmZPmIEHcU0FwNZ0uZD9JRfSJZqvQfAsAB N79CkIppUTS4yV6gWacNLtAcxbThsOuW2xsoUfpIsSXPUJVh0l0AM/qDX3F5PXXX43+8 G/x3qx1QY64Q1WBdeJ/8agi9CiM/etJ+A+ecczUwV5IzOJrGmRQu9pysjMjIyDY1kSzZ xV8S321Go+Z0wE09y8S6bXh/k5ME7IVSPP3seFJ28OlmFmP/6EPw5qYRYlXTJDrKIDX8 66kQ3tq5lOB/+Na5BDds3pAUr0yOt98rsH5STO5bRTza+vX67qif/vgRKFRc+25YbZ6w 7PDA== X-Gm-Message-State: AOAM5312Zus0hxPEDVlrqZeBVXxH/zX60mtQfp9AolvzQYBirMlCsg9b pHdCoWFgotRDrhXUjmxuYbnVWA== X-Google-Smtp-Source: ABdhPJyx7HmXzZGSNCp+6dPE7DmcqQ6LohKYAfEK1ahFCzIEj8HSnzIXWW9zNT/rDZR2ECPx+AbRuA== X-Received: by 2002:ad4:424b:: with SMTP id l11mr8746847qvq.58.1623486029784; Sat, 12 Jun 2021 01:20:29 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 16sm5617049qtt.19.2021.06.12.01.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Jun 2021 01:20:29 -0700 (PDT) Date: Sat, 12 Jun 2021 01:20:13 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Alistair Popple cc: Hugh Dickins , Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Naoya Horiguchi , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , Shakeel Butt , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 00/10] mm/thp: fix THP splitting unmap BUGs and related In-Reply-To: <14130393.9bCoogeq7g@nvdebian> Message-ID: References: <1697169.ADtCEf3Xva@nvdebian> <494c929d-5253-58b0-6329-dec8395199cc@google.com> <14130393.9bCoogeq7g@nvdebian> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=VAX83o2u; spf=pass (imf26.hostedemail.com: domain of hughd@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C17DD40002C1 X-Stat-Signature: 3uemmm1d6byr55wsutdtz6amizt7e7ty X-HE-Tag: 1623486026-333799 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 12 Jun 2021, Alistair Popple wrote: > On Saturday, 12 June 2021 6:56:36 AM AEST Hugh Dickins wrote: I wonder how I arrived in Queensland - ^^^^ must I quarantine? > > > > > > As to sending my rebased series I suppose it would be best to wait until > > > linux-mm has been updated with whatever other fixes are needed before resending > > > it based on top of that. So far rebasing on this series didn't require too many > > > drastic changes to my v10 series. The most significant was to incorporate your > > > changes to unmap_page(). The remaining were just adding the TTU_SYNC case to > > > try_to_migrate{_one} and a single s/migration_entry_to_page/pfn_swap_entry_to_page/ > > > in huge_memory.c > > > > Yes, I think that's it. But check your try_to_migrate_one(), it may > > want the same range.end vma_address_end() mod I made in try_to_unmap_one(). > > > > And does try_to_migrate_one() still have a comment referring to > > try_to_unmap() when it should say try_to_migrate() there? > > Thanks for the pointers, I had caught both those as well. > > > I've now located the diffs I missed from sending akpm before, > > and diffed the diffs, and those are the points I see there; > > but sending them now will just be a waste of everyones time. > > No substitute for me checking your end result when it comes, > > though I fear to do so since there's much more in your series > > than I can wrap my head around without a lot more education. > > The first few patches in the series (and the ones with conflicts) are > clean-ups, so shouldn't change any behaviour. I'm reasonably confident I caught > everything but would certainly appreciate you checking the end result in the > early patches when I post just to make sure I didn't miss anything. Thanks. > > Also I have been getting bounce responses trying to deliver mail to linux-mm > in case anyone is wondering why these might not be showing up on the mailing > list. Looks to be some kind of mail loop, but not sure if it's at my end or > somewhere else. linux-mm@kvack.org has been having trouble recently. See https://lore.kernel.org/linux-mm/YMJrk81oZa5ArWPw@cmpxchg.org/ There are more messages in that thread, but only one has got out. Hugh