From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E26C2BA2B for ; Mon, 13 Apr 2020 15:55:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69A9420656 for ; Mon, 13 Apr 2020 15:55:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731164AbgDMPzP (ORCPT ); Mon, 13 Apr 2020 11:55:15 -0400 Received: from foss.arm.com ([217.140.110.172]:42604 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730923AbgDMPzK (ORCPT ); Mon, 13 Apr 2020 11:55:10 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 022341FB; Mon, 13 Apr 2020 08:55:09 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C73EA3F68F; Mon, 13 Apr 2020 08:55:07 -0700 (PDT) Subject: Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= Cc: Rob Herring , Tomeu Vizoso , Alyssa Rosenzweig , Viresh Kumar , Nishanth Menon , Stephen Boyd , dri-devel , linux-kernel References: <20200411200632.4045-1-peron.clem@gmail.com> <20200411200632.4045-2-peron.clem@gmail.com> From: Steven Price Message-ID: Date: Mon, 13 Apr 2020 16:55:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/04/2020 15:31, Clément Péron wrote: > Hi, > > On Mon, 13 Apr 2020 at 16:18, Clément Péron wrote: >> >> Hi Steven, >> >> On Mon, 13 Apr 2020 at 15:18, Steven Price wrote: >>> >>> On 11/04/2020 21:06, Clément Péron wrote: >>>> OPP table can defined both frequency and voltage. >>>> >>>> Register the mali regulator if it exist. >>>> >>>> Signed-off-by: Clément Péron >>>> --- >>>> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 34 ++++++++++++++++++--- >>>> drivers/gpu/drm/panfrost/panfrost_device.h | 1 + >>>> 2 files changed, 31 insertions(+), 4 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c >>>> index 62541f4edd81..2dc8e2355358 100644 >>>> --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c >>>> +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c >>>> @@ -78,12 +78,26 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev) >>>> struct device *dev = &pfdev->pdev->dev; >>>> struct devfreq *devfreq; >>>> struct thermal_cooling_device *cooling; >>>> + const char *mali = "mali"; >>>> + struct opp_table *opp_table = NULL; >>>> + >>>> + /* Regulator is optional */ >>>> + opp_table = dev_pm_opp_set_regulators(dev, &mali, 1); >>> >>> This looks like it applies before 3e1399bccf51 ("drm/panfrost: Add >>> support for multiple regulators") which is currently in drm-misc-next >>> (and linux-next). You want something more like: >> >> Thanks for you review, indeed I didn't see that multiple regulators >> support has been added. >> Will update in v2. >> >>> >>> opp_table = dev_pm_opp_set_regulators(dev, >>> pfdev->comp->supply_names, >>> pfdev->comp->num_supplies); >>> >>> Otherwise a platform with multiple regulators won't work correctly. >>> >>> Also running on my firefly (RK3288) board I get the following warning: >>> >>> debugfs: Directory 'ffa30000.gpu-mali' with parent 'vdd_gpu' already >>> present! >>> >>> This is due to the regulator debugfs entries getting created twice (once >>> in panfrost_regulator_init() and once here). >> >> Is it a warning that should be consider as an error? Look's more an info no? >> What should be the correct behavior if a device want to register two >> times the same regulator? > > Or we can change the name from vdd_XXX to opp_vdd_XXX ? > https://elixir.bootlin.com/linux/latest/source/drivers/opp/debugfs.c#L45 Yes, I'm not sure that it's actually a problem in practice. And it may well be correct to change this in the generic code rather than try to work around it in Panfrost. But we shouldn't spam the user with warnings as that makes real issues harder to see. Your suggestion to change the name seems reasonable to me, but I don't fully understand the opp code, so we'd need some review from the OPP maintainers. Hopefully Viresh, Nishanth or Stephen can provide some insight. Steve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C16FDC2BA19 for ; Mon, 13 Apr 2020 15:55:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99D4520656 for ; Mon, 13 Apr 2020 15:55:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99D4520656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F03F48924B; Mon, 13 Apr 2020 15:55:10 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 910748924B for ; Mon, 13 Apr 2020 15:55:09 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 022341FB; Mon, 13 Apr 2020 08:55:09 -0700 (PDT) Received: from [192.168.1.179] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C73EA3F68F; Mon, 13 Apr 2020 08:55:07 -0700 (PDT) Subject: Re: [PATCH 2/2] drm/panfrost: add devfreq regulator support To: =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= References: <20200411200632.4045-1-peron.clem@gmail.com> <20200411200632.4045-2-peron.clem@gmail.com> From: Steven Price Message-ID: Date: Mon, 13 Apr 2020 16:55:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Tomeu Vizoso , Stephen Boyd , Viresh Kumar , linux-kernel , dri-devel , Alyssa Rosenzweig Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMTMvMDQvMjAyMCAxNTozMSwgQ2zDqW1lbnQgUMOpcm9uIHdyb3RlOgo+IEhpLAo+IAo+IE9u IE1vbiwgMTMgQXByIDIwMjAgYXQgMTY6MTgsIENsw6ltZW50IFDDqXJvbiA8cGVyb24uY2xlbUBn bWFpbC5jb20+IHdyb3RlOgo+Pgo+PiBIaSBTdGV2ZW4sCj4+Cj4+IE9uIE1vbiwgMTMgQXByIDIw MjAgYXQgMTU6MTgsIFN0ZXZlbiBQcmljZSA8c3RldmVuLnByaWNlQGFybS5jb20+IHdyb3RlOgo+ Pj4KPj4+IE9uIDExLzA0LzIwMjAgMjE6MDYsIENsw6ltZW50IFDDqXJvbiB3cm90ZToKPj4+PiBP UFAgdGFibGUgY2FuIGRlZmluZWQgYm90aCBmcmVxdWVuY3kgYW5kIHZvbHRhZ2UuCj4+Pj4KPj4+ PiBSZWdpc3RlciB0aGUgbWFsaSByZWd1bGF0b3IgaWYgaXQgZXhpc3QuCj4+Pj4KPj4+PiBTaWdu ZWQtb2ZmLWJ5OiBDbMOpbWVudCBQw6lyb24gPHBlcm9uLmNsZW1AZ21haWwuY29tPgo+Pj4+IC0t LQo+Pj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9wYW5mcm9zdC9wYW5mcm9zdF9kZXZmcmVxLmMgfCAz NCArKysrKysrKysrKysrKysrKystLS0KPj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3Qv cGFuZnJvc3RfZGV2aWNlLmggIHwgIDEgKwo+Pj4+ICAgIDIgZmlsZXMgY2hhbmdlZCwgMzEgaW5z ZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPj4+Pgo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZGV2ZnJlcS5jIGIvZHJpdmVycy9ncHUvZHJtL3Bh bmZyb3N0L3BhbmZyb3N0X2RldmZyZXEuYwo+Pj4+IGluZGV4IDYyNTQxZjRlZGQ4MS4uMmRjOGUy MzU1MzU4IDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5mcm9zdC9wYW5mcm9z dF9kZXZmcmVxLmMKPj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3Rf ZGV2ZnJlcS5jCj4+Pj4gQEAgLTc4LDEyICs3OCwyNiBAQCBpbnQgcGFuZnJvc3RfZGV2ZnJlcV9p bml0KHN0cnVjdCBwYW5mcm9zdF9kZXZpY2UgKnBmZGV2KQo+Pj4+ICAgICAgICBzdHJ1Y3QgZGV2 aWNlICpkZXYgPSAmcGZkZXYtPnBkZXYtPmRldjsKPj4+PiAgICAgICAgc3RydWN0IGRldmZyZXEg KmRldmZyZXE7Cj4+Pj4gICAgICAgIHN0cnVjdCB0aGVybWFsX2Nvb2xpbmdfZGV2aWNlICpjb29s aW5nOwo+Pj4+ICsgICAgIGNvbnN0IGNoYXIgKm1hbGkgPSAibWFsaSI7Cj4+Pj4gKyAgICAgc3Ry dWN0IG9wcF90YWJsZSAqb3BwX3RhYmxlID0gTlVMTDsKPj4+PiArCj4+Pj4gKyAgICAgLyogUmVn dWxhdG9yIGlzIG9wdGlvbmFsICovCj4+Pj4gKyAgICAgb3BwX3RhYmxlID0gZGV2X3BtX29wcF9z ZXRfcmVndWxhdG9ycyhkZXYsICZtYWxpLCAxKTsKPj4+Cj4+PiBUaGlzIGxvb2tzIGxpa2UgaXQg YXBwbGllcyBiZWZvcmUgM2UxMzk5YmNjZjUxICgiZHJtL3BhbmZyb3N0OiBBZGQKPj4+IHN1cHBv cnQgZm9yIG11bHRpcGxlIHJlZ3VsYXRvcnMiKSB3aGljaCBpcyBjdXJyZW50bHkgaW4gZHJtLW1p c2MtbmV4dAo+Pj4gKGFuZCBsaW51eC1uZXh0KS4gWW91IHdhbnQgc29tZXRoaW5nIG1vcmUgbGlr ZToKPj4KPj4gVGhhbmtzIGZvciB5b3UgcmV2aWV3LCBpbmRlZWQgSSBkaWRuJ3Qgc2VlIHRoYXQg bXVsdGlwbGUgcmVndWxhdG9ycwo+PiBzdXBwb3J0IGhhcyBiZWVuIGFkZGVkLgo+PiBXaWxsIHVw ZGF0ZSBpbiB2Mi4KPj4KPj4+Cj4+PiAgICAgICBvcHBfdGFibGUgPSBkZXZfcG1fb3BwX3NldF9y ZWd1bGF0b3JzKGRldiwKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcGZkZXYtPmNvbXAtPnN1cHBseV9uYW1lcywKPj4+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcGZkZXYtPmNvbXAtPm51bV9zdXBwbGllcyk7Cj4+Pgo+ Pj4gT3RoZXJ3aXNlIGEgcGxhdGZvcm0gd2l0aCBtdWx0aXBsZSByZWd1bGF0b3JzIHdvbid0IHdv cmsgY29ycmVjdGx5Lgo+Pj4KPj4+IEFsc28gcnVubmluZyBvbiBteSBmaXJlZmx5IChSSzMyODgp IGJvYXJkIEkgZ2V0IHRoZSBmb2xsb3dpbmcgd2FybmluZzoKPj4+Cj4+PiAgICAgIGRlYnVnZnM6 IERpcmVjdG9yeSAnZmZhMzAwMDAuZ3B1LW1hbGknIHdpdGggcGFyZW50ICd2ZGRfZ3B1JyBhbHJl YWR5Cj4+PiBwcmVzZW50IQo+Pj4KPj4+IFRoaXMgaXMgZHVlIHRvIHRoZSByZWd1bGF0b3IgZGVi dWdmcyBlbnRyaWVzIGdldHRpbmcgY3JlYXRlZCB0d2ljZSAob25jZQo+Pj4gaW4gcGFuZnJvc3Rf cmVndWxhdG9yX2luaXQoKSBhbmQgb25jZSBoZXJlKS4KPj4KPj4gSXMgaXQgYSB3YXJuaW5nIHRo YXQgc2hvdWxkIGJlIGNvbnNpZGVyIGFzIGFuIGVycm9yPyBMb29rJ3MgbW9yZSBhbiBpbmZvIG5v Pwo+PiBXaGF0IHNob3VsZCBiZSB0aGUgY29ycmVjdCBiZWhhdmlvciBpZiBhIGRldmljZSB3YW50 IHRvIHJlZ2lzdGVyIHR3bwo+PiB0aW1lcyB0aGUgc2FtZSByZWd1bGF0b3I/Cj4gCj4gT3Igd2Ug Y2FuIGNoYW5nZSB0aGUgbmFtZSBmcm9tIHZkZF9YWFggdG8gb3BwX3ZkZF9YWFggPwo+IGh0dHBz Oi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4L2xhdGVzdC9zb3VyY2UvZHJpdmVycy9vcHAvZGVi dWdmcy5jI0w0NQoKWWVzLCBJJ20gbm90IHN1cmUgdGhhdCBpdCdzIGFjdHVhbGx5IGEgcHJvYmxl bSBpbiBwcmFjdGljZS4gQW5kIGl0IG1heSAKd2VsbCBiZSBjb3JyZWN0IHRvIGNoYW5nZSB0aGlz IGluIHRoZSBnZW5lcmljIGNvZGUgcmF0aGVyIHRoYW4gdHJ5IHRvIAp3b3JrIGFyb3VuZCBpdCBp biBQYW5mcm9zdC4gQnV0IHdlIHNob3VsZG4ndCBzcGFtIHRoZSB1c2VyIHdpdGggd2FybmluZ3Mg CmFzIHRoYXQgbWFrZXMgcmVhbCBpc3N1ZXMgaGFyZGVyIHRvIHNlZS4KCllvdXIgc3VnZ2VzdGlv biB0byBjaGFuZ2UgdGhlIG5hbWUgc2VlbXMgcmVhc29uYWJsZSB0byBtZSwgYnV0IEkgZG9uJ3Qg CmZ1bGx5IHVuZGVyc3RhbmQgdGhlIG9wcCBjb2RlLCBzbyB3ZSdkIG5lZWQgc29tZSByZXZpZXcg ZnJvbSB0aGUgT1BQIAptYWludGFpbmVycy4gSG9wZWZ1bGx5IFZpcmVzaCwgTmlzaGFudGggb3Ig U3RlcGhlbiBjYW4gcHJvdmlkZSBzb21lIGluc2lnaHQuCgpTdGV2ZQpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK