From: Jan Beulich <jbeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/2] common: map_vcpu_info() cosmetics
Date: Thu, 16 Jul 2020 17:01:10 +0200 [thread overview]
Message-ID: <d64ee03f-4663-39ce-fd72-5702029e0182@suse.com> (raw)
In-Reply-To: <20200716144219.GQ7191@Air-de-Roger>
On 16.07.2020 16:42, Roger Pau Monné wrote:
> On Thu, Jul 16, 2020 at 01:48:51PM +0200, Jan Beulich wrote:
>> On 16.07.2020 13:41, Roger Pau Monné wrote:
>>> On Wed, Jul 15, 2020 at 12:15:10PM +0200, Jan Beulich wrote:
>>>> Use ENXIO instead of EINVAL to cover the two cases of the address not
>>>> satisfying the requirements. This will make an issue here better stand
>>>> out at the call site.
>>>
>>> Not sure whether I would use EFAULT instead of ENXIO, as the
>>> description of it is 'bad address' which seems more inline with the
>>> error that we are trying to report.
>>
>> The address isn't bad in the sense of causing a fault, it's just
>> that we elect to not allow it. Hence I don't think EFAULT is
>> suitable. I'm open to replacement suggestions for ENXIO, though.
>
> Well, using an address that's not properly aligned to the requirements
> of an interface would cause a fault? (in this case it's a software
> interface, but the concept applies equally).
Not necessarily, see x86'es behavior. Also even on strict arches
it is typically possible to cover for the misalignment by using
suitable instructions; it's still an implementation choice to not
do so.
> Anyway, not something worth arguing about I think, so unless someone
> else disagrees I'm fine with using ENXIO.
Good, thanks.
Jan
next prev parent reply other threads:[~2020-07-16 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 10:13 [PATCH 0/2] common: XSA-327 follow-up Jan Beulich
2020-07-15 10:15 ` [PATCH 1/2] common: map_vcpu_info() cosmetics Jan Beulich
2020-07-16 11:41 ` Roger Pau Monné
2020-07-16 11:48 ` Jan Beulich
2020-07-16 14:42 ` Roger Pau Monné
2020-07-16 15:01 ` Jan Beulich [this message]
2020-07-16 16:17 ` Julien Grall
2020-07-17 8:16 ` Jan Beulich
2020-07-17 9:22 ` Julien Grall
2020-07-17 10:56 ` Jan Beulich
2020-07-15 10:16 ` [PATCH 2/2] evtchn/fifo: don't enforce higher than necessary alignment Jan Beulich
2020-07-15 10:46 ` Julien Grall
2020-07-15 12:42 ` Jan Beulich
2020-07-15 14:02 ` Julien Grall
2020-07-16 12:06 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d64ee03f-4663-39ce-fd72-5702029e0182@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.