From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5588EC433F5 for ; Thu, 12 May 2022 01:31:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbiELBbI (ORCPT ); Wed, 11 May 2022 21:31:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233371AbiELBbG (ORCPT ); Wed, 11 May 2022 21:31:06 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 591752A701 for ; Wed, 11 May 2022 18:30:58 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id t25so6469686lfg.7 for ; Wed, 11 May 2022 18:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZpnNREMqXrGizQWJD1QlgIKnhRMzjLbf/0mlxcPUNoY=; b=ubJMdDXJ5EZ1iKA+Zi4FaQCbOMhqLtGXLqQNQDYlQykXje9JVXVG1TBe8VOiIz+9UG ZLl0/Tg9qZmpr2wfWAXllTDJSX/IrR9tmSkA50GJyI1USWumZWgE9Ysu53HFKZZgeOk4 NFOjCTmF1wFU+/A0IhLZ+ghRW406T7EoHfETAHMV7PZCZIUUwMyCo/TzAha44ot+FFgZ ZM1ZJKUE+AROwB5f2vOoscHXLR/B9SvSqOaa9g8RivX2NlZci7fWo+xWn/5UBHhY0yUo S5TvpnkJPNQmQenT96T0EJz4M18jwjsTHgtyfaC+F3al7hmyjNMOrgzxf54Wo5RKMdlr zUHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZpnNREMqXrGizQWJD1QlgIKnhRMzjLbf/0mlxcPUNoY=; b=p55MtKTuFMS7jEu5c3Yw/D/a0Li0842J1s+mffgd9BhGOXqT7ODOwjLZZQJBhocsHz JE0h4V2evD4DtuG94BcQthtnPSuHQY4wWUsyqZm99U9OZ5CbrrSN5tjW2oy9OXUQ6qNw p1C6w6PXaU1aV7PNaM8NSpVqfi3EMX0xc3afVK76Hc8KS25OFstO+RQTsPhzZ6qv2S4C bQDz35NwL1mFQPkbd0fIpn3B3ZEJj/0Q1tvRBo37Xm3WaLZYtP5aqzZfvebQ9atChJUZ p0YuDR1eZwmNH36lr5dCeegSfrROcF53vvH1ksQBu/wSdgxaQXis4GAcNOOpKKB5iAbk yYrQ== X-Gm-Message-State: AOAM531a5WagTPL0gVYFeRSEeccO2ShhTrIuQx8sanjzaBHX/i1tNPhg XxVg3B2Xg60wyCUAfVSqAReN9TbvVZdIVA== X-Google-Smtp-Source: ABdhPJxz17HVXDGHrRDxjhowtM7J2TMXaJUPSrh389/cSdrGgYk75oaZeDPixbSwCmszFF1acZCX+w== X-Received: by 2002:a05:6512:3f8c:b0:45d:cb2a:8779 with SMTP id x12-20020a0565123f8c00b0045dcb2a8779mr23112877lfa.499.1652319056668; Wed, 11 May 2022 18:30:56 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id 1-20020ac25681000000b0047255d2110asm535897lfr.57.2022.05.11.18.30.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 18:30:56 -0700 (PDT) Message-ID: Date: Thu, 12 May 2022 04:30:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] drm/msm: don't free the IRQ if it was not requested Content-Language: en-GB To: Stephen Boyd Cc: Abhinav Kumar , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20220507010021.1667700-1-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 12/05/2022 04:29, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022-05-11 18:01:31) >> On Thu, 12 May 2022 at 03:54, Stephen Boyd wrote: >>> >>> Quoting Dmitry Baryshkov (2022-05-06 18:00:20) >>> >>> Does this supersede commit 01013ba9bbdd ("drm/msm/disp/dpu1: avoid >>> clearing hw interrupts if hw_intr is null during drm uninit")? I mean >>> that with this patch applied kms->irq_requested makes the check in >>> dpu_core_irq_uninstall() irrelevant because it isn't called anymore? >> >> Yes. >> > > I didn't see it deleted in the second patch so is a revert going to be > sent? No need to. They are separate checks. The older one is superseded (as it will be never hit), but it is still valid and useful (to protect from the crash if this code changes again). -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 731DBC433F5 for ; Thu, 12 May 2022 01:31:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 30ECD10EC4C; Thu, 12 May 2022 01:30:59 +0000 (UTC) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by gabe.freedesktop.org (Postfix) with ESMTPS id 711DA10EC4C for ; Thu, 12 May 2022 01:30:58 +0000 (UTC) Received: by mail-lf1-x129.google.com with SMTP id p26so6447595lfh.10 for ; Wed, 11 May 2022 18:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ZpnNREMqXrGizQWJD1QlgIKnhRMzjLbf/0mlxcPUNoY=; b=ubJMdDXJ5EZ1iKA+Zi4FaQCbOMhqLtGXLqQNQDYlQykXje9JVXVG1TBe8VOiIz+9UG ZLl0/Tg9qZmpr2wfWAXllTDJSX/IrR9tmSkA50GJyI1USWumZWgE9Ysu53HFKZZgeOk4 NFOjCTmF1wFU+/A0IhLZ+ghRW406T7EoHfETAHMV7PZCZIUUwMyCo/TzAha44ot+FFgZ ZM1ZJKUE+AROwB5f2vOoscHXLR/B9SvSqOaa9g8RivX2NlZci7fWo+xWn/5UBHhY0yUo S5TvpnkJPNQmQenT96T0EJz4M18jwjsTHgtyfaC+F3al7hmyjNMOrgzxf54Wo5RKMdlr zUHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ZpnNREMqXrGizQWJD1QlgIKnhRMzjLbf/0mlxcPUNoY=; b=FimGXe2Kc/i5bs1SFXjUbb164Iwv3b2bc/JuIRnGEn7xgJVJ5gl9OFf/7uQHAjYLl2 EZQGziLt8+bc/tG1PloEi3U0CBky9HVrMxgY1dbQZMHmLdPwywi03KICFZbX5DDyp43v Uib+lklpFWnqllCOE0SyHsB+pWFtxaKZHpFniaug7qPdsLrd6Q5lXX4CVULhywDXQ3uu Lx48T5HRkacetKd8F6ySs5A8bdewJVxU/Khqt4LdY44hPajYrtpDwv7yPq8K+STAl9XZ DmP2bgFqzWyM7BujeMt4p3QjwRDHTUbPSlALAwdrssnhk8KhkutuWumnV3A3/upA3IUx gjwg== X-Gm-Message-State: AOAM533gC/wOkCNXTGTf3rdMlcLK+RZv7wGqWnBhRc3j9EwXHmeba16U FeK1sQy9wquMVMtJrl3QW02w1A== X-Google-Smtp-Source: ABdhPJxz17HVXDGHrRDxjhowtM7J2TMXaJUPSrh389/cSdrGgYk75oaZeDPixbSwCmszFF1acZCX+w== X-Received: by 2002:a05:6512:3f8c:b0:45d:cb2a:8779 with SMTP id x12-20020a0565123f8c00b0045dcb2a8779mr23112877lfa.499.1652319056668; Wed, 11 May 2022 18:30:56 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id 1-20020ac25681000000b0047255d2110asm535897lfr.57.2022.05.11.18.30.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 18:30:56 -0700 (PDT) Message-ID: Date: Thu, 12 May 2022 04:30:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 1/2] drm/msm: don't free the IRQ if it was not requested Content-Language: en-GB To: Stephen Boyd References: <20220507010021.1667700-1-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, Bjorn Andersson , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 12/05/2022 04:29, Stephen Boyd wrote: > Quoting Dmitry Baryshkov (2022-05-11 18:01:31) >> On Thu, 12 May 2022 at 03:54, Stephen Boyd wrote: >>> >>> Quoting Dmitry Baryshkov (2022-05-06 18:00:20) >>> >>> Does this supersede commit 01013ba9bbdd ("drm/msm/disp/dpu1: avoid >>> clearing hw interrupts if hw_intr is null during drm uninit")? I mean >>> that with this patch applied kms->irq_requested makes the check in >>> dpu_core_irq_uninstall() irrelevant because it isn't called anymore? >> >> Yes. >> > > I didn't see it deleted in the second patch so is a revert going to be > sent? No need to. They are separate checks. The older one is superseded (as it will be never hit), but it is still valid and useful (to protect from the crash if this code changes again). -- With best wishes Dmitry