Re: [PATCH 4/5] drm/panfrost: remove DRM_AUTH and respective comment

[Steven Price <steven.price@arm.com>]

On 01/11/2019 13:03, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@collabora.com>
> 
> As of earlier commit we have address space separation. Yet we forgot to
> remove the respective comment and DRM_AUTH in the ioctl declaration.
> 
> Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Steven Price <steven.price@arm.com>
> Fixes: 7282f7645d06 ("drm/panfrost: Implement per FD address spaces")
> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>

Reviewed-by: Steven Price <steven.price@arm.com>

I'm not sure DRM_AUTH provided us with much in the first place (because
render nodes could snoop/affect the primary node), but since we have
address space separation it's clearly not required now.

Steve

> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index bc2ddeb55f5d..c677b2c9e409 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -451,15 +451,11 @@ panfrost_postclose(struct drm_device *dev, struct drm_file *file)
>  	kfree(panfrost_priv);
>  }
>  
> -/* DRM_AUTH is required on SUBMIT for now, while all clients share a single
> - * address space.  Note that render nodes would be able to submit jobs that
> - * could access BOs from clients authenticated with the master node.
> - */
>  static const struct drm_ioctl_desc panfrost_drm_driver_ioctls[] = {
>  #define PANFROST_IOCTL(n, func, flags) \
>  	DRM_IOCTL_DEF_DRV(PANFROST_##n, panfrost_ioctl_##func, flags)
>  
> -	PANFROST_IOCTL(SUBMIT,		submit,		DRM_RENDER_ALLOW | DRM_AUTH),
> +	PANFROST_IOCTL(SUBMIT,		submit,		DRM_RENDER_ALLOW),
>  	PANFROST_IOCTL(WAIT_BO,		wait_bo,	DRM_RENDER_ALLOW),
>  	PANFROST_IOCTL(CREATE_BO,	create_bo,	DRM_RENDER_ALLOW),
>  	PANFROST_IOCTL(MMAP_BO,		mmap_bo,	DRM_RENDER_ALLOW),
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel