From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Price Date: Wed, 23 Oct 2019 11:12:36 +0100 Subject: [Cluster-devel] [PATCH] gfs2: Fix memory leak when gfs2meta's fs_context is freed In-Reply-To: References: <000000000000afc1b40593f68888@google.com> <20191003153552.2015-1-anprice@redhat.com> <824921067.4882112.1570209623167.JavaMail.zimbra@redhat.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 09/10/2019 07:36, Andrew Price wrote: > On 04/10/2019 18:20, Bob Peterson wrote: >> ----- Original Message ----- >>> gfs2 and gfs2meta share an ->init_fs_context function which allocates an >>> args structure stored in fc->fs_private. gfs2 registers a ->free >>> function to free this memory when the fs_context is cleaned up, but >>> there was not one registered for gfs2meta, causing a leak. >>> >>> Register a ->free function for gfs2meta. The existing gfs2_fc_free >>> function does what we need. >>> >>> Reported-by: syzbot+c2fdfd2b783754878fb6 at syzkaller.appspotmail.com >>> Signed-off-by: Andrew Price >>> --- >> >> Thanks. Now pushed to for-next. > > Thanks Bob. Can we get this sent to Linus as a fix during this cycle? > > Andy > It might need a Fixes: 1f52aa08d12f8d359e71b4bfd73ca9d5d668e4da That commit went upstream during this cycle's merge window so if we can get the fix upstream before release we won't have to worry about stable. Andy