From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lelnx193.ext.ti.com ([198.47.27.77]:55023 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754277AbeDZKOU (ORCPT ); Thu, 26 Apr 2018 06:14:20 -0400 From: "Reizer, Eyal" To: Kalle Valo CC: Eyal Reizer , "linux-wireless@vger.kernel.org" , "robh@kernel.org" , "sre@kernel.org" , "tony@atomide.com" , "linux-kernel@vger.kernel.org" Subject: RE: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power Date: Thu, 26 Apr 2018 10:14:13 +0000 Message-ID: (sfid-20180426_121425_215368_95DFEC22) References: <1524721631-5983-1-git-send-email-eyalr@ti.com> <87po2m7573.fsf@kamboji.qca.qualcomm.com> <4750eeeedcde47d39cd207a8c21ef802@ti.com> <87lgda71zl.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87lgda71zl.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: >=20 > >> > >> > pm_runtime handles sdio power on and power off transitions. > >> > An old workaround for trying to control the power explicitly from th= e > >> > driver was in fact causing failures on suspend/resume as the mmc lay= er > >> > already power the module on resume. > >> > > >> > In case of resume pm_runtime_get sync returns a positive device's > usage > >> > count causing the driver to try an re-initialize an already initiali= zed > >> > device. This was causing sdio bus failure on resume. > >> > > >> > Remove this manual power on/off sequence as it is in-fact not needed= . > >> > > >> > Signed-off-by: Eyal Reizer > >> > Acked-by: Tony Lindgren > >> > >> No changelog. > >> > >> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingp > >> atches#changelog_missing > >> > >> No need to resubmit because of this, I guess you just fixed the title > >> and added Tony's Acked-by? > > > > Yes, this is correct. No change in the actual patch hence there was no > change > > Log. >=20 > _Always_ include a change log, even if you didn't actually change > anything. Otherwise the maintainer has no clue what has changed and why > a new version was submitted. >=20 Understood. Thanks! BR, Eyal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755234AbeDZKOW (ORCPT ); Thu, 26 Apr 2018 06:14:22 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:55023 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754277AbeDZKOU (ORCPT ); Thu, 26 Apr 2018 06:14:20 -0400 From: "Reizer, Eyal" To: Kalle Valo CC: Eyal Reizer , "linux-wireless@vger.kernel.org" , "robh@kernel.org" , "sre@kernel.org" , "tony@atomide.com" , "linux-kernel@vger.kernel.org" Subject: RE: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power Thread-Topic: [EXTERNAL] Re: [PATCH v2] wlcore: sdio: allow pm to handle sdio power Thread-Index: AQHT3UCfetw9p/qzd0ix7CJgDFtru6QS1AWQ Date: Thu, 26 Apr 2018 10:14:13 +0000 Message-ID: References: <1524721631-5983-1-git-send-email-eyalr@ti.com> <87po2m7573.fsf@kamboji.qca.qualcomm.com> <4750eeeedcde47d39cd207a8c21ef802@ti.com> <87lgda71zl.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87lgda71zl.fsf@kamboji.qca.qualcomm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [137.167.25.139] x-exclaimer-md-config: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w3QAESF2019682 > > >> > >> > pm_runtime handles sdio power on and power off transitions. > >> > An old workaround for trying to control the power explicitly from the > >> > driver was in fact causing failures on suspend/resume as the mmc layer > >> > already power the module on resume. > >> > > >> > In case of resume pm_runtime_get sync returns a positive device's > usage > >> > count causing the driver to try an re-initialize an already initialized > >> > device. This was causing sdio bus failure on resume. > >> > > >> > Remove this manual power on/off sequence as it is in-fact not needed. > >> > > >> > Signed-off-by: Eyal Reizer > >> > Acked-by: Tony Lindgren > >> > >> No changelog. > >> > >> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingp > >> atches#changelog_missing > >> > >> No need to resubmit because of this, I guess you just fixed the title > >> and added Tony's Acked-by? > > > > Yes, this is correct. No change in the actual patch hence there was no > change > > Log. > > _Always_ include a change log, even if you didn't actually change > anything. Otherwise the maintainer has no clue what has changed and why > a new version was submitted. > Understood. Thanks! BR, Eyal