From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB09C04A68 for ; Thu, 28 Jul 2022 03:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237023AbiG1DDW (ORCPT ); Wed, 27 Jul 2022 23:03:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231383AbiG1DDS (ORCPT ); Wed, 27 Jul 2022 23:03:18 -0400 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6572D5A3FC; Wed, 27 Jul 2022 20:03:17 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=dtcccc@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VKdMdjt_1658977393; Received: from 30.97.49.29(mailfrom:dtcccc@linux.alibaba.com fp:SMTPD_---0VKdMdjt_1658977393) by smtp.aliyun-inc.com; Thu, 28 Jul 2022 11:03:14 +0800 Message-ID: Date: Thu, 28 Jul 2022 11:03:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 5.10 373/575] selftests: bpf: Convert sk_lookup ctx access tests to PROG_TEST_RUN Content-Language: en-US To: Greg KH Cc: ast@kernel.org, linux-kernel@vger.kernel.org, lmb@cloudflare.com, sashal@kernel.org, stable@vger.kernel.org References: <20211115165356.685521944@linuxfoundation.org> <6258c4a1-0132-5afe-8dab-afa4ca3c49d6@linux.alibaba.com> From: Tianchen Ding In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/7/27 18:10, Greg KH wrote: > On Mon, Jul 25, 2022 at 10:53:38AM +0800, Tianchen Ding wrote: >> Hi Greg. >> >> We found a compile error when building tools/testing/selftests/bpf/ on 5.10. >> >> tools/testing/selftests/bpf/prog_tests/sk_lookup.c:1092:15: error: 'struct bpf_sk_lookup' has no member named 'cookie' >> 1092 | if (CHECK(ctx.cookie == 0, "ctx.cookie", "no socket selected\n")) >> >> It requires 7c32e8f8bc33 ("bpf: Add PROG_TEST_RUN support for sk_lookup programs") from upstream. >> >> Maybe the left patches of this patchset are needed for 5.10 LTS? >> https://lore.kernel.org/bpf/20210303101816.36774-1-lmb@cloudflare.com/ > > If so, please submit them with the git commit ids so that I can fix this > up. > > thanks, > > greg k-h These 2 commits from upstream are necessary for bpf selftests build pass on 5.10.y: 607b9cc92bd7208338d714a22b8082fe83bcb177 bpf: Consolidate shared test timing code 7c32e8f8bc33a5f4b113a630857e46634e3e143b bpf: Add PROG_TEST_RUN support for sk_lookup programs This commit does not impact building stage, but can avoid a test case failure (by skipping it): b4f894633fa14d7d46ba7676f950b90a401504bb selftests: bpf: Don't run sk_lookup in verifier tests Thanks.