From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
linux-leds@vger.kernel.org, Kyle Swenson <kyle.swenson@est.tech>,
Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
devicetree@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-kernel@vger.kernel.org, Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses in example
Date: Tue, 19 Jul 2022 09:37:14 +0200 [thread overview]
Message-ID: <d67e3a36-ccc7-2fb5-35da-315212370776@linaro.org> (raw)
In-Reply-To: <1e71759b-32a1-3f35-6c08-b9ea4611e361@linaro.org>
On 20/06/2022 18:04, Krzysztof Kozlowski wrote:
> On 07/06/2022 09:52, Krzysztof Kozlowski wrote:
>> The multi-led node defined address/size cells, so it is intended to have
>> children with unit addresses.
>>
>> The second multi-led's reg property defined three LED indexes within one
>> reg item, which is not correct - these are three separate items.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>>
>> ---
>
> Pavel, Jacek,
>
> Any comments on these two patches?
Pavel,
Although previously this was "just" correcting the example, now it is
actually a needed fix because of changes which came later:
https://lore.kernel.org/all/CAL_JsqKHviWcynOu5AYJxtJ5xbQU6cU+r6tHy=ao+Wt4mE1aVQ@mail.gmail.com/
Can you apply it?
Best regards,
Krzysztof
prev parent reply other threads:[~2022-07-19 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 7:52 [PATCH v3 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses in example Krzysztof Kozlowski
2022-06-07 7:52 ` [PATCH v3 2/2] dt-bindings: leds: fix indentation in examples Krzysztof Kozlowski
2022-07-19 7:37 ` Krzysztof Kozlowski
2022-07-21 17:10 ` Rob Herring
2022-06-20 16:04 ` [PATCH v3 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses in example Krzysztof Kozlowski
2022-07-19 7:37 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d67e3a36-ccc7-2fb5-35da-315212370776@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyle.swenson@est.tech \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sven.schwermer@disruptive-technologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.