From: "Michel Dänzer" <michel.daenzer@mailbox.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu/gmc: use PCI BARs for APUs in passthrough
Date: Wed, 16 Mar 2022 16:58:28 +0100 [thread overview]
Message-ID: <d68190bf-c4c9-4557-dfc2-4e26aab83924@mailbox.org> (raw)
In-Reply-To: <CADnq5_MBK2VP9A6r1MtiMFvBrmO7Tc5Y=RtENWoEhopp8BY3aw@mail.gmail.com>
On 2022-03-16 16:55, Alex Deucher wrote:
> On Wed, Mar 16, 2022 at 11:52 AM Michel Dänzer
> <michel.daenzer@mailbox.org> wrote:
>>
>> On 2022-03-11 18:43, Michel Dänzer wrote:
>>> On 2022-03-11 11:32, Christian König wrote:
>>>> Am 11.03.22 um 11:24 schrieb Michel Dänzer:
>>>>> On 2022-03-10 19:06, Alex Deucher wrote:
>>>>>> If the GPU is passed through to a guest VM, use the PCI
>>>>>> BAR for CPU FB access rather than the physical address of
>>>>>> carve out. The physical address is not valid in a guest.
>>>>> I think amdgpu_device_flush_hdp & amdgpu_device_invalidate_hdp need to be modified accordingly.
>>>
>>> I'm surprised you gave your R-b despite this. Surely the HDP cache needs to be handled when going through the BAR?
>>
>> I'm a bit confused why there's still been no response on this point from either of you. Are you guys checking internally whether or not this is needed?
>
> Yes, it is needed. I added it in v2 of the patch.
Ah, great, hadn't seen the v2 patch yet. :)
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
next prev parent reply other threads:[~2022-03-16 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 18:06 [PATCH] drm/amdgpu/gmc: use PCI BARs for APUs in passthrough Alex Deucher
2022-03-11 10:24 ` Michel Dänzer
2022-03-11 10:32 ` Christian König
2022-03-11 17:43 ` Michel Dänzer
2022-03-16 15:52 ` Michel Dänzer
2022-03-16 15:55 ` Alex Deucher
2022-03-16 15:58 ` Michel Dänzer [this message]
2022-03-11 12:17 ` Christian König
2022-03-15 18:13 Alex Deucher
2022-03-16 7:18 ` Christian König
2022-03-16 15:59 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d68190bf-c4c9-4557-dfc2-4e26aab83924@mailbox.org \
--to=michel.daenzer@mailbox.org \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ckoenig.leichtzumerken@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.