Re: [PATCH] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Vincent Prince <vincent.prince.fr@gmail.com>
Cc: jiri@resnulli.us, jhs@mojatatu.com, netdev@vger.kernel.org,
	dave.taht@gmail.com, linux-can@vger.kernel.org,
	kernel@pengutronix.de, xiyou.wangcong@gmail.com,
	davem@davemloft.net
Subject: Re: [PATCH] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware
Date: Tue, 22 Oct 2019 14:58:33 +0200	[thread overview]
Message-ID: <d6902a1c-af8f-7d47-4f9b-d037c6be70d5@pengutronix.de> (raw)
In-Reply-To: <1571748448-11190-1-git-send-email-vincent.prince.fr@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1095 bytes --]

On 10/22/19 2:47 PM, Vincent Prince wrote:
> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>

Please add the patch description, preferred that one from my original patch.

> ---
>  net/sched/sch_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> index 77b289d..bff43de 100644
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -1008,6 +1008,8 @@ static void attach_one_default_qdisc(struct net_device *dev,
>  
>  	if (dev->priv_flags & IFF_NO_QUEUE)
>  		ops = &noqueue_qdisc_ops;
> +        else if(dev->type == ARPHRD_CAN)
^^^^^^^^^^^^^^^
use one tab to indent.

> +		ops = &pfifo_fast_ops;
>  
>  	qdisc = qdisc_create_dflt(dev_queue, ops, TC_H_ROOT, NULL);
>  	if (!qdisc) {
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]