From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manikanta Maddireddy Subject: Re: [PATCH 03/10] PM / QoS: Fix device resume latency for non PM QoS devices Date: Sun, 26 Nov 2017 01:16:42 +0530 Message-ID: References: <1511538800-8275-1-git-send-email-mmaddireddy@nvidia.com> <1511538800-8275-4-git-send-email-mmaddireddy@nvidia.com> <20171124203940.GA12811@mithrandir> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" , Thierry Reding Cc: Jon Hunter , Rob Herring , Frank Rowand , Bjorn Helgaas , "Rafael J. Wysocki" , Thomas Gleixner , vidyas-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, kthota-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linux PCI , Linux PM List-Id: linux-tegra@vger.kernel.org On 25-Nov-17 5:32 AM, Rafael J. Wysocki wrote: > On Fri, Nov 24, 2017 at 9:39 PM, Thierry Reding > wrote: >> On Fri, Nov 24, 2017 at 05:50:42PM +0100, Rafael J. Wysocki wrote: >>> On Fri, Nov 24, 2017 at 4:53 PM, Manikanta Maddireddy >>> wrote: >>>> In 'commit 0cc2b4e5a020 ("PM / QoS: Fix device resume latency PM QoS")' >>>> PM QoS resume latency modified 0 as "no latency at all". However >>>> dev_pm_qos_raw_read_value() returns 0 for devices which doesn't have >>>> PM QoS constraints. This is blocking runtime suspend for these devices >>>> in rpm_check_suspend_allowed(). Return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT >>>> when PM QoS constraints are not available for a particular device. >>>> >>>> Fixes: 0cc2b4e5a020 ("PM / QoS: Fix device resume latency PM QoS") >>> >>> That commit has been reverted, so this patch is not applicable and >>> therefore the whole series isn't. >>> >>> What kernel is it based off? >> >> It looks like this might have crept in via commit 0759e80b84e3 ("PM / >> QoS: Fix device resume latency framework"). But checking more closely, >> that commit actually incorporates this change already. >> >> According to the git log the correct commit for this showed up in >> linux-next only today, which is probably why Manikanta missed it. > > Well, it's been in the Linus' tree for a week, though. > > Thanks, > Rafael > I dropped this patch in V2. Thanks, Manikanta -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate14.nvidia.com ([216.228.121.143]:14081 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbdKYTq4 (ORCPT ); Sat, 25 Nov 2017 14:46:56 -0500 Subject: Re: [PATCH 03/10] PM / QoS: Fix device resume latency for non PM QoS devices To: "Rafael J. Wysocki" , Thierry Reding CC: Jon Hunter , Rob Herring , "Frank Rowand" , Bjorn Helgaas , "Rafael J. Wysocki" , Thomas Gleixner , , , , "devicetree@vger.kernel.org" , Linux PCI , Linux PM References: <1511538800-8275-1-git-send-email-mmaddireddy@nvidia.com> <1511538800-8275-4-git-send-email-mmaddireddy@nvidia.com> <20171124203940.GA12811@mithrandir> From: Manikanta Maddireddy Message-ID: Date: Sun, 26 Nov 2017 01:16:42 +0530 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Sender: linux-pci-owner@vger.kernel.org List-ID: On 25-Nov-17 5:32 AM, Rafael J. Wysocki wrote: > On Fri, Nov 24, 2017 at 9:39 PM, Thierry Reding > wrote: >> On Fri, Nov 24, 2017 at 05:50:42PM +0100, Rafael J. Wysocki wrote: >>> On Fri, Nov 24, 2017 at 4:53 PM, Manikanta Maddireddy >>> wrote: >>>> In 'commit 0cc2b4e5a020 ("PM / QoS: Fix device resume latency PM QoS")' >>>> PM QoS resume latency modified 0 as "no latency at all". However >>>> dev_pm_qos_raw_read_value() returns 0 for devices which doesn't have >>>> PM QoS constraints. This is blocking runtime suspend for these devices >>>> in rpm_check_suspend_allowed(). Return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT >>>> when PM QoS constraints are not available for a particular device. >>>> >>>> Fixes: 0cc2b4e5a020 ("PM / QoS: Fix device resume latency PM QoS") >>> >>> That commit has been reverted, so this patch is not applicable and >>> therefore the whole series isn't. >>> >>> What kernel is it based off? >> >> It looks like this might have crept in via commit 0759e80b84e3 ("PM / >> QoS: Fix device resume latency framework"). But checking more closely, >> that commit actually incorporates this change already. >> >> According to the git log the correct commit for this showed up in >> linux-next only today, which is probably why Manikanta missed it. > > Well, it's been in the Linus' tree for a week, though. > > Thanks, > Rafael > I dropped this patch in V2. Thanks, Manikanta