From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933769AbcIUSSr (ORCPT ); Wed, 21 Sep 2016 14:18:47 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:55312 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933024AbcIUSSo (ORCPT ); Wed, 21 Sep 2016 14:18:44 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Wed, 21 Sep 2016 11:13:12 -0700 From: Stefan Agner To: Meng Yi Cc: dri-devel@lists.freedesktop.org, alison.wang@freescale.com, jianwei.wang.chn@gmail.com, linux-kernel@vger.kernel.org Subject: RE: [PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support In-Reply-To: References: <20160906040233.32471-1-stefan@agner.ch> Message-ID: User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-09-07 01:43, Meng Yi wrote: > Hi Stefan, > > I had tested the patches on LS1021A-TWR board using drmlib. > > Like set three overlays: > root@ls1021atwr:~# ./modetest -P 39:900x100+10+10@RG24 -P > 39:200x200+300+0@RG24 -P 39:200x200+400+300@RG24 > > How did you test the overlays and cursor layer, I mean I see you using > x-window like thing in the video. I did use X with the modesetting driver. You just need to choose modesetting in your xorg.conf, and it should make use of the cursor layer automatically. >> This patchset adds overlay and cursor plane support. It also fixes some issues >> uncovered during implementation of this. >> >> However, the plane updates currently causes the display to flicker for unknown >> reasons. As far as I can tell, the CRTC atomic_flush should trigger the update >> correctly via READREG, which according to >> documentation: >> The READREG bit causes a single transfer to begin at the next frame blanking >> period. This bit is cleared when the transfer is complete. >> >> I made a video how that looks: >> https://cloud.agner.ch/index.php/s/Yfqa2u7UBEWUT8N It would be interesting whether you see that on LS1021a too. -- Stefan >> >> Any ideas? >> >> Stefan Agner (4): >> drm/fsl-dcu: support overlay and cursor planes >> drm/fsl-dcu: respect pos/size register sizes >> drm/fsl-dcu: update all registers on flush >> drm/fsl-dcu: do not update when modifying irq registers >> >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 50 >> ++++++++++++++++++++++++----- >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 --- >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h | 8 ++--- >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 42 +++++++++++------------- >> drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.h | 3 +- >> 5 files changed, 67 insertions(+), 40 deletions(-) >> >> -- >> 2.9.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: RE: [PATCH 0/4] drm/fsl-dcu: add overlay and cursor plane support Date: Wed, 21 Sep 2016 11:13:12 -0700 Message-ID: References: <20160906040233.32471-1-stefan@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1059B6E2EE for ; Wed, 21 Sep 2016 18:18:43 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Meng Yi Cc: jianwei.wang.chn@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, alison.wang@freescale.com List-Id: dri-devel@lists.freedesktop.org T24gMjAxNi0wOS0wNyAwMTo0MywgTWVuZyBZaSB3cm90ZToKPiBIaSBTdGVmYW4sCj4gCj4gSSBo YWQgdGVzdGVkIHRoZSBwYXRjaGVzIG9uIExTMTAyMUEtVFdSIGJvYXJkIHVzaW5nIGRybWxpYi4K PiAKPiBMaWtlIHNldCB0aHJlZSBvdmVybGF5czoKPiByb290QGxzMTAyMWF0d3I6fiMgLi9tb2Rl dGVzdCAtUCAzOTo5MDB4MTAwKzEwKzEwQFJHMjQgLVAKPiAzOToyMDB4MjAwKzMwMCswQFJHMjQg LVAgMzk6MjAweDIwMCs0MDArMzAwQFJHMjQKPiAKPiBIb3cgZGlkIHlvdSB0ZXN0IHRoZSBvdmVy bGF5cyBhbmQgY3Vyc29yIGxheWVyLCBJIG1lYW4gSSBzZWUgeW91IHVzaW5nCj4geC13aW5kb3cg bGlrZSB0aGluZyBpbiB0aGUgIHZpZGVvLgoKSSBkaWQgdXNlIFggd2l0aCB0aGUgbW9kZXNldHRp bmcgZHJpdmVyLiBZb3UganVzdCBuZWVkIHRvIGNob29zZQptb2Rlc2V0dGluZyBpbiB5b3VyIHhv cmcuY29uZiwgYW5kIGl0IHNob3VsZCBtYWtlIHVzZSBvZiB0aGUgY3Vyc29yCmxheWVyIGF1dG9t YXRpY2FsbHkuCgo+PiBUaGlzIHBhdGNoc2V0IGFkZHMgb3ZlcmxheSBhbmQgY3Vyc29yIHBsYW5l IHN1cHBvcnQuIEl0IGFsc28gZml4ZXMgc29tZSBpc3N1ZXMKPj4gdW5jb3ZlcmVkIGR1cmluZyBp bXBsZW1lbnRhdGlvbiBvZiB0aGlzLgo+Pgo+PiBIb3dldmVyLCB0aGUgcGxhbmUgdXBkYXRlcyBj dXJyZW50bHkgY2F1c2VzIHRoZSBkaXNwbGF5IHRvIGZsaWNrZXIgZm9yIHVua25vd24KPj4gcmVh c29ucy4gQXMgZmFyIGFzIEkgY2FuIHRlbGwsIHRoZSBDUlRDIGF0b21pY19mbHVzaCBzaG91bGQg dHJpZ2dlciB0aGUgdXBkYXRlCj4+IGNvcnJlY3RseSB2aWEgUkVBRFJFRywgd2hpY2ggYWNjb3Jk aW5nIHRvCj4+IGRvY3VtZW50YXRpb246Cj4+IFRoZSBSRUFEUkVHIGJpdCBjYXVzZXMgYSBzaW5n bGUgdHJhbnNmZXIgdG8gYmVnaW4gYXQgdGhlIG5leHQgZnJhbWUgYmxhbmtpbmcKPj4gcGVyaW9k LiBUaGlzIGJpdCBpcyBjbGVhcmVkIHdoZW4gdGhlIHRyYW5zZmVyIGlzIGNvbXBsZXRlLgo+Pgo+ PiBJIG1hZGUgYSB2aWRlbyBob3cgdGhhdCBsb29rczoKPj4gaHR0cHM6Ly9jbG91ZC5hZ25lci5j aC9pbmRleC5waHAvcy9ZZnFhMnU3VUJFV1VUOE4KCkl0IHdvdWxkIGJlIGludGVyZXN0aW5nIHdo ZXRoZXIgeW91IHNlZSB0aGF0IG9uIExTMTAyMWEgdG9vLgoKLS0KU3RlZmFuCgo+Pgo+PiBBbnkg aWRlYXM/Cj4+Cj4+IFN0ZWZhbiBBZ25lciAoNCk6Cj4+ICAgZHJtL2ZzbC1kY3U6IHN1cHBvcnQg b3ZlcmxheSBhbmQgY3Vyc29yIHBsYW5lcwo+PiAgIGRybS9mc2wtZGN1OiByZXNwZWN0IHBvcy9z aXplIHJlZ2lzdGVyIHNpemVzCj4+ICAgZHJtL2ZzbC1kY3U6IHVwZGF0ZSBhbGwgcmVnaXN0ZXJz IG9uIGZsdXNoCj4+ICAgZHJtL2ZzbC1kY3U6IGRvIG5vdCB1cGRhdGUgd2hlbiBtb2RpZnlpbmcg aXJxIHJlZ2lzdGVycwo+Pgo+PiAgZHJpdmVycy9ncHUvZHJtL2ZzbC1kY3UvZnNsX2RjdV9kcm1f Y3J0Yy5jICB8IDUwCj4+ICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tCj4+ICBkcml2ZXJz L2dwdS9kcm0vZnNsLWRjdS9mc2xfZGN1X2RybV9kcnYuYyAgIHwgIDQgLS0tCj4+ICBkcml2ZXJz L2dwdS9kcm0vZnNsLWRjdS9mc2xfZGN1X2RybV9kcnYuaCAgIHwgIDggKystLS0KPj4gIGRyaXZl cnMvZ3B1L2RybS9mc2wtZGN1L2ZzbF9kY3VfZHJtX3BsYW5lLmMgfCA0MiArKysrKysrKysrKy0t LS0tLS0tLS0tLS0KPj4gZHJpdmVycy9ncHUvZHJtL2ZzbC1kY3UvZnNsX2RjdV9kcm1fcGxhbmUu aCB8ICAzICstCj4+ICA1IGZpbGVzIGNoYW5nZWQsIDY3IGluc2VydGlvbnMoKyksIDQwIGRlbGV0 aW9ucygtKQo+Pgo+PiAtLQo+PiAyLjkuMwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK