From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steven J. Hill" Subject: Re: [PATCH net-next v10 3/4] netdev: octeon-ethernet: Add Cavium Octeon III support. Date: Wed, 9 May 2018 14:29:56 -0500 Message-ID: References: <1525713731-27092-1-git-send-email-steven.hill@cavium.com> <1525713731-27092-4-git-send-email-steven.hill@cavium.com> <20180508.222824.409067086455315118.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: David Miller Return-path: Received: from mail-bl2nam02on0049.outbound.protection.outlook.com ([104.47.38.49]:27264 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964850AbeEITaH (ORCPT ); Wed, 9 May 2018 15:30:07 -0400 In-Reply-To: <20180508.222824.409067086455315118.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/08/2018 09:28 PM, David Miller wrote: > > That's all I have the stomache for at the moment. > > This thing is really large, making it nearly impossible to review > as one huge patch #3. Perhaps you can find a way to split it up > logically somehow? > Hey David. This code was inherited by me, so there a lot of parts I personally have not looked at. The third patch indeed needs to be broken up. Let me devote some hours to cleaning, splitting and simplifying. My apologies for the time you spent looking at it. The first patch, however, only makes changes in the existing 'staging' directory. It seems like that one could go in without trouble? Cheers. Steve