All of lore.kernel.org
 help / color / mirror / Atom feed
From: "akuster" <akuster808@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [dunfel 24/32] protobuf-c: disable parallelism to avoid race condition
Date: Tue, 30 Jun 2020 17:07:09 -0700	[thread overview]
Message-ID: <d6aff1ae4be6ef8d40d2e3232597ab994538a2a3.1593561840.git.akuster808@gmail.com> (raw)
In-Reply-To: <cover.1593561840.git.akuster808@gmail.com>

From: Paul Eggleton <paul.eggleton@linux.microsoft.com>

Unfortunately 489d3b4b932ee8016d792341f8ea5836a9522cd4 did not completely
fix the problem - if you try cleaning and rebuilding protobuf-c-native it
doesn't take long to reproduce the issue on a 32-core machine. I spent
some time trying to debug this but failed, there is still a race between
generating t.test-full.pb.h and compiling cxx_generate_packed_data.c
despite BUILT_SOURCES and explicit dependencies. I even tried converting
the multiple target rules to use grouped targets (&:), that didn't fix it
either. Disabling parallelism as a workaround only costs ~20s and it
turns out that upstream is switching to Meson soon anyway:

  https://github.com/protobuf-c/protobuf-c/pull/340

Signed-off-by: Paul Eggleton <paul.eggleton@linux.microsoft.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 3251fe210a91d13ab2a6c5b7ecb283aa8e019020)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
 meta-oe/recipes-devtools/protobuf/protobuf-c_1.3.3.bb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta-oe/recipes-devtools/protobuf/protobuf-c_1.3.3.bb b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.3.3.bb
index 94c3893574..ed8773443e 100644
--- a/meta-oe/recipes-devtools/protobuf/protobuf-c_1.3.3.bb
+++ b/meta-oe/recipes-devtools/protobuf/protobuf-c_1.3.3.bb
@@ -26,6 +26,11 @@ BUILD_CXXFLAGS += "-std=c++11"
 
 inherit autotools pkgconfig
 
+# After several fix attempts there is still a race between generating
+# t.test-full.pb.h and compiling cxx_generate_packed_data.c despite
+# BUILT_SOURCES and explicit dependencies.
+PARALLEL_MAKE = ""
+
 PACKAGE_BEFORE_PN = "${PN}-compiler"
 
 FILES_${PN}-compiler = "${bindir}"
-- 
2.17.1


  parent reply	other threads:[~2020-07-01  0:07 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  0:06 [dunfel 00/32] Patch review akuster
2020-07-01  0:06 ` [dunfel 01/32] zchunk: upgrade 1.1.5 -> 1.1.6 akuster
2020-07-01  0:06 ` [dunfel 02/32] uriparser: upgrade 0.9.3 -> 0.9.4 akuster
2020-07-01  0:06 ` [dunfel 03/32] jsoncpp: upgrade 1.9.2 -> 1.9.3 akuster
2020-07-09 15:21   ` [oe] " Martin Jansa
2020-07-09 16:06     ` akuster
2020-07-09 16:48       ` Martin Jansa
2020-07-10  1:08         ` Khem Raj
2020-07-10  7:37           ` Mikko Rapeli
2020-07-12 18:41             ` akuster
2020-07-13  8:25               ` Mikko Rapeli
2020-07-13 15:46                 ` Khem Raj
2020-07-15  3:52                   ` akuster
2020-07-10 15:55           ` akuster
2020-07-10 16:18             ` Khem Raj
2020-07-01  0:06 ` [dunfel 04/32] proj: upgrade 7.0.0 -> 7.0.1 akuster
2020-07-01  0:06 ` [dunfel 05/32] netkit-rsh: properly append PACKAGECONFIG akuster
2020-07-01  0:06 ` [dunfel 06/32] zile: " akuster
2020-07-01  0:06 ` [dunfel 07/32] postgresql: 12.2 -> 12.3 akuster
2020-07-01  0:06 ` [dunfel 08/32] multipath-tools: Fix build with json-c 0.14 and newer akuster
2020-07-01  8:48   ` [oe] " Adrian Bunk
2020-07-01 16:56     ` akuster
2020-07-01  0:06 ` [dunfel 09/32] libblockdev: upgrade 2.23 -> 2.24 akuster
2020-07-01  0:06 ` [dunfel 10/32] libvpx: upgrade 1.8.1 -> 1.8.2 akuster
2020-07-01  0:06 ` [dunfel 11/32] vlc: Fix build with qt5 in PACKAGECONFIG and Qt >= 5.15 / renumber patches akuster
2020-07-01  0:28   ` [oe] " Martin Jansa
2020-07-01  2:07     ` akuster
2020-07-01  0:06 ` [dunfel 12/32] jpnevulator: upgrade 2.3.4 -> 2.3.5 akuster
2020-07-01  0:06 ` [dunfel 13/32] libnftnl: upgrade 1.1.6 -> 1.1.7 akuster
2020-07-01  0:06 ` [dunfel 14/32] nftables: upgrade 0.9.4 -> 0.9.5 akuster
2020-07-01  0:07 ` [dunfel 15/32] haveged: upgrade 1.9.8 -> 1.9.9 akuster
2020-07-01  0:07 ` [dunfel 16/32] mm-common: upgrade 1.0..0 -> 1.0.1 akuster
2020-07-01  0:07 ` [dunfel 17/32] python-django: add RDEPENDS akuster
2020-07-01  0:07 ` [dunfel 18/32] python-m2crypto: Add RDEPENDS akuster
2020-07-01  0:07 ` [dunfel 19/32] python-django: set CVE_PRODUCT to be django akuster
2020-07-01  0:07 ` [dunfel 20/32] python3-m2crypto: add the missing rdepends akuster
2020-07-01  0:07 ` [dunfel 21/32] zstd: Upgrade 1.4.4 -> 1.4.5 akuster
2020-07-01  0:07 ` [dunfel 22/32] rsnapshot: upgrade 1.4.2 -> 1.4.3 akuster
2020-07-01  0:07 ` [dunfel 23/32] fuse3: upgrade 3.9.1 -> 3.9.2 akuster
2020-07-01  0:07 ` akuster [this message]
2020-07-01  0:07 ` [dunfel 25/32] openipmi: upgrade 2.0.28 -> 2.0.29 akuster
2020-07-01  0:07 ` [dunfel 26/32] twm: upgrade 1.0.10 -> 1.0.11 akuster
2020-07-01  0:07 ` [dunfel 27/32] libtalloc: fix upstream url akuster
2020-07-01  0:07 ` [dunfel 28/32] linuxptp: Fix segmentation fault on 32 bit platforms with 64 bit time_t akuster
2020-07-01  0:07 ` [dunfel 29/32] openh264: upgrade 2.1.0 -> 2.1.1 akuster
2020-07-01  0:07 ` [dunfel 30/32] tcpreplay: upgrade 4.3.2 -> 4.3.3 akuster
2020-07-01  0:07 ` [dunfel 31/32] python3-sqlalchemy: Upgrade 1.3.12 -> 1.3.17 akuster
2020-07-01  0:07 ` [dunfel 32/32] ntp: update 4.2.8p15 akuster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6aff1ae4be6ef8d40d2e3232597ab994538a2a3.1593561840.git.akuster808@gmail.com \
    --to=akuster808@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.