From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CDE6C43603 for ; Wed, 11 Dec 2019 18:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02A65206C3 for ; Wed, 11 Dec 2019 18:16:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TfUavIKv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730189AbfLKSQw (ORCPT ); Wed, 11 Dec 2019 13:16:52 -0500 Received: from mail-yb1-f196.google.com ([209.85.219.196]:38751 "EHLO mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729797AbfLKSPR (ORCPT ); Wed, 11 Dec 2019 13:15:17 -0500 Received: by mail-yb1-f196.google.com with SMTP id l129so9394094ybf.5; Wed, 11 Dec 2019 10:15:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d13RLX6NhyAv5ZdFefjfKBGNP9hWY+i8u20CJzTC+ac=; b=TfUavIKv9uEq7wg4iS9gbh0Jx4VTX8vw7590D9U3L/bJblXqToqS+gM0nQJenfkwwf J2qowTuuhNz7s1dDFWqOc4okguAuLh7D0y6sj5RkdydhdeAyNtHuv4z3jNUFL//vwAAl DbCRxN2us9teEcCyPEcl3YMnkYYdnlurYPcghdf3Qghy49cdIHa2AmH/UNKvQ558hQEI MhHWHrTgpUAGIX7FFALKsP9zE28NUn3kWjNmQvRHvSbRh71v4el+egZB4xvHWbO193wf T3TOxVavcWjWgX+6IHzjgc3LnPKS6VRFpnjZZJNDB0TVHFm3GdvQddiTp/StY3FBg4Py 4kvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d13RLX6NhyAv5ZdFefjfKBGNP9hWY+i8u20CJzTC+ac=; b=UP0sBOn+GyU06aGwPyjETAPYQGCE7+mw7a7Z98kawp2oL7mQT1Gy7kkuJ7DV8FTKTH cnuG8vdMKdF39KhHaJGmpHUK12g7FYLNmh8grF7+FFfpXokGxVMiZbWnL2PkZgs/qTAe Lq8rHsD0YdTQ0omI3vNF9ZYx4QRf+3QZWv/E8V5sv8IbMHW3u4WEpdXp6BVTj/bieDGw O9iBHbCMygO/8pLQLQ1iEeSKYlEPTy55eU+8Ro4zALwVbOljfxx1M+aehGZ7G3Dt/8iF cjv/JjEa5FvUjx8qOcVxklp/SJRdXof5lpOK6noL4j15jq1D7T0BY79U9BFLZ0ax9Znc ouDw== X-Gm-Message-State: APjAAAUojgq9v056S53tyFVxRkYFSMP1DC5DyHEPyjcsTx0ihvmd+yme DyUQqxyya7xBQShunICsWyepqQV1uML6qA== X-Google-Smtp-Source: APXvYqx0PyEq0X95gP3rmHgsA/8bcB8XqHkjAz3WmSh1MSMIo6lwgD82jrxWNNN1M/6fp2nXGr+LQQ== X-Received: by 2002:a25:aa05:: with SMTP id s5mr926645ybi.513.1576088116289; Wed, 11 Dec 2019 10:15:16 -0800 (PST) Received: from karen ([2604:2d80:d68a:cf00:a4bc:8e08:1748:387f]) by smtp.gmail.com with ESMTPSA id 207sm1260876ywq.100.2019.12.11.10.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 10:15:15 -0800 (PST) From: Scott Schafer To: gregkh@linuxfoundation.org Cc: Scott Schafer , Manish Chopra , GR-Linux-NIC-Dev@marvell.com, netdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/23] staging: qlge: Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header Date: Wed, 11 Dec 2019 12:12:37 -0600 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header in file qlge_dbg.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 1d4de39a2a70..f8b2f105592f 100644 --- a/drivers/staging/qlge/qlge_dbg.c +++ b/drivers/staging/qlge/qlge_dbg.c @@ -737,7 +737,7 @@ int ql_core_dump(struct ql_adapter *qdev, struct ql_mpi_coredump *mpi_coredump) } /* Insert the global header */ - memset(&(mpi_coredump->mpi_global_header), 0, + memset(&mpi_coredump->mpi_global_header, 0, sizeof(struct mpi_coredump_global_header)); mpi_coredump->mpi_global_header.cookie = MPI_COREDUMP_COOKIE; mpi_coredump->mpi_global_header.header_size = @@ -1225,7 +1225,7 @@ static void ql_gen_reg_dump(struct ql_adapter *qdev, { int i, status; - memset(&(mpi_coredump->mpi_global_header), 0, + memset(&mpi_coredump->mpi_global_header, 0, sizeof(struct mpi_coredump_global_header)); mpi_coredump->mpi_global_header.cookie = MPI_COREDUMP_COOKIE; mpi_coredump->mpi_global_header.header_size = -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E18FAC43603 for ; Wed, 11 Dec 2019 18:15:43 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B8047222C4 for ; Wed, 11 Dec 2019 18:15:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TfUavIKv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B8047222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9B81186D65; Wed, 11 Dec 2019 18:15:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vfHSDcjTIsi5; Wed, 11 Dec 2019 18:15:41 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 8A4A186D4C; Wed, 11 Dec 2019 18:15:41 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 20EC71BF473 for ; Wed, 11 Dec 2019 18:15:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 066848861A for ; Wed, 11 Dec 2019 18:15:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uwNV72HFQvSj for ; Wed, 11 Dec 2019 18:15:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) by hemlock.osuosl.org (Postfix) with ESMTPS id 5A1E38860D for ; Wed, 11 Dec 2019 18:15:17 +0000 (UTC) Received: by mail-yb1-f194.google.com with SMTP id i3so9366510ybe.12 for ; Wed, 11 Dec 2019 10:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d13RLX6NhyAv5ZdFefjfKBGNP9hWY+i8u20CJzTC+ac=; b=TfUavIKv9uEq7wg4iS9gbh0Jx4VTX8vw7590D9U3L/bJblXqToqS+gM0nQJenfkwwf J2qowTuuhNz7s1dDFWqOc4okguAuLh7D0y6sj5RkdydhdeAyNtHuv4z3jNUFL//vwAAl DbCRxN2us9teEcCyPEcl3YMnkYYdnlurYPcghdf3Qghy49cdIHa2AmH/UNKvQ558hQEI MhHWHrTgpUAGIX7FFALKsP9zE28NUn3kWjNmQvRHvSbRh71v4el+egZB4xvHWbO193wf T3TOxVavcWjWgX+6IHzjgc3LnPKS6VRFpnjZZJNDB0TVHFm3GdvQddiTp/StY3FBg4Py 4kvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d13RLX6NhyAv5ZdFefjfKBGNP9hWY+i8u20CJzTC+ac=; b=rT2dyWGXaehVzaVQorU44p7M9YOFqboCVom7Ig3NmWBfcknmpsRDkfiOK/izpXW7u3 XQGZ2vnTfC9HBh79cH8F4NvRquBmSR1XpDFLxyVuY3+uUsZHTKETx41MbnOj1iT6PdDD JKwVU23H+PGX1oqCRazqnwdPQEPh/YRWv86eT5xHtFdZkN28+jWk22+zetzPFSk57gUA wcglQ9slN/MYwIUkdiPfxio++lNV1+IOCMSBzr0+OOZXY7+7mDD1pXn8J/hE27BaOAbl fY7BOQGOMyxpzLWYIOaqYNt6UQAuJTEdpLOcHLmIuhV0JuUQqIc7RGr/w3Ff+x4GccFa eY7A== X-Gm-Message-State: APjAAAV3ogPUBx4A3XtSfqI0d+AnUymU9VAQlW6SOcf1tc/pJAZz0vls RpJO1PhoaX572qFehLb79BE= X-Google-Smtp-Source: APXvYqx0PyEq0X95gP3rmHgsA/8bcB8XqHkjAz3WmSh1MSMIo6lwgD82jrxWNNN1M/6fp2nXGr+LQQ== X-Received: by 2002:a25:aa05:: with SMTP id s5mr926645ybi.513.1576088116289; Wed, 11 Dec 2019 10:15:16 -0800 (PST) Received: from karen ([2604:2d80:d68a:cf00:a4bc:8e08:1748:387f]) by smtp.gmail.com with ESMTPSA id 207sm1260876ywq.100.2019.12.11.10.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 10:15:15 -0800 (PST) From: Scott Schafer To: gregkh@linuxfoundation.org Subject: [PATCH v2 08/23] staging: qlge: Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header Date: Wed, 11 Dec 2019 12:12:37 -0600 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, GR-Linux-NIC-Dev@marvell.com, Manish Chopra , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Scott Schafer Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Fix CHECK: Unnecessary parentheses around mpi_coredump->mpi_global_header in file qlge_dbg.c Signed-off-by: Scott Schafer --- drivers/staging/qlge/qlge_dbg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 1d4de39a2a70..f8b2f105592f 100644 --- a/drivers/staging/qlge/qlge_dbg.c +++ b/drivers/staging/qlge/qlge_dbg.c @@ -737,7 +737,7 @@ int ql_core_dump(struct ql_adapter *qdev, struct ql_mpi_coredump *mpi_coredump) } /* Insert the global header */ - memset(&(mpi_coredump->mpi_global_header), 0, + memset(&mpi_coredump->mpi_global_header, 0, sizeof(struct mpi_coredump_global_header)); mpi_coredump->mpi_global_header.cookie = MPI_COREDUMP_COOKIE; mpi_coredump->mpi_global_header.header_size = @@ -1225,7 +1225,7 @@ static void ql_gen_reg_dump(struct ql_adapter *qdev, { int i, status; - memset(&(mpi_coredump->mpi_global_header), 0, + memset(&mpi_coredump->mpi_global_header, 0, sizeof(struct mpi_coredump_global_header)); mpi_coredump->mpi_global_header.cookie = MPI_COREDUMP_COOKIE; mpi_coredump->mpi_global_header.header_size = -- 2.20.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel