From: "xuqiang (M)" <xuqiang36@huawei.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"pmladek@suse.com" <pmladek@suse.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"elver@google.com" <elver@google.com>,
"mcgrof@kernel.org" <mcgrof@kernel.org>,
"tangmeng@uniontech.com" <tangmeng@uniontech.com>,
"yangtiezhu@loongson.cn" <yangtiezhu@loongson.cn>,
"john.ogness@linutronix.de" <john.ogness@linutronix.de>,
"bigeasy@linutronix.de" <bigeasy@linutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Guohanjun (Hanjun Guo)" <guohanjun@huawei.com>,
"weiyongjun (A)" <weiyongjun1@huawei.com>
Subject: Re: [PATCH -next] panic: Add register_panic_notifier and unregister_panic_notifier
Date: Mon, 1 Aug 2022 13:58:20 +0000 [thread overview]
Message-ID: <d6ba371d778842bead73e62fc04d612f@huawei.com> (raw)
In-Reply-To: 2d4fa03a-f460-d995-88e8-7f0e58e557bd@igalia.com
在 2022/8/1 20:12, Guilherme G. Piccoli 写道:
> On 01/08/2022 07:05, Xu Qiang wrote:
>> Add two methods to manipulate panic_notifier_list and export them.
>> Subsequently, panic_notifier_list is changed to static variable.
>>
>> Signed-off-by: Xu Qiang <xuqiang36@huawei.com>
> Hi Xu Qiang, first of all, thanks for your patch!
> I'd like to mention 2 things about it:
>
> (a) As-is, there's no much use for it - I mean, you're adding a helper
> but you didn't change the uses of such notifier list addition (and there
> are plenty of them). Are you intend to change it, or just use the new
> API in new calls?
After this patch comes in, I will replace all the old interfaces with
the new ones.
>
> (b) Even more important: we are working in a panic notifier refactor
> [0], and that'll add new lists. I'm still working on that, plan to
> submit (relatively) soon. Maybe worth to wait it, if this one is not urgent?
I can wait for your patch to be incorporated before submitting it.
>
> Cheers,
>
>
> Guilherme
>
>
> [0]
> https://lore.kernel.org/lkml/20220427224924.592546-1-gpiccoli@igalia.com/
>
Thanks
Xu
next prev parent reply other threads:[~2022-08-01 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 10:05 [PATCH -next] panic: Add register_panic_notifier and unregister_panic_notifier Xu Qiang
2022-08-01 12:11 ` Guilherme G. Piccoli
2022-08-01 13:58 ` xuqiang (M) [this message]
2022-08-01 14:25 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6ba371d778842bead73e62fc04d612f@huawei.com \
--to=xuqiang36@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=elver@google.com \
--cc=gpiccoli@igalia.com \
--cc=guohanjun@huawei.com \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=pmladek@suse.com \
--cc=tangmeng@uniontech.com \
--cc=weiyongjun1@huawei.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.