From: "Peter Kjellerstedt" <peter.kjellerstedt@axis.com>
To: Andrey Zhizhikin <andrey.z@gmail.com>
Cc: Bruce Ashfield <bruce.ashfield@gmail.com>,
OE Core mailing list <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] lttng-modules: Make it build when CONFIG_TRACEPOINTS is not enabled again
Date: Wed, 25 Aug 2021 12:57:31 +0000 [thread overview]
Message-ID: <d6c1a107cf6e4a018443f985d554bf1f@axis.com> (raw)
In-Reply-To: <CAHtQpK7dzG3RPMbPH_5z6-o3p5e0AuLTO+xBW_UX91jSNH7YfA@mail.gmail.com>
> -----Original Message-----
> From: Andrey Zhizhikin <andrey.z@gmail.com>
> Sent: den 25 augusti 2021 12:20
> To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> Cc: Bruce Ashfield <bruce.ashfield@gmail.com>; OE Core mailing list
> <openembedded-core@lists.openembedded.org>
> Subject: Re: [OE-core] [PATCH] lttng-modules: Make it build when
> CONFIG_TRACEPOINTS is not enabled again
>
> Hello Peter,
>
> On Wed, Aug 25, 2021 at 11:41 AM Peter Kjellerstedt
> <peter.kjellerstedt@axis.com> wrote:
> >
> > Makefile-Do-not-fail-if-CONFIG_TRACEPOINTS-is-not-en.patch was updated
> > with the 2.13.0 update (commit 5dad15af), but unfortunately it no longer
> > did what it was intended to do.
> >
> > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > ---
> > ...fail-if-CONFIG_TRACEPOINTS-is-not-en.patch | 42 +++++++++++--------
> > 1 file changed, 25 insertions(+), 17 deletions(-)
> >
> > diff --git a/meta/recipes-kernel/lttng/lttng-modules/Makefile-Do-not-
> fail-if-CONFIG_TRACEPOINTS-is-not-en.patch b/meta/recipes-
> kernel/lttng/lttng-modules/Makefile-Do-not-fail-if-CONFIG_TRACEPOINTS-is-
> not-en.patch
>
> I guess the patch you've refreshed is not a correct one...
>
> There is another patch introduced by Bruce in the commit 18bf7b0
> ("lttng-modules: update devupstream to v2.13-rc "), namely
> 0001-src-Kbuild-change-missing-CONFIG_TRACEPOINTS-to-warn.patch
>
> It make sense to refresh rather that one instead of the Makefile one,
> and have it included in the SRC_URI (see discussion in
> https://lists.openembedded.org/g/openembedded-core/topic/84950303#154888).
>
> --
> Regards,
> Andrey.
Right, I had missed that there were two patches doing the same thing
(though neither actually solved the problem after the update to 2.13.0).
I will send an updated review unifying the patches and adding my solution
to disable building the module when CONFIG_TRACEPOINTS is not enabled.
//Peter
next prev parent reply other threads:[~2021-08-25 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 9:41 [PATCH] lttng-modules: Make it build when CONFIG_TRACEPOINTS is not enabled again Peter Kjellerstedt
2021-08-25 10:19 ` [OE-core] " Andrey Zhizhikin
2021-08-25 12:57 ` Peter Kjellerstedt [this message]
2021-08-25 13:17 ` Bruce Ashfield
2021-08-25 13:40 ` Peter Kjellerstedt
2021-08-25 13:47 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6c1a107cf6e4a018443f985d554bf1f@axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=andrey.z@gmail.com \
--cc=bruce.ashfield@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.