All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karthikeyan periyasamy <periyasa@codeaurora.org>
To: Peter Oh <peter.oh@eero.com>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath11k: Update tx descriptor search index properly
Date: Wed, 27 Jan 2021 08:16:32 +0530	[thread overview]
Message-ID: <d6cbfd2aff787faa3be69252b2677df9@codeaurora.org> (raw)
In-Reply-To: <959ea12a-e35b-5867-c55e-7f62e2956b09@eero.com>

On 2020-12-19 00:53, Peter Oh wrote:
> On 12/18/20 7:24 AM, Karthikeyan Periyasamy wrote:
>> Tx descriptor search index field should be updated with hw peer id
>> and not by AST Hash. Incorrect search index causes throughput 
>> degradation
>> in all the platforms. so updated the search index field with hw peer 
>> id,
>> which is a common change applicable for all the platforms.
>> 
>> Tested-on: IPQ8074 hw2.0 AHB 
>> WLAN.HK.2.4.0.1-01492-QCAHKSWPL_SILICONZ-1
>> 
>> diff --git a/drivers/net/wireless/ath/ath11k/peer.c 
>> b/drivers/net/wireless/ath/ath11k/peer.c
>> index b69e7eb..f49abefa 100644
>> --- a/drivers/net/wireless/ath/ath11k/peer.c
>> +++ b/drivers/net/wireless/ath/ath11k/peer.c
>> 
>> @@ -309,7 +310,11 @@ int ath11k_peer_create(struct ath11k *ar, struct 
>> ath11k_vif *arvif,
>>     	peer->pdev_idx = ar->pdev_idx;
>>   	peer->sta = sta;
>> -	arvif->ast_hash = peer->ast_hash;
>> +
>> +	if (arvif->vif->type == NL80211_IFTYPE_STATION) {
>> +		arvif->ast_hash = peer->ast_hash;
>> +		arvif->ast_idx = peer->hw_peer_id;
>> +	}
> 
> How about non STATION type?
> 

no need of configuring the ast_idx, ast_hash field for non station type. 
Its recommended by HW/FW team.

Thanks,
Karthikeyan P

WARNING: multiple messages have this Message-ID (diff)
From: Karthikeyan periyasamy <periyasa@codeaurora.org>
To: Peter Oh <peter.oh@eero.com>
Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCH] ath11k: Update tx descriptor search index properly
Date: Wed, 27 Jan 2021 08:16:32 +0530	[thread overview]
Message-ID: <d6cbfd2aff787faa3be69252b2677df9@codeaurora.org> (raw)
In-Reply-To: <959ea12a-e35b-5867-c55e-7f62e2956b09@eero.com>

On 2020-12-19 00:53, Peter Oh wrote:
> On 12/18/20 7:24 AM, Karthikeyan Periyasamy wrote:
>> Tx descriptor search index field should be updated with hw peer id
>> and not by AST Hash. Incorrect search index causes throughput 
>> degradation
>> in all the platforms. so updated the search index field with hw peer 
>> id,
>> which is a common change applicable for all the platforms.
>> 
>> Tested-on: IPQ8074 hw2.0 AHB 
>> WLAN.HK.2.4.0.1-01492-QCAHKSWPL_SILICONZ-1
>> 
>> diff --git a/drivers/net/wireless/ath/ath11k/peer.c 
>> b/drivers/net/wireless/ath/ath11k/peer.c
>> index b69e7eb..f49abefa 100644
>> --- a/drivers/net/wireless/ath/ath11k/peer.c
>> +++ b/drivers/net/wireless/ath/ath11k/peer.c
>> 
>> @@ -309,7 +310,11 @@ int ath11k_peer_create(struct ath11k *ar, struct 
>> ath11k_vif *arvif,
>>     	peer->pdev_idx = ar->pdev_idx;
>>   	peer->sta = sta;
>> -	arvif->ast_hash = peer->ast_hash;
>> +
>> +	if (arvif->vif->type == NL80211_IFTYPE_STATION) {
>> +		arvif->ast_hash = peer->ast_hash;
>> +		arvif->ast_idx = peer->hw_peer_id;
>> +	}
> 
> How about non STATION type?
> 

no need of configuring the ast_idx, ast_hash field for non station type. 
Its recommended by HW/FW team.

Thanks,
Karthikeyan P

-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2021-01-27  4:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-18 15:24 [PATCH] ath11k: Update tx descriptor search index properly Karthikeyan Periyasamy
2020-12-18 15:24 ` Karthikeyan Periyasamy
2020-12-18 19:23 ` Peter Oh
2020-12-18 19:23   ` Peter Oh
2021-01-27  2:46   ` Karthikeyan periyasamy [this message]
2021-01-27  2:46     ` Karthikeyan periyasamy
2021-02-03 19:29     ` Peter Oh
2021-02-03 19:29       ` Peter Oh
2021-02-04  1:08       ` Karthikeyan periyasamy
2021-02-04  1:08         ` Karthikeyan periyasamy
2021-02-04  3:08         ` Peter Oh
2021-02-04  3:08           ` Peter Oh
2021-02-04  3:17           ` Karthikeyan periyasamy
2021-02-04  3:17             ` Karthikeyan periyasamy
2021-02-04  3:37             ` Peter Oh
2021-02-04  3:37               ` Peter Oh
2021-02-04  3:40               ` Karthikeyan periyasamy
2021-02-04  3:40                 ` Karthikeyan periyasamy
2020-12-18 19:41 ` Peter Oh
2020-12-18 19:41   ` Peter Oh
2021-01-26 15:59 ` Kalle Valo
2021-01-26 15:59 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6cbfd2aff787faa3be69252b2677df9@codeaurora.org \
    --to=periyasa@codeaurora.org \
    --cc=ath11k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=peter.oh@eero.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.