All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hanna Reitz <hreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	berrange@redhat.com, qemu-block@nongnu.org
Subject: Re: [PATCH] qemu-img: Add -F shorthand to convert
Date: Wed, 15 Sep 2021 13:19:01 +0200	[thread overview]
Message-ID: <d6cc5017-319c-5349-5bf1-677580d590f9@redhat.com> (raw)
In-Reply-To: <20210913131735.1948339-1-eblake@redhat.com>

On 13.09.21 15:17, Eric Blake wrote:
> Although we have long supported 'qemu-img convert -o
> backing_file=foo,backing_fmt=bar', the fact that we have a shortcut -B
> for backing_file but none for backing_fmt has made it more likely that
> users accidentally run into:
>
> qemu-img: warning: Deprecated use of backing file without explicit backing format
>
> when using -B instead of -o.  For similarity with other qemu-img
> commands, such as create and compare, add '-F $fmt' as the shorthand
> for '-o backing_fmt=$fmt'.  Update iotest 122 for coverage of both
> spellings.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> This stemmed from an IRC conversation; I'd add a Reported-by: line if
> I can figure out how to credit more than just the nick bparker_.

Thanks, applied to my block branch:

https://gitlab.com/hreitz/qemu/-/commits/block/

Hanna



  parent reply	other threads:[~2021-09-15 11:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 13:17 [PATCH] qemu-img: Add -F shorthand to convert Eric Blake
2021-09-15  8:20 ` Vladimir Sementsov-Ogievskiy
2021-09-15  8:33 ` Maxim Levitsky
2021-09-15 11:19 ` Hanna Reitz [this message]
2021-09-17 20:13 ` Eric Blake
2021-09-17 23:36   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6cc5017-319c-5349-5bf1-677580d590f9@redhat.com \
    --to=hreitz@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.