From: Heiner Kallweit <hkallweit1@gmail.com>
To: Realtek linux nic maintainers <nic_swsd@realtek.com>,
David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: [PATCH net-next 2/4] r8169: change wmb to dma_wmb in rtl8169_start_xmit
Date: Sun, 19 Apr 2020 19:41:20 +0200 [thread overview]
Message-ID: <d6d705a9-ebe7-5ed5-ec08-840500739c2c@gmail.com> (raw)
In-Reply-To: <c1df4a9e-6be8-d529-7eb0-ea5bdf2b77ec@gmail.com>
It's the typical dma_wmb() use case to finish descriptor writes before
ringing the device doorbell. Therefore switch to this lighter barrier.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index dd6113fd7..038cd6fde 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -4259,7 +4259,7 @@ static netdev_tx_t rtl8169_start_xmit(struct sk_buff *skb,
txd_first->opts1 |= cpu_to_le32(DescOwn | FirstFrag);
/* Force all memory writes to complete before notifying device */
- wmb();
+ dma_wmb();
tp->cur_tx += frags + 1;
--
2.26.1
next prev parent reply other threads:[~2020-04-19 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 17:38 [PATCH net-next 0/4] r8169: improve memory barriers Heiner Kallweit
2020-04-19 17:39 ` [PATCH net-next 1/4] r8169: use smp_store_mb in rtl_tx Heiner Kallweit
2020-04-19 17:41 ` Heiner Kallweit [this message]
2020-04-19 17:42 ` [PATCH net-next 3/4] r8169: replace dma_rmb with READ_ONCE in rtl_rx Heiner Kallweit
2020-04-19 17:44 ` [PATCH net-next 4/4] r8169: use WRITE_ONCE instead of dma_wmb in rtl8169_mark_to_asic Heiner Kallweit
2020-04-19 18:11 ` [PATCH net-next 0/4] r8169: improve memory barriers Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6d705a9-ebe7-5ed5-ec08-840500739c2c@gmail.com \
--to=hkallweit1@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.