From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ale.deltatee.com (ale.deltatee.com [207.54.116.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 17E4D219392F1 for ; Tue, 4 Apr 2017 10:25:43 -0700 (PDT) References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> From: Logan Gunthorpe Message-ID: Date: Tue, 4 Apr 2017 11:25:41 -0600 MIME-Version: 1.0 In-Reply-To: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Subject: Re: [RFC 4/8] p2pmem: Add debugfs "stats" file List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Sagi Grimberg , Christoph Hellwig , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe Cc: linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org List-ID: On 04/04/17 04:46 AM, Sagi Grimberg wrote: > >> + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); >> + if (!p2pmem_debugfs_root) >> + pr_info("could not create debugfs entry, continuing\n"); >> + > > Why continue? I think it'd be better to just fail it. Yup, agreed. This should probably also be PTR_ERR as well. > Besides, this can be safely squashed into patch 1. Sure, the only real reason I kept it separate was it was authored by Steve Wise. Logan _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Logan Gunthorpe Subject: Re: [RFC 4/8] p2pmem: Add debugfs "stats" file Date: Tue, 4 Apr 2017 11:25:41 -0600 Message-ID: References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <95928b70-0148-7297-8f5e-5031d996bb98-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Sagi Grimberg , Christoph Hellwig , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe Cc: linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 04/04/17 04:46 AM, Sagi Grimberg wrote: > >> + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); >> + if (!p2pmem_debugfs_root) >> + pr_info("could not create debugfs entry, continuing\n"); >> + > > Why continue? I think it'd be better to just fail it. Yup, agreed. This should probably also be PTR_ERR as well. > Besides, this can be safely squashed into patch 1. Sure, the only real reason I kept it separate was it was authored by Steve Wise. Logan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755257AbdDDRZt (ORCPT ); Tue, 4 Apr 2017 13:25:49 -0400 Received: from ale.deltatee.com ([207.54.116.67]:59665 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755165AbdDDRZo (ORCPT ); Tue, 4 Apr 2017 13:25:44 -0400 To: Sagi Grimberg , Christoph Hellwig , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Cc: linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org From: Logan Gunthorpe Message-ID: Date: Tue, 4 Apr 2017 11:25:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-rdma@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org, jgunthorpe@obsidianresearch.com, keith.busch@intel.com, dan.j.williams@intel.com, maxg@mellanox.com, sbates@raithlin.com, swise@opengridcomputing.com, axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.vnet.ibm.com, hch@lst.de, sagi@grimberg.me X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [RFC 4/8] p2pmem: Add debugfs "stats" file X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/17 04:46 AM, Sagi Grimberg wrote: > >> + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); >> + if (!p2pmem_debugfs_root) >> + pr_info("could not create debugfs entry, continuing\n"); >> + > > Why continue? I think it'd be better to just fail it. Yup, agreed. This should probably also be PTR_ERR as well. > Besides, this can be safely squashed into patch 1. Sure, the only real reason I kept it separate was it was authored by Steve Wise. Logan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: To: Sagi Grimberg , Christoph Hellwig , "James E.J. Bottomley" , "Martin K. Petersen" , Jens Axboe , Steve Wise , Stephen Bates , Max Gurtovoy , Dan Williams , Keith Busch , Jason Gunthorpe References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Cc: linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-rdma@vger.kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org From: Logan Gunthorpe Message-ID: Date: Tue, 4 Apr 2017 11:25:41 -0600 MIME-Version: 1.0 In-Reply-To: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Content-Type: text/plain; charset=windows-1252 Subject: Re: [RFC 4/8] p2pmem: Add debugfs "stats" file Sender: linux-kernel-owner@vger.kernel.org List-ID: On 04/04/17 04:46 AM, Sagi Grimberg wrote: > >> + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); >> + if (!p2pmem_debugfs_root) >> + pr_info("could not create debugfs entry, continuing\n"); >> + > > Why continue? I think it'd be better to just fail it. Yup, agreed. This should probably also be PTR_ERR as well. > Besides, this can be safely squashed into patch 1. Sure, the only real reason I kept it separate was it was authored by Steve Wise. Logan From mboxrd@z Thu Jan 1 00:00:00 1970 From: logang@deltatee.com (Logan Gunthorpe) Date: Tue, 4 Apr 2017 11:25:41 -0600 Subject: [RFC 4/8] p2pmem: Add debugfs "stats" file In-Reply-To: <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> References: <1490911959-5146-1-git-send-email-logang@deltatee.com> <1490911959-5146-5-git-send-email-logang@deltatee.com> <95928b70-0148-7297-8f5e-5031d996bb98@grimberg.me> Message-ID: On 04/04/17 04:46 AM, Sagi Grimberg wrote: > >> + p2pmem_debugfs_root = debugfs_create_dir("p2pmem", NULL); >> + if (!p2pmem_debugfs_root) >> + pr_info("could not create debugfs entry, continuing\n"); >> + > > Why continue? I think it'd be better to just fail it. Yup, agreed. This should probably also be PTR_ERR as well. > Besides, this can be safely squashed into patch 1. Sure, the only real reason I kept it separate was it was authored by Steve Wise. Logan