From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_ADSP_DISCARD, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E472C11F64 for ; Thu, 1 Jul 2021 14:18:40 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 8567561400 for ; Thu, 1 Jul 2021 14:18:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8567561400 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=oktetlabs.ru Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B784640141; Thu, 1 Jul 2021 16:18:38 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 8CBB64003E for ; Thu, 1 Jul 2021 16:18:37 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3CAF07F57E; Thu, 1 Jul 2021 17:18:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3CAF07F57E DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1625149117; bh=80hHDSBBosLmeM2hrB30Y/hS1A6cV/lecbdBFAD581c=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=xcN96tXofVOck38kN0uS34nDLwmhgUPGgAjtdiwm6l+lnKq0pGWejOJcXfvXDxHIN MWSp0tCDocwg+M0qKJaRPXUNX4Rk8fUXlW5jzDn410DyEI7fiyYEPYhcOBesiQzjii 0cX/bVC72yvDhYzJhNSfZjSjJiv9wnjZvHqzJx7Q= To: Stephen Hemminger , Keith Wiles Cc: dev@dpdk.org References: <20210616041528.4229-1-stephen@networkplumber.org> <20210616041528.4229-3-stephen@networkplumber.org> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Thu, 1 Jul 2021 17:18:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210616041528.4229-3-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/tap: replace offload_capa function with define X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/16/21 7:15 AM, Stephen Hemminger wrote: > Since the offload values are always the same, these can > just be data instead of code. > > Signed-off-by: Stephen Hemminger No strong opinion as well, but above reason is not strong enough to touch the code. So, I'll wait for the maintainer here as well.