From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: i@maskray.me, berrange@redhat.com
Subject: Re: [PATCH v2 5/7] configure: Unnest detection of -z, relro and -z, now
Date: Wed, 18 Dec 2019 23:46:28 +0100 [thread overview]
Message-ID: <d6e9a554-cd86-fbe0-deea-2e7c4ad38ac2@redhat.com> (raw)
In-Reply-To: <20191218223441.23852-6-richard.henderson@linaro.org>
On 12/18/19 11:34 PM, Richard Henderson wrote:
> There is nothing about these options that is related to PIE.
> Use them unconditionally.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> v2: Do not split into two tests.
> ---
> configure | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 7a646ec007..2503288654 100755
> --- a/configure
> +++ b/configure
> @@ -2040,9 +2040,6 @@ if test "$pie" != "no" ; then
> QEMU_CFLAGS="-fPIE -DPIE $QEMU_CFLAGS"
> LDFLAGS="-pie $LDFLAGS"
> pie="yes"
> - if compile_prog "" "-Wl,-z,relro -Wl,-z,now" ; then
> - LDFLAGS="-Wl,-z,relro -Wl,-z,now $LDFLAGS"
> - fi
> else
> if test "$pie" = "yes"; then
> error_exit "PIE not available due to missing toolchain support"
> @@ -2053,6 +2050,12 @@ if test "$pie" != "no" ; then
> fi
> fi
>
> +# Detect support for PT_GNU_RELRO + DT_BIND_NOW.
> +# The combination is known as "full relro", because .got is read-only too.
> +if compile_prog "" "-Wl,-z,relro -Wl,-z,now" ; then
> + LDFLAGS="-Wl,-z,relro -Wl,-z,now $LDFLAGS"
> +fi
> +
> ##########################################
> # __sync_fetch_and_and requires at least -march=i486. Many toolchains
> # use i686 as default anyway, but for those that don't, an explicit
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-12-18 22:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 22:34 [PATCH v2 0/7] configure: Improve PIE and other linkage Richard Henderson
2019-12-18 22:34 ` [PATCH v2 1/7] configure: Drop adjustment of textseg Richard Henderson
2020-01-07 11:34 ` Alex Bennée
2019-12-18 22:34 ` [PATCH v2 2/7] tcg: Remove softmmu code_gen_buffer fixed address Richard Henderson
2020-01-07 11:35 ` Alex Bennée
2019-12-18 22:34 ` [PATCH v2 3/7] configure: Do not force pie=no for non-x86 Richard Henderson
2020-01-07 11:37 ` Philippe Mathieu-Daudé
2020-01-07 12:58 ` Alex Bennée
2019-12-18 22:34 ` [PATCH v2 4/7] configure: Always detect -no-pie toolchain support Richard Henderson
2020-01-07 13:16 ` Alex Bennée
2020-01-08 0:45 ` Richard Henderson
2019-12-18 22:34 ` [PATCH v2 5/7] configure: Unnest detection of -z,relro and -z,now Richard Henderson
2019-12-18 22:46 ` Philippe Mathieu-Daudé [this message]
2019-12-19 7:11 ` [PATCH v2 5/7] configure: Unnest detection of -z, relro and -z, now Fangrui Song
2020-01-07 13:18 ` Alex Bennée
2019-12-18 22:34 ` [PATCH v2 6/7] configure: Override the os default with --disable-pie Richard Henderson
2020-01-07 13:24 ` Alex Bennée
2019-12-18 22:34 ` [PATCH v2 7/7] configure: Support -static-pie if requested Richard Henderson
2020-01-07 13:45 ` Alex Bennée
2020-01-06 2:57 ` [PATCH v2 0/7] configure: Improve PIE and other linkage Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6e9a554-cd86-fbe0-deea-2e7c4ad38ac2@redhat.com \
--to=philmd@redhat.com \
--cc=berrange@redhat.com \
--cc=i@maskray.me \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.