From: Joe Perches <joe@perches.com>
To: yhchuang@realtek.com, kvalo@codeaurora.org, sgruszka@redhat.com
Cc: Larry.Finger@lwfinger.net, linux-wireless@vger.kernel.org,
pkshih@realtek.com, tehuang@realtek.com,
johannes@sipsolutions.net
Subject: Re: [RFC v5 08/13] rtw88: debug files
Date: Sat, 03 Nov 2018 21:28:49 -0700 [thread overview]
Message-ID: <d6f81b74ede58f9a7cd3ce01cd8366d5df50d1de.camel@perches.com> (raw)
In-Reply-To: <1540980747-9297-9-git-send-email-yhchuang@realtek.com>
On Wed, 2018-10-31 at 18:12 +0800, yhchuang@realtek.com wrote
> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
> debug files for Realtek 802.11ac wireless network chips
[]
> diff --git a/drivers/net/wireless/realtek/rtw88/debug.h b/drivers/net/wireless/realtek/rtw88/debug.h
[]
> +#ifdef CONFIG_RTW88_DEBUG
[]
> +#else
> +
> +static inline void rtw_dbg(struct rtw_dev *rtwdev, const char *fmt, ...) {}
> +static inline void rtw_info(struct rtw_dev *rtwdev, const char *fmt, ...) {}
> +static inline void rtw_warn(struct rtw_dev *rtwdev, const char *fmt, ...) {}
> +static inline void rtw_err(struct rtw_dev *rtwdev, const char *fmt, ...) {}
I still think it's _very, very bad_, and extremely
unusual to turn off _all_ logging, even for error
conditions, based on a debug config flag.
next prev parent reply other threads:[~2018-11-04 4:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 10:12 [RFC v5 00/13] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips yhchuang
2018-10-31 10:12 ` [RFC v5 01/13] rtw88: main files yhchuang
2018-10-31 10:12 ` [RFC v5 02/13] rtw88: core files yhchuang
2018-10-31 10:12 ` [RFC v5 03/13] rtw88: hci files yhchuang
2018-10-31 10:12 ` [RFC v5 04/13] rtw88: trx files yhchuang
2018-10-31 10:12 ` [RFC v5 05/13] rtw88: mac files yhchuang
2018-10-31 10:12 ` [RFC v5 06/13] rtw88: fw and efuse files yhchuang
2018-10-31 10:12 ` [RFC v5 07/13] rtw88: phy files yhchuang
2018-10-31 10:12 ` [RFC v5 08/13] rtw88: debug files yhchuang
2018-11-04 4:28 ` Joe Perches [this message]
2018-11-05 6:13 ` Tony Chuang
2018-11-05 7:11 ` Joe Perches
2018-10-31 10:12 ` [RFC v5 09/13] rtw88: chip files yhchuang
2018-10-31 10:12 ` [RFC v5 10/13] rtw88: 8822B init table yhchuang
2018-10-31 10:12 ` [RFC v5 11/13] rtw88: 8822C " yhchuang
2018-10-31 10:12 ` [RFC v5 12/13] rtw88: Kconfig & Makefile yhchuang
2018-10-31 10:12 ` [RFC v5 13/13] rtw88: add support for Realtek 802.11ac wireless chips yhchuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f81b74ede58f9a7cd3ce01cd8366d5df50d1de.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=sgruszka@redhat.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.