From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7210C433DB for ; Fri, 19 Feb 2021 15:43:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91A9F64DFD for ; Fri, 19 Feb 2021 15:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbhBSPnH (ORCPT ); Fri, 19 Feb 2021 10:43:07 -0500 Received: from marcansoft.com ([212.63.210.85]:44616 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbhBSPlt (ORCPT ); Fri, 19 Feb 2021 10:41:49 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 80DC5419B4; Fri, 19 Feb 2021 15:41:03 +0000 (UTC) To: Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: catalin.marinas@arm.com, james.morse@arm.com, maz@kernel.org, tglx@linutronix.de, will@kernel.org, Arnd Bergmann References: <20210219113904.41736-1-mark.rutland@arm.com> From: Hector Martin Subject: Re: [PATCH 0/8] arm64: Support FIQ controller registration Message-ID: Date: Sat, 20 Feb 2021 00:41:01 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210219113904.41736-1-mark.rutland@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: es-ES Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Thanks for tackling this side of the problem! On 19/02/2021 20.38, Mark Rutland wrote: > The only functional difference here is that if an IRQ > is somehow taken prior to set_handle_irq() the default handler will directly > panic() rather than the vector branching to NULL. That sounds like the right thing to do, certainly. > The penultimate patch is cherry-picked from the v2 M1 series, and as per > discussion there [3] will need a few additional fixups. I've included it for > now as the DAIF.IF alignment is necessary for the FIQ exception handling added > in the final patch. > The final patch adds the low-level FIQ exception handling and registration > mechanism atop the prior rework. > > I'm hoping that we can somehow queue the first 6 patches of this series as a > base for the M1 support. With that we can either cherry-pick a later version of > the DAIF.IF patch here, or the M1 support series can take the FIQ handling > patch. I've pushed the series out to my arm64/fiq branch [4] on kernel.org, > atop v5.11. Looks good! I cherry picked my updated version of the DAIF.IF patch into your series at [1] (3322522d), and then rebased the M1 series on top of it (with the change to use set_handle_fiq(), minus all the other obsoleted FIQ stuff) at [2]. It all boots and works as expected. I think it makes sense for you to take the DAIF.IF patch, as it goes along with this series. Then we can base the M1 series off of it. If you think that works, I can send it off as a one-off reply to the version in this series and we can review it here if you want, or otherwise feel free to cherry-pick it into a v2 (CC as appropriate). If this all makes sense, the v3 of the M1 series will then be based off of this patchset as in [2], and I'll link to your tree in the cover letter so others know where to apply it. Arnd (CCed) is going to be merging that one via the SoC tree, so as long as we coordinate a stable base once everything is reviewed and ready to merge, I believe it should all work out fine on the way up. Just for completeness, the current DAIF.IF patch in the context of the original series is at [3] (4dd6330f), in case that's useful to someone for some reason (since there were conflicts due to the refactoring happening before it, it changed a bit). [1] https://github.com/AsahiLinux/linux/tree/fiq [2] https://github.com/AsahiLinux/linux/tree/upstream-bringup-v3 [3] https://github.com/AsahiLinux/linux/tree/upstream-bringup-v2.5 -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B4F4C433DB for ; Fri, 19 Feb 2021 15:43:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A32164E60 for ; Fri, 19 Feb 2021 15:43:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A32164E60 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marcan.st Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I0/b6gv+Dr9riLwnu+AARPpBh3v3uDbxcUEAVJmGwU8=; b=AdyqdGTaDUo2/Ablh+EGjRBoS S+vR13h8g0vsPcWbR51wA+Ze+ExbZQ+eidVKqDZYFxGnGKBXwOpHbc2q5Y5oIhwEXLKOOmNPdEMpv +vzWC5bCS+vJ3HA4akivEItoaojijr+V+9X5zxxDgxNOZ8nT2qaxWINTaWHflRyrani/18yOz1b96 ByuoCzAbIoPhKbJWJgLLrZBJ4WWq0UMeihRr3ulUmfUp1kIXqMC6nyfYNZQXVVspv3OX40HW5CBzo Uc4p2r9yDORUITjkjZ+jetzg7tP8DpWIh/exOkeM+KirEc8U4xQvU5jL/F+eWUlcT6hjKfeSysOWy 3WYWzBa0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lD7u9-0006GA-Ox; Fri, 19 Feb 2021 15:41:17 +0000 Received: from marcansoft.com ([212.63.210.85] helo=mail.marcansoft.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lD7u5-0006Fe-Tl for linux-arm-kernel@lists.infradead.org; Fri, 19 Feb 2021 15:41:15 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 80DC5419B4; Fri, 19 Feb 2021 15:41:03 +0000 (UTC) To: Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210219113904.41736-1-mark.rutland@arm.com> From: Hector Martin Subject: Re: [PATCH 0/8] arm64: Support FIQ controller registration Message-ID: Date: Sat, 20 Feb 2021 00:41:01 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210219113904.41736-1-mark.rutland@arm.com> Content-Language: es-ES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210219_104114_082407_0BADD552 X-CRM114-Status: GOOD ( 21.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , catalin.marinas@arm.com, james.morse@arm.com, maz@kernel.org, tglx@linutronix.de, will@kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mark, Thanks for tackling this side of the problem! On 19/02/2021 20.38, Mark Rutland wrote: > The only functional difference here is that if an IRQ > is somehow taken prior to set_handle_irq() the default handler will directly > panic() rather than the vector branching to NULL. That sounds like the right thing to do, certainly. > The penultimate patch is cherry-picked from the v2 M1 series, and as per > discussion there [3] will need a few additional fixups. I've included it for > now as the DAIF.IF alignment is necessary for the FIQ exception handling added > in the final patch. > The final patch adds the low-level FIQ exception handling and registration > mechanism atop the prior rework. > > I'm hoping that we can somehow queue the first 6 patches of this series as a > base for the M1 support. With that we can either cherry-pick a later version of > the DAIF.IF patch here, or the M1 support series can take the FIQ handling > patch. I've pushed the series out to my arm64/fiq branch [4] on kernel.org, > atop v5.11. Looks good! I cherry picked my updated version of the DAIF.IF patch into your series at [1] (3322522d), and then rebased the M1 series on top of it (with the change to use set_handle_fiq(), minus all the other obsoleted FIQ stuff) at [2]. It all boots and works as expected. I think it makes sense for you to take the DAIF.IF patch, as it goes along with this series. Then we can base the M1 series off of it. If you think that works, I can send it off as a one-off reply to the version in this series and we can review it here if you want, or otherwise feel free to cherry-pick it into a v2 (CC as appropriate). If this all makes sense, the v3 of the M1 series will then be based off of this patchset as in [2], and I'll link to your tree in the cover letter so others know where to apply it. Arnd (CCed) is going to be merging that one via the SoC tree, so as long as we coordinate a stable base once everything is reviewed and ready to merge, I believe it should all work out fine on the way up. Just for completeness, the current DAIF.IF patch in the context of the original series is at [3] (4dd6330f), in case that's useful to someone for some reason (since there were conflicts due to the refactoring happening before it, it changed a bit). [1] https://github.com/AsahiLinux/linux/tree/fiq [2] https://github.com/AsahiLinux/linux/tree/upstream-bringup-v3 [3] https://github.com/AsahiLinux/linux/tree/upstream-bringup-v2.5 -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel