All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: s5p-jpeg: Make use of the helper function devm_platform_ioremap_resource()
Date: Wed, 1 Sep 2021 11:18:14 +0200	[thread overview]
Message-ID: <d734bf08-1fb0-2805-1b67-b79f3d9efe7e@gmail.com> (raw)
In-Reply-To: <20210901055609.7679-1-caihuoqing@baidu.com>

Hi Cai Huoqing,

Thank you for the patch.

W dniu 01.09.2021 o 07:56, Cai Huoqing pisze:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>

> ---
>   drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> index d402e456f27d..1faff037cdf7 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> @@ -2850,7 +2850,6 @@ static void *jpeg_get_drv_data(struct device *dev);
>   static int s5p_jpeg_probe(struct platform_device *pdev)
>   {
>   	struct s5p_jpeg *jpeg;
> -	struct resource *res;
>   	int i, ret;
>   
>   	/* JPEG IP abstraction struct */
> @@ -2867,9 +2866,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev)
>   	jpeg->dev = &pdev->dev;
>   
>   	/* memory-mapped registers */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -	jpeg->regs = devm_ioremap_resource(&pdev->dev, res);
> +	jpeg->regs = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(jpeg->regs))
>   		return PTR_ERR(jpeg->regs);
>   
> 

WARNING: multiple messages have this Message-ID (diff)
From: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: s5p-jpeg: Make use of the helper function devm_platform_ioremap_resource()
Date: Wed, 1 Sep 2021 11:18:14 +0200	[thread overview]
Message-ID: <d734bf08-1fb0-2805-1b67-b79f3d9efe7e@gmail.com> (raw)
In-Reply-To: <20210901055609.7679-1-caihuoqing@baidu.com>

Hi Cai Huoqing,

Thank you for the patch.

W dniu 01.09.2021 o 07:56, Cai Huoqing pisze:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>

> ---
>   drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> index d402e456f27d..1faff037cdf7 100644
> --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> @@ -2850,7 +2850,6 @@ static void *jpeg_get_drv_data(struct device *dev);
>   static int s5p_jpeg_probe(struct platform_device *pdev)
>   {
>   	struct s5p_jpeg *jpeg;
> -	struct resource *res;
>   	int i, ret;
>   
>   	/* JPEG IP abstraction struct */
> @@ -2867,9 +2866,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev)
>   	jpeg->dev = &pdev->dev;
>   
>   	/* memory-mapped registers */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -	jpeg->regs = devm_ioremap_resource(&pdev->dev, res);
> +	jpeg->regs = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(jpeg->regs))
>   		return PTR_ERR(jpeg->regs);
>   
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-01  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01  5:56 [PATCH] media: s5p-jpeg: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01  5:56 ` Cai Huoqing
2021-09-01  9:18 ` Andrzej Pietrasiewicz [this message]
2021-09-01  9:18   ` Andrzej Pietrasiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d734bf08-1fb0-2805-1b67-b79f3d9efe7e@gmail.com \
    --to=andrzejtp2010@gmail.com \
    --cc=caihuoqing@baidu.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.