From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35C4C4320A for ; Wed, 1 Sep 2021 09:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBF1160462 for ; Wed, 1 Sep 2021 09:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243474AbhIAJTP (ORCPT ); Wed, 1 Sep 2021 05:19:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232048AbhIAJTO (ORCPT ); Wed, 1 Sep 2021 05:19:14 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97382C061575; Wed, 1 Sep 2021 02:18:17 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id s3so3671112ljp.11; Wed, 01 Sep 2021 02:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jaONncWw3Nrc3WJwgDaEmida3dPXbcIs1+TgjP/mlxE=; b=hxJ6ov4NLwAeidP140erfLeU06cDjtlaGLMIoA9t3QPsqmUFULLsI+Av4hMsC7MJyC ITBWg1jU/D5Fs33yrtQBZWdXBbckBIinp30p32xRlnuLM9NVUyoZqAAHZh7XCFm0rc2w xvGIqh6oDmBxJ7KP6uBYjsHrQu8wsynObGTdFtODjAvzlnNGEHSjRMDjTf8IKZwCiJSv 4Yp9wzr0FCwtxfc3hM8PnzDhktb9Qp3788hGOGboSEB6ywaQHF9n1Hkq13alIXatYD5U uXV/mY7c9WSQSpsiWbMek7qUKx/Ju+POpD2QsMSORO5adVELstim455e/w5oKnT6s94H YvhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jaONncWw3Nrc3WJwgDaEmida3dPXbcIs1+TgjP/mlxE=; b=U0Ke+PVA6LmLf+pEWiZ5CHFsQbNtuuoQCvfNN1l0TvOdFPriOTYBfEBJWwucad9f6s 7FHuCWGQkznhOGYG9TA7iJeyEvN8RRNqaLnsonDXhFwH/pT2Sbg9YtfVHdcAb/fmucDP r2/filPufC6xuf+whKD7xxoyyBax1kKsHc2mgmmnTbIWY9h3MQg9Qf9RR2g4gri5YxQA f42OVUUzuG9lMtB4/HNyQBWMHxJ6iAQbaPZB5G5NnxFjcVbYdekOC8Ug5kjdEv4MTC8J lpRVcmG5bZlRQB4Y8B4/Bk9tnpVgnwyfeACEiqEnB6X5+lsyGvItvwwhtn+uWuwniMLU wXcQ== X-Gm-Message-State: AOAM5308hYWGKaptRl6qePfqN3ZGvPwRtuocTDiTlcKL5a24R7oGQqbk 3P2cqI0WtAVBAmVXvs0/UcJ/jo2w+4o= X-Google-Smtp-Source: ABdhPJz6PjLY3oQgbBKviLMMhQ0a8KqRDvngsM70mkE8G9tKYx67eWp9vpyYtiVRTJimNiYTHwYEgw== X-Received: by 2002:a05:651c:1064:: with SMTP id y4mr29612571ljm.74.1630487895951; Wed, 01 Sep 2021 02:18:15 -0700 (PDT) Received: from [192.168.0.192] ([194.146.248.73]) by smtp.gmail.com with ESMTPSA id bn3sm2689373ljb.18.2021.09.01.02.18.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 02:18:15 -0700 (PDT) Subject: Re: [PATCH] media: s5p-jpeg: Make use of the helper function devm_platform_ioremap_resource() To: Cai Huoqing Cc: Jacek Anaszewski , Sylwester Nawrocki , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210901055609.7679-1-caihuoqing@baidu.com> From: Andrzej Pietrasiewicz Message-ID: Date: Wed, 1 Sep 2021 11:18:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901055609.7679-1-caihuoqing@baidu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cai Huoqing, Thank you for the patch. W dniu 01.09.2021 o 07:56, Cai Huoqing pisze: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Acked-by: Andrzej Pietrasiewicz > --- > drivers/media/platform/s5p-jpeg/jpeg-core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c > index d402e456f27d..1faff037cdf7 100644 > --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c > +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c > @@ -2850,7 +2850,6 @@ static void *jpeg_get_drv_data(struct device *dev); > static int s5p_jpeg_probe(struct platform_device *pdev) > { > struct s5p_jpeg *jpeg; > - struct resource *res; > int i, ret; > > /* JPEG IP abstraction struct */ > @@ -2867,9 +2866,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev) > jpeg->dev = &pdev->dev; > > /* memory-mapped registers */ > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - > - jpeg->regs = devm_ioremap_resource(&pdev->dev, res); > + jpeg->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(jpeg->regs)) > return PTR_ERR(jpeg->regs); > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE2CC432BE for ; Wed, 1 Sep 2021 09:50:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59E3E600D4 for ; Wed, 1 Sep 2021 09:50:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 59E3E600D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LopQ3hCdrvArK2Zpe76c4yHa5qoczy5Zcdufr8DKVzY=; b=DaxJbNpJkhpb/5Rj6vhpbDSPrs 3J25AyUmDSTP2Ux+bNSCWl8KMUNx8lqrIOPnex7jU2Py2/1oL/3xPDg0WOZdT3hRdHLLgpvr+iu1w EXTbrESK1nBLJRKVLrnHntDvwME2Lmrgsbm4mS3bQK9Y2/J8rX1ejQ/1xSNOktEsib69+Bd4Uqc2M ATbsshPnUPWwTn+h+w9sc9Njgi+jH1bQ2EJ65NRyLDdS96B7AfeKCh5evg1zJ9N/np9RVcHesirXL AcIk6ciRuo0YC551QB49cTjiBg6DnV9meXTqUjS+9yfWZN2tgOCq6VY23VEE9ZcstSghBGwV2uKzx YfvPpwag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLMqK-004znZ-Pa; Wed, 01 Sep 2021 09:47:41 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLMNx-004pNn-0S for linux-arm-kernel@lists.infradead.org; Wed, 01 Sep 2021 09:18:22 +0000 Received: by mail-lj1-x22e.google.com with SMTP id s12so3826978ljg.0 for ; Wed, 01 Sep 2021 02:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jaONncWw3Nrc3WJwgDaEmida3dPXbcIs1+TgjP/mlxE=; b=hxJ6ov4NLwAeidP140erfLeU06cDjtlaGLMIoA9t3QPsqmUFULLsI+Av4hMsC7MJyC ITBWg1jU/D5Fs33yrtQBZWdXBbckBIinp30p32xRlnuLM9NVUyoZqAAHZh7XCFm0rc2w xvGIqh6oDmBxJ7KP6uBYjsHrQu8wsynObGTdFtODjAvzlnNGEHSjRMDjTf8IKZwCiJSv 4Yp9wzr0FCwtxfc3hM8PnzDhktb9Qp3788hGOGboSEB6ywaQHF9n1Hkq13alIXatYD5U uXV/mY7c9WSQSpsiWbMek7qUKx/Ju+POpD2QsMSORO5adVELstim455e/w5oKnT6s94H YvhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jaONncWw3Nrc3WJwgDaEmida3dPXbcIs1+TgjP/mlxE=; b=p9Nbei6wdiX4lTFxrBLuIeYl8Khg1sKjt8Gh6+qCm4F5Gp40RGD3CyGY0Iwiz8qQov j5Cl5QYnMfMZy67NUwERKLfkZ1k/qV62SdCHdnaIzPqhe6ckyCbdldEhM9cccZuRJRXf vj96WDjN4+Jnr9A5pvUYA8VaHhrLi6C6lzutUKzsZYTb/T+sjrEmLmBI3aKDv1LIMl+j 1xxYedGwTMPsNhCMJd+OJd0RP21vUQmUSPn2NPEzn+TkIgH1iCjtRPnhfb3Jb24YCDA9 Nqfb7W/tAGuuCGM9yA2EyWAYr7+uJWYYytRPl5jwc7nwzyi4VXE+J0SaAsyxyfCCQKvD ZXkw== X-Gm-Message-State: AOAM5336AkC8e47tN7oE9pjAozXBidTginBjHLDL9LuRs23g4cXKyt1A jpBujbzVZ1RSZ02PhdAs2QE= X-Google-Smtp-Source: ABdhPJz6PjLY3oQgbBKviLMMhQ0a8KqRDvngsM70mkE8G9tKYx67eWp9vpyYtiVRTJimNiYTHwYEgw== X-Received: by 2002:a05:651c:1064:: with SMTP id y4mr29612571ljm.74.1630487895951; Wed, 01 Sep 2021 02:18:15 -0700 (PDT) Received: from [192.168.0.192] ([194.146.248.73]) by smtp.gmail.com with ESMTPSA id bn3sm2689373ljb.18.2021.09.01.02.18.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 02:18:15 -0700 (PDT) Subject: Re: [PATCH] media: s5p-jpeg: Make use of the helper function devm_platform_ioremap_resource() To: Cai Huoqing Cc: Jacek Anaszewski , Sylwester Nawrocki , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210901055609.7679-1-caihuoqing@baidu.com> From: Andrzej Pietrasiewicz Message-ID: Date: Wed, 1 Sep 2021 11:18:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901055609.7679-1-caihuoqing@baidu.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210901_021821_115933_0547FBF5 X-CRM114-Status: GOOD ( 20.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQ2FpIEh1b3FpbmcsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KClcgZG5pdSAwMS4wOS4y MDIxIG/CoDA3OjU2LCBDYWkgSHVvcWluZyBwaXN6ZToKPiBVc2UgdGhlIGRldm1fcGxhdGZvcm1f aW9yZW1hcF9yZXNvdXJjZSgpIGhlbHBlciBpbnN0ZWFkIG9mCj4gY2FsbGluZyBwbGF0Zm9ybV9n ZXRfcmVzb3VyY2UoKSBhbmQgZGV2bV9pb3JlbWFwX3Jlc291cmNlKCkKPiBzZXBhcmF0ZWx5Cj4g Cj4gU2lnbmVkLW9mZi1ieTogQ2FpIEh1b3FpbmcgPGNhaWh1b3FpbmdAYmFpZHUuY29tPgoKQWNr ZWQtYnk6IEFuZHJ6ZWogUGlldHJhc2lld2ljeiA8YW5kcnplanRwMjAxMEBnbWFpbC5jb20+Cgo+ IC0tLQo+ICAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9zNXAtanBlZy9qcGVnLWNvcmUuYyB8IDUg Ky0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgNCBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9zNXAtanBlZy9qcGVnLWNv cmUuYyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vczVwLWpwZWcvanBlZy1jb3JlLmMKPiBpbmRl eCBkNDAyZTQ1NmYyN2QuLjFmYWZmMDM3Y2RmNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlh L3BsYXRmb3JtL3M1cC1qcGVnL2pwZWctY29yZS5jCj4gKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0 Zm9ybS9zNXAtanBlZy9qcGVnLWNvcmUuYwo+IEBAIC0yODUwLDcgKzI4NTAsNiBAQCBzdGF0aWMg dm9pZCAqanBlZ19nZXRfZHJ2X2RhdGEoc3RydWN0IGRldmljZSAqZGV2KTsKPiAgIHN0YXRpYyBp bnQgczVwX2pwZWdfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgIHsKPiAg IAlzdHJ1Y3QgczVwX2pwZWcgKmpwZWc7Cj4gLQlzdHJ1Y3QgcmVzb3VyY2UgKnJlczsKPiAgIAlp bnQgaSwgcmV0Owo+ICAgCj4gICAJLyogSlBFRyBJUCBhYnN0cmFjdGlvbiBzdHJ1Y3QgKi8KPiBA QCAtMjg2Nyw5ICsyODY2LDcgQEAgc3RhdGljIGludCBzNXBfanBlZ19wcm9iZShzdHJ1Y3QgcGxh dGZvcm1fZGV2aWNlICpwZGV2KQo+ICAgCWpwZWctPmRldiA9ICZwZGV2LT5kZXY7Cj4gICAKPiAg IAkvKiBtZW1vcnktbWFwcGVkIHJlZ2lzdGVycyAqLwo+IC0JcmVzID0gcGxhdGZvcm1fZ2V0X3Jl c291cmNlKHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAwKTsKPiAtCj4gLQlqcGVnLT5yZWdzID0gZGV2 bV9pb3JlbWFwX3Jlc291cmNlKCZwZGV2LT5kZXYsIHJlcyk7Cj4gKwlqcGVnLT5yZWdzID0gZGV2 bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlKHBkZXYsIDApOwo+ICAgCWlmIChJU19FUlIoanBl Zy0+cmVncykpCj4gICAJCXJldHVybiBQVFJfRVJSKGpwZWctPnJlZ3MpOwo+ICAgCj4gCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==