From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDCCC433F5 for ; Thu, 12 May 2022 06:21:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350226AbiELGVq (ORCPT ); Thu, 12 May 2022 02:21:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347424AbiELGVp (ORCPT ); Thu, 12 May 2022 02:21:45 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D0B63DA6F; Wed, 11 May 2022 23:21:44 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1D2901F8F4; Thu, 12 May 2022 06:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1652336503; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZCkAVlqK4be51Iao9TAxRWn1tf1liEtuTyxdtziUME=; b=XVG6WYWpgxTlc1QAjyFQKda84XQH/ddCehEX3+/2JdRWk2RMHw5R/LvoiiNfHc4nab89Xs kQ67oaHGn1tkUhdflhKqGWWrsmS1rMJETQ8XjYXKK0HqlXWC2SD5qzJYH8rMDFIA/EMOZl yDZ3pX4FtTJyby1LI/LQpV52fdwo6Ts= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1652336503; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VZCkAVlqK4be51Iao9TAxRWn1tf1liEtuTyxdtziUME=; b=qNpR4yLBd+2ipVw2OGK6OEjXYydiCTUrYps2c2J37BnzRoX93eYHSoUJXj4Qj1tNrNIlel y7d0feS5aOQV6GAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E430513ABE; Thu, 12 May 2022 06:21:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CY8eNHanfGKETAAAMHmgww (envelope-from ); Thu, 12 May 2022 06:21:42 +0000 Message-ID: Date: Thu, 12 May 2022 08:21:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 03/23] dt-bindings: ata: ahci-platform: Clarify common AHCI props constraints Content-Language: en-US To: Serge Semin , Damien Le Moal , Hans de Goede , Jens Axboe , Rob Herring , Krzysztof Kozlowski Cc: Serge Semin , Alexey Malahov , Pavel Parkhomenko , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220511231810.4928-1-Sergey.Semin@baikalelectronics.ru> <20220511231810.4928-4-Sergey.Semin@baikalelectronics.ru> From: Hannes Reinecke In-Reply-To: <20220511231810.4928-4-Sergey.Semin@baikalelectronics.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 5/12/22 01:17, Serge Semin wrote: > Indeed in accordance with what is imeplemtned in the AHCI paltform driver Spelling; 'imeplemtned' and 'paltform' > and the way the AHCI DT nodes are defined in the DT files we can add the > next AHCI DT properties constraints: AHCI CSR ID is fixed to 'ahci', PHY > name is fixed to 'sata-phy', AHCI controller can't have more than 32 ports > by design. > > Signed-off-by: Serge Semin > > Changelog v2: > - This is a new patch created after rebasing v1 onto the 5.18-rc3 kernel. > --- > .../devicetree/bindings/ata/ahci-common.yaml | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ata/ahci-common.yaml b/Documentation/devicetree/bindings/ata/ahci-common.yaml > index 620042ca12e7..a7d1a8353de3 100644 > --- a/Documentation/devicetree/bindings/ata/ahci-common.yaml > +++ b/Documentation/devicetree/bindings/ata/ahci-common.yaml > @@ -31,6 +31,8 @@ properties: > > reg-names: > description: CSR space IDs > + contains: > + const: ahci > > interrupts: > description: > @@ -71,14 +73,13 @@ properties: > maxItems: 1 > > phy-names: > - maxItems: 1 > + const: sata-phy > > ports-implemented: > $ref: '/schemas/types.yaml#/definitions/uint32' > description: > Mask that indicates which ports the HBA supports. Useful if PI is not > programmed by the BIOS, which is true for some embedded SoC's. > - maximum: 0x1f > > patternProperties: > "^sata-port@[0-9a-f]+$": > @@ -89,8 +90,12 @@ patternProperties: > > properties: > reg: > - description: AHCI SATA port identifier > - maxItems: 1 > + description: > + AHCI SATA port identifier. By design AHCI controller can't have > + more than 32 ports due to the CAP.NP fields and PI register size > + constraints. > + minimum: 0 > + maximum: 31 > > phys: > description: Individual AHCI SATA port PHY > @@ -98,7 +103,7 @@ patternProperties: > > phy-names: > description: AHCI SATA port PHY ID > - maxItems: 1 > + const: sata-phy > > target-supply: > description: Power regulator for SATA port target device Other than that it looks okay. Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer