From: Javier Martinez Canillas <javierm@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>, dri-devel@lists.freedesktop.org
Cc: Xinliang Liu <xinliang.liu@linaro.org>,
Chen Feng <puck.chen@hisilicon.com>,
patches@lists.linux.dev, David Airlie <airlied@linux.ie>,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
Huang Rui <ray.huang@amd.com>, John Stultz <jstultz@google.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Tian Tao <tiantao6@hisilicon.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm: hisilicon: depends on MMU
Date: Sun, 19 Jun 2022 16:24:57 +0200 [thread overview]
Message-ID: <d7469398-d872-3cb3-5238-1696e4e9415b@redhat.com> (raw)
In-Reply-To: <40d294df-de91-3f36-7d70-13cad54ac34f@redhat.com>
On 6/19/22 16:05, Javier Martinez Canillas wrote:
> Hello Randy,
>
> On 5/31/22 04:55, Randy Dunlap wrote:
>> Prevent a kconfig warning when MMU is not enabled by making
>> DRM_HISI_HIBMC depend on MMU.
>>
>> WARNING: unmet direct dependencies detected for DRM_TTM
>> Depends on [n]: HAS_IOMEM [=y] && DRM [=m] && MMU [=n]
>> Selected by [m]:
>> - DRM_TTM_HELPER [=m] && HAS_IOMEM [=y] && DRM [=m]
>> - DRM_HISI_HIBMC [=m] && HAS_IOMEM [=y] && DRM [=m] && PCI [=y] && (ARM64 || COMPILE_TEST [=y])
>>
>> Fixes: 4f7f1973b0c8 ("drm/vram: fix Kconfig")
Actually this fixes isn't the correct one AFAICT, it should probably be
either acad3fe650a5 ("drm/hisilicon: Removed the dependency on the mmu")
or a0f25a6bb319 ("drm/hisilicon/hibmc: Allow to be built if COMPILE_TEST
is enabled"). And those two commits should be mentioned in the description.
Maybe we can append the following two paragraphs to your commit message ?
The Kconfig symbol depended on MMU but that was dropped by commit acad3fe650a5
("drm/hisilicon: Removed the dependency on the mmu") because it already had as
a dependency ARM64 that already selects MMU.
But later, commit a0f25a6bb319 ("drm/hisilicon/hibmc: Allow to be built if
COMPILE_TEST is enabled") allowed the driver to be built for non-ARM64 when
the COMPILE_TEST is set but that could lead to unmet direct dependencies and
linking errors.
If you agree with the changes, I can do it before applying. Please let me know.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
prev parent reply other threads:[~2022-06-19 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 2:55 [PATCH] drm: hisilicon: depends on MMU Randy Dunlap
2022-05-31 2:55 ` Randy Dunlap
2022-06-19 14:05 ` Javier Martinez Canillas
2022-06-19 14:24 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7469398-d872-3cb3-5238-1696e4e9415b@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jstultz@google.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=patches@lists.linux.dev \
--cc=puck.chen@hisilicon.com \
--cc=ray.huang@amd.com \
--cc=rdunlap@infradead.org \
--cc=tiantao6@hisilicon.com \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.