From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF117C433EF for ; Thu, 17 Mar 2022 18:48:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237587AbiCQSta (ORCPT ); Thu, 17 Mar 2022 14:49:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237584AbiCQSt0 (ORCPT ); Thu, 17 Mar 2022 14:49:26 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A264C11BE52; Thu, 17 Mar 2022 11:48:08 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id ABF301F45A25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647542886; bh=0WzZgN9aj0s8HEM+nPIbGUukn4MTB8wYqvpInAw1fPY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=N7TCbvr7Xn1NBsfZdq5HFid3scc3xT6XYCe80AU9aFufOzzv5jFqfCPumrdJedHmb AVdzMfFYrR64U8BRyKzhAICQSO2TYQaFDyR1MbtHBE9RBxaL5C52+Q5yccbYmi/iBS M+0vYNRJonT0VJpJFR9lEp+l1lTLDSIEgovl4QFcuBiQMqu+GmnJhoypmm5ZI/Wr8w IM0GP0iCzWyeFRcAdktirYF7fHhcuzYwOy1+dMUB+bV4jBlrJY2I56o4YZJlgnx3Y4 hTQhgxW9U30DTtqNcAlJp+lS+QRjygHO/80E+xJse+1btt2BeUvoqzmqbvFgirMlm7 58oLeFJuq3s6Q== Message-ID: Date: Thu, 17 Mar 2022 15:47:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-bsh-smm-s2pro: Add tlv320aic31xx audio card node Content-Language: en-US To: Fabio Estevam Cc: Linux-ALSA , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team , linux-kernel , Mark Brown , Krzysztof Kozlowski , Liam Girdwood , Michael Trimarchi , Rob Herring , Sascha Hauer , Shawn Guo References: <20220210134049.32576-1-ariel.dalessandro@collabora.com> <20220210134049.32576-2-ariel.dalessandro@collabora.com> From: Ariel D'Alessandro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fabio, On 3/10/22 09:29, Fabio Estevam wrote: > Hi Ariel, > > On Thu, Feb 10, 2022 at 10:41 AM Ariel D'Alessandro > wrote: > >> +&i2c2 { >> + clock-frequency = <400000>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2c2>; >> + status = "okay"; >> + >> + codec: tlv320dac3101@18 { >> + #sound-dai-cells = <0>; >> + compatible = "ti,tlv320dac3101"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_dac_rst>; >> + reg = <0x18>; >> + >> + ai31xx-micbias-vg = ; >> + >> + HPVDD-supply = <&buck4_reg>; >> + SPRVDD-supply = <&vdd_input>; >> + SPLVDD-supply = <&vdd_input>; >> + AVDD-supply = <&buck4_reg>; >> + IOVDD-supply = <&buck4_reg>; >> + DVDD-supply = <&buck5_reg>; >> + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; >> + >> + clocks = <&clk IMX8MN_CLK_SAI3_ROOT>; >> + clock-names = "mclk"; > > The clocks and clock-names properties are not documented in the codec bindings. > > Also, the driver does not use call clk_get() on this mclk clock. > > You should drop the clocks and clock-names properties. The sound card driver is calling clk_get() on the codec's clock. See sound/soc/fsl/fsl-asoc-card.c: /* Get the MCLK rate only, and leave it controlled by CODEC drivers */ if (codec_dev) { struct clk *codec_clk = clk_get(codec_dev, NULL); if (!IS_ERR(codec_clk)) { priv->codec_priv.mclk_freq = clk_get_rate(codec_clk); clk_put(codec_clk); } } Regards, Ariel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B50E0C433F5 for ; Thu, 17 Mar 2022 18:49:08 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 04CDE18A6; Thu, 17 Mar 2022 19:48:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 04CDE18A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1647542946; bh=0WzZgN9aj0s8HEM+nPIbGUukn4MTB8wYqvpInAw1fPY=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=knfh2V/auFSMsT0Nxlp5AX74AvFMXYHPGWgsbjkwT1NX9UaimGYCneXOlPd9ys5Z5 HjmUg36sHcKcKRPasTZ3FW5nU8O2IOo85zKE2/w/tPep8uFU3MxPN2cuvPpWIyfOky 8O7QAiiWGBc85NF0rMTegNDhr/ecpMBIFN83wojI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 81735F80132; Thu, 17 Mar 2022 19:48:15 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6C230F8013F; Thu, 17 Mar 2022 19:48:14 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A3304F80087 for ; Thu, 17 Mar 2022 19:48:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A3304F80087 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="N7TCbvr7" Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id ABF301F45A25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647542886; bh=0WzZgN9aj0s8HEM+nPIbGUukn4MTB8wYqvpInAw1fPY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=N7TCbvr7Xn1NBsfZdq5HFid3scc3xT6XYCe80AU9aFufOzzv5jFqfCPumrdJedHmb AVdzMfFYrR64U8BRyKzhAICQSO2TYQaFDyR1MbtHBE9RBxaL5C52+Q5yccbYmi/iBS M+0vYNRJonT0VJpJFR9lEp+l1lTLDSIEgovl4QFcuBiQMqu+GmnJhoypmm5ZI/Wr8w IM0GP0iCzWyeFRcAdktirYF7fHhcuzYwOy1+dMUB+bV4jBlrJY2I56o4YZJlgnx3Y4 hTQhgxW9U30DTtqNcAlJp+lS+QRjygHO/80E+xJse+1btt2BeUvoqzmqbvFgirMlm7 58oLeFJuq3s6Q== Message-ID: Date: Thu, 17 Mar 2022 15:47:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-bsh-smm-s2pro: Add tlv320aic31xx audio card node Content-Language: en-US To: Fabio Estevam References: <20220210134049.32576-1-ariel.dalessandro@collabora.com> <20220210134049.32576-2-ariel.dalessandro@collabora.com> From: Ariel D'Alessandro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-ALSA , Krzysztof Kozlowski , Sascha Hauer , linux-kernel , Rob Herring , Liam Girdwood , Mark Brown , NXP Linux Team , Sascha Hauer , Michael Trimarchi , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Fabio, On 3/10/22 09:29, Fabio Estevam wrote: > Hi Ariel, > > On Thu, Feb 10, 2022 at 10:41 AM Ariel D'Alessandro > wrote: > >> +&i2c2 { >> + clock-frequency = <400000>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2c2>; >> + status = "okay"; >> + >> + codec: tlv320dac3101@18 { >> + #sound-dai-cells = <0>; >> + compatible = "ti,tlv320dac3101"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_dac_rst>; >> + reg = <0x18>; >> + >> + ai31xx-micbias-vg = ; >> + >> + HPVDD-supply = <&buck4_reg>; >> + SPRVDD-supply = <&vdd_input>; >> + SPLVDD-supply = <&vdd_input>; >> + AVDD-supply = <&buck4_reg>; >> + IOVDD-supply = <&buck4_reg>; >> + DVDD-supply = <&buck5_reg>; >> + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; >> + >> + clocks = <&clk IMX8MN_CLK_SAI3_ROOT>; >> + clock-names = "mclk"; > > The clocks and clock-names properties are not documented in the codec bindings. > > Also, the driver does not use call clk_get() on this mclk clock. > > You should drop the clocks and clock-names properties. The sound card driver is calling clk_get() on the codec's clock. See sound/soc/fsl/fsl-asoc-card.c: /* Get the MCLK rate only, and leave it controlled by CODEC drivers */ if (codec_dev) { struct clk *codec_clk = clk_get(codec_dev, NULL); if (!IS_ERR(codec_clk)) { priv->codec_priv.mclk_freq = clk_get_rate(codec_clk); clk_put(codec_clk); } } Regards, Ariel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93534C433F5 for ; Thu, 17 Mar 2022 18:49:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MAX1pel9UC5RGCUynhEKKTqf2lFi10p9H5SeIBdktbQ=; b=KqNibISP7T3kGb JMh7i2pyXsvM5k0+JPxa0hSgR/y1HddTb8eyEbx52GKMGHGykjA0b+ueXtwHLAIIlWEItgwpLN4yO NKNjoiH7CKn848DIIIM4VgIeelKQayO1gG8LlrXOksVw28HNQZ/0NMihwkNYxdJiC9vMyzt1ihW1W SBuK9XRRsxx06q7rZXoiLbZTvM29Skk+xeDnNw+tWLS1JEgZH4gODJmXkqm4y+kQLHpXrDG/9KINQ /o2KAAGEAoVguvgVsQuPSnVWoqvd2/zf5vXhNp1E3IVcjJ4kV6ogH0BmR6S+XwDzMWDksOtSedAAv bXW6PniSPkzfOvSjD90Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUvAV-00H3bb-5q; Thu, 17 Mar 2022 18:48:15 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUvAP-00H3b0-Vr for linux-arm-kernel@lists.infradead.org; Thu, 17 Mar 2022 18:48:11 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: adalessandro) with ESMTPSA id ABF301F45A25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647542886; bh=0WzZgN9aj0s8HEM+nPIbGUukn4MTB8wYqvpInAw1fPY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=N7TCbvr7Xn1NBsfZdq5HFid3scc3xT6XYCe80AU9aFufOzzv5jFqfCPumrdJedHmb AVdzMfFYrR64U8BRyKzhAICQSO2TYQaFDyR1MbtHBE9RBxaL5C52+Q5yccbYmi/iBS M+0vYNRJonT0VJpJFR9lEp+l1lTLDSIEgovl4QFcuBiQMqu+GmnJhoypmm5ZI/Wr8w IM0GP0iCzWyeFRcAdktirYF7fHhcuzYwOy1+dMUB+bV4jBlrJY2I56o4YZJlgnx3Y4 hTQhgxW9U30DTtqNcAlJp+lS+QRjygHO/80E+xJse+1btt2BeUvoqzmqbvFgirMlm7 58oLeFJuq3s6Q== Message-ID: Date: Thu, 17 Mar 2022 15:47:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-bsh-smm-s2pro: Add tlv320aic31xx audio card node Content-Language: en-US To: Fabio Estevam Cc: Linux-ALSA , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Sascha Hauer , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , NXP Linux Team , linux-kernel , Mark Brown , Krzysztof Kozlowski , Liam Girdwood , Michael Trimarchi , Rob Herring , Sascha Hauer , Shawn Guo References: <20220210134049.32576-1-ariel.dalessandro@collabora.com> <20220210134049.32576-2-ariel.dalessandro@collabora.com> From: Ariel D'Alessandro In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220317_114810_253970_07B23782 X-CRM114-Status: GOOD ( 15.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabio, On 3/10/22 09:29, Fabio Estevam wrote: > Hi Ariel, > > On Thu, Feb 10, 2022 at 10:41 AM Ariel D'Alessandro > wrote: > >> +&i2c2 { >> + clock-frequency = <400000>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_i2c2>; >> + status = "okay"; >> + >> + codec: tlv320dac3101@18 { >> + #sound-dai-cells = <0>; >> + compatible = "ti,tlv320dac3101"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_dac_rst>; >> + reg = <0x18>; >> + >> + ai31xx-micbias-vg = ; >> + >> + HPVDD-supply = <&buck4_reg>; >> + SPRVDD-supply = <&vdd_input>; >> + SPLVDD-supply = <&vdd_input>; >> + AVDD-supply = <&buck4_reg>; >> + IOVDD-supply = <&buck4_reg>; >> + DVDD-supply = <&buck5_reg>; >> + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; >> + >> + clocks = <&clk IMX8MN_CLK_SAI3_ROOT>; >> + clock-names = "mclk"; > > The clocks and clock-names properties are not documented in the codec bindings. > > Also, the driver does not use call clk_get() on this mclk clock. > > You should drop the clocks and clock-names properties. The sound card driver is calling clk_get() on the codec's clock. See sound/soc/fsl/fsl-asoc-card.c: /* Get the MCLK rate only, and leave it controlled by CODEC drivers */ if (codec_dev) { struct clk *codec_clk = clk_get(codec_dev, NULL); if (!IS_ERR(codec_clk)) { priv->codec_priv.mclk_freq = clk_get_rate(codec_clk); clk_put(codec_clk); } } Regards, Ariel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel