All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sungbo Eo <mans0n@gorani.run>
To: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
Cc: linux-gpio@vger.kernel.org, git@amd.com,
	devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
	robh+dt@kernel.org, brgl@bgdev.pl, linus.walleij@linaro.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2 2/2] gpio: pca9570: add slg7xl45106 support
Date: Sat, 17 Sep 2022 23:00:40 +0900	[thread overview]
Message-ID: <d756107b-5cc5-53ba-b420-d4664e3a9bb7@gorani.run> (raw)
In-Reply-To: <20220915114803.26185-3-shubhrajyoti.datta@amd.com>

Hi,

Thanks for the update.
I was thinking I should reply to your patch in the last month, but I was
a little busy at the time and I forgot to do so...

On 2022-09-15 20:48, Shubhrajyoti Datta wrote:
> slg7xl45106 is a I2C GPO expander.
> Add a compatible string for the same. Also update the
> driver to write and read from it.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> ---
> v2:
> Use platform data insted of compatible

Moving the command property into the new platform structure is nice.
And please add more description about the device in the commit message.
We don't even know the full name of the vendor from your patch.
I like the older version of your patch in that perspective.
https://lore.kernel.org/all/1656426829-1008-3-git-send-email-shubhrajyoti.datta@xilinx.com/
And a link to the device datasheet would be also nice (if possible).

> 
>  drivers/gpio/gpio-pca9570.c | 39 +++++++++++++++++++++++++++++++++----
>  1 file changed, 35 insertions(+), 4 deletions(-)

And I was also thinking that tpic2810 driver might be more appropriate
then this pca9570 driver for a device with one command byte.
Actually I had forked tpic2810 to create pca9570 to support a device
without any command byte.
Come to think of it, the two drivers may even be consolidated into a
single generic one... What do you think?

Thanks,
Sungbo

  parent reply	other threads:[~2022-09-17 14:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 11:48 [PATCH v2 0/2] gpio: pca9570: add slg7xl45106 support Shubhrajyoti Datta
2022-09-15 11:48 ` [PATCH v2 1/2] dt-bindings: gpio: pca9570: Add compatible for slg7xl45106 Shubhrajyoti Datta
2022-09-18  9:11   ` Krzysztof Kozlowski
2022-10-03 19:52   ` Linus Walleij
2022-09-15 11:48 ` [PATCH v2 2/2] gpio: pca9570: add slg7xl45106 support Shubhrajyoti Datta
2022-09-15 12:24   ` andy.shevchenko
2022-09-17 14:00   ` Sungbo Eo [this message]
2022-09-19  6:32     ` Datta, Shubhrajyoti
2022-09-19  7:01       ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d756107b-5cc5-53ba-b420-d4664e3a9bb7@gorani.run \
    --to=mans0n@gorani.run \
    --cc=andy.shevchenko@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=devicetree@vger.kernel.org \
    --cc=git@amd.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=shubhrajyoti.datta@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.