From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, Oleh Kravchenko <oleg@kaa.org.ua>,
devicetree@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: Add docs for EL15203000
Date: Wed, 14 Aug 2019 21:54:48 +0200 [thread overview]
Message-ID: <d75d5fea-0a7c-b057-d972-c7747df7f33b@gmail.com> (raw)
In-Reply-To: <ea3d06b2-3689-bcfc-8f5f-6345634cfa2b@ti.com>
Dan,
On 8/13/19 10:31 PM, Dan Murphy wrote:
> Jacek
>
> Need your input below
>
> On 8/8/19 3:32 PM, Oleh Kravchenko wrote:
>> Add documentation and example for dt-bindings EL15203000.
>> LED board (aka RED LED board) from Crane Merchandising Systems.
>>
>> Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
>> ---
>> .../bindings/leds/leds-el15203000.txt | 47 +++++++++++++++++++
>> 1 file changed, 47 insertions(+)
>> create mode 100644
>> Documentation/devicetree/bindings/leds/leds-el15203000.txt
>>
>> diff --git
>> a/Documentation/devicetree/bindings/leds/leds-el15203000.txt
>> b/Documentation/devicetree/bindings/leds/leds-el15203000.txt
>> new file mode 100644
>> index 000000000000..4c2245babfdc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-el15203000.txt
>> @@ -0,0 +1,47 @@
>> +Crane Merchandising System - el15203000 LED driver
>> +--------------------------------------------------
>> +
>> +This LED Board (aka RED LEDs board) is widely used in
>> +coffee vending machines produced by Crane Merchandising Systems.
>> +
>> +Required properties:
>> +- compatible : "crane,el15203000"
>> +- reg :
>> + see Documentation/devicetree/bindings/spi/spi-bus.txt
>> +- spi-max-frequency : (optional)
>> + see Documentation/devicetree/bindings/spi/spi-bus.txt
>> +
>> +Optional LED sub-node properties:
>> +- label :
>> + see Documentation/devicetree/bindings/leds/common.txt
>> +- linux,default-trigger :
>> + see Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example
>> +-------
>> +
>> +led-controller@0 {
>> + compatible = "crane,el15203000";
>> + reg = <0>;
>> + spi-max-frequency = <50000>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + /* water pipe */
>> + pipe@50 {
>> + reg = <0x50>;
>> + label = "red:pipe";
>
> Should we use the color and function property here?
Yes, label is already deprecated in the common LED bindings
in linux-next. We need separate color and function here.
> Not sure what function would be for pipe, screen or vending but there
> may be
>
> comparable functions that may fit.
These are functions specific to this board and it is not something
that could have some vast system-wide use. Common LED functions aim
rather to unify the naming for LEDs on standard system devices and
peripherals.
I'd not strive for creating common LED_FUNCTION macros for these.
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-08-14 19:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 20:32 [PATCH v4 1/2] dt-bindings: Add docs for EL15203000 Oleh Kravchenko
2019-08-08 20:32 ` [PATCH v4 2/2] leds: add LED driver for EL15203000 board Oleh Kravchenko
2019-08-13 20:28 ` Jacek Anaszewski
2019-08-13 20:28 ` Jacek Anaszewski
2019-08-13 20:37 ` Oleh Kravchenko
2019-08-14 18:18 ` Jacek Anaszewski
2019-08-14 19:46 ` Oleh Kravchenko
2019-08-14 19:57 ` Jacek Anaszewski
2019-08-14 20:16 ` Oleh Kravchenko
2019-08-14 20:53 ` Jacek Anaszewski
2019-08-14 20:58 ` Oleh Kravchenko
2019-08-17 15:02 ` Pavel Machek
2019-08-20 7:46 ` Oleh Kravchenko
2019-08-18 13:47 ` Jacek Anaszewski
2019-08-27 20:43 ` Oleh Kravchenko
2019-08-27 20:56 ` Jacek Anaszewski
2019-08-27 21:11 ` Oleh Kravchenko
2019-08-27 21:18 ` Jacek Anaszewski
2019-08-27 21:26 ` Oleh Kravchenko
2019-08-13 20:31 ` [PATCH v4 1/2] dt-bindings: Add docs for EL15203000 Dan Murphy
2019-08-13 20:31 ` Dan Murphy
2019-08-14 19:54 ` Jacek Anaszewski [this message]
2019-08-18 13:41 ` Jacek Anaszewski
2019-08-20 7:50 ` Oleh Kravchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d75d5fea-0a7c-b057-d972-c7747df7f33b@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=oleg@kaa.org.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.