From: Uri Mashiach <uri.mashiach@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 3/7] usb: host: xhci-omap: fix double weak board_usb_init functions
Date: Wed, 1 Mar 2017 11:12:39 +0200 [thread overview]
Message-ID: <d7643218-ed71-26e1-1e8d-e941dbab7efa@compulab.co.il> (raw)
In-Reply-To: <40984a1d-bd4e-75a8-d3f4-908ef43aa1eb@ti.com>
On 02/28/2017 03:13 PM, Roger Quadros wrote:
> On 28/02/17 10:00, Uri Mashiach wrote:
>> Hi,
>>
>> On 02/27/2017 06:22 PM, Roger Quadros wrote:
>>> Hi,
>>>
>>> On 23/02/17 15:39, Uri Mashiach wrote:
>>>> A weak version of the function board_usb_init is implemented in:
>>>> common/usb.c
>>>> drivers/usb/host/xhci-omap.c
[...]
>>>> board/compulab/cl-som-am57x/cl-som-am57x.c | 2 +-
>>>> board/ti/am43xx/board.c | 4 ++--
>>>> board/ti/am57xx/board.c | 4 ++--
>>>> board/ti/dra7xx/evm.c | 4 ++--
>>>> drivers/usb/host/xhci-omap.c | 17 +++++++++++++++--
>>>
>>> What about board/ti/omap5_uevm/evm.c ?
>>
>> The symbol CONFIG_USB_XHCI_OMAP is not included in the file include/configs/omap5_uevm.h, therefore:
>> The file drivers/usb/host/xhci-omap.c is not included in the compilation - no double implementations to fix.
>>
>
> But if someone wants to use the XHCI host he will enable the CONFIG_USB_XHCI_OMAP for omap5_uevm right?
> We need to ensure it doesn't break then.
>
Compilation errors are generated for compilation attempt of U-Boot for
the target ti/omap5_uevm with CONFIG_USB_XHCI_OMAP.
Maybe the adjustments relevant for the current commit should be applied
after the CONFIG_USB_XHCI_OMAP adjustments?
Generated error messages:
In file included from include/asm/arch/sys_proto.h:12:0,
from /home/work/u-boot/board/ti/omap5_uevm/evm.c:12:
/home/work/u-boot/board/ti/omap5_uevm/evm.c: In function
'enable_host_clocks':
/home/work/u-boot/board/ti/omap5_uevm/evm.c:172:22: error: 'const struct
prcm_regs' has no member named 'cm_l3init_usb_otg_ss_clkctrl'
setbits_le32((*prcm)->cm_l3init_usb_otg_ss_clkctrl,
^
/home/work/u-boot/arch/arm/include/asm/io.h:78:55: note: in definition
of macro '__arch_putl'
#define __arch_putl(v,a) (*(volatile unsigned int *)(a) = (v))
^
/home/work/u-boot/arch/arm/include/asm/io.h:175:35: note: in expansion
of macro '__raw_writel'
#define out_arch(type,endian,a,v) __raw_write##type(cpu_to_##endian(v),a)
^
/home/work/u-boot/arch/arm/include/asm/io.h:179:23: note: in expansion
of macro 'out_arch'
#define out_le32(a,v) out_arch(l,le32,a,v)
^
/home/work/u-boot/arch/arm/include/asm/io.h:199:2: note: in expansion of
macro 'out_le32'
out_##type((addr), in_##type(addr) | (set))
^
/home/work/u-boot/arch/arm/include/asm/io.h:209:33: note: in expansion
of macro 'setbits'
#define setbits_le32(addr, set) setbits(le32, addr, set)
^
/home/work/u-boot/board/ti/omap5_uevm/evm.c:172:2: note: in expansion of
macro 'setbits_le32'
setbits_le32((*prcm)->cm_l3init_usb_otg_ss_clkctrl,
^
/home/work/u-boot/board/ti/omap5_uevm/evm.c:172:22: error: 'const struct
prcm_regs' has no member named 'cm_l3init_usb_otg_ss_clkctrl'
setbits_le32((*prcm)->cm_l3init_usb_otg_ss_clkctrl,
^
/home/work/u-boot/arch/arm/include/asm/io.h:78:61: note: in definition
of macro '__arch_putl'
#define __arch_putl(v,a) (*(volatile unsigned int *)(a) = (v))
^
/home/work/u-boot/arch/arm/include/asm/io.h:175:35: note: in expansion
of macro '__raw_writel'
#define out_arch(type,endian,a,v) __raw_write##type(cpu_to_##endian(v),a)
^
/home/work/u-boot/include/linux/byteorder/generic.h:89:21: note: in
expansion of macro '__cpu_to_le32'
#define cpu_to_le32 __cpu_to_le32
^
/home/work/u-boot/arch/arm/include/asm/io.h:179:23: note: in expansion
of macro 'out_arch'
#define out_le32(a,v) out_arch(l,le32,a,v)
^
/home/work/u-boot/arch/arm/include/asm/io.h:199:2: note: in expansion of
macro 'out_le32'
out_##type((addr), in_##type(addr) | (set))
^
/home/work/u-boot/include/linux/byteorder/generic.h:90:21: note: in
expansion of macro '__le32_to_cpu'
#define le32_to_cpu __le32_to_cpu
^
/home/work/u-boot/arch/arm/include/asm/io.h:133:25: note: in expansion
of macro '__arch_getl'
#define __raw_readl(a) __arch_getl(a)
^
/home/work/u-boot/arch/arm/include/asm/io.h:176:49: note: in expansion
of macro '__raw_readl'
#define in_arch(type,endian,a) endian##_to_cpu(__raw_read##type(a))
^
/home/work/u-boot/arch/arm/include/asm/io.h:183:20: note: in expansion
of macro 'in_arch'
#define in_le32(a) in_arch(l,le32,a)
^
/home/work/u-boot/arch/arm/include/asm/io.h:199:21: note: in expansion
of macro 'in_le32'
out_##type((addr), in_##type(addr) | (set))
^
/home/work/u-boot/arch/arm/include/asm/io.h:209:33: note: in expansion
of macro 'setbits'
#define setbits_le32(addr, set) setbits(le32, addr, set)
^
/home/work/u-boot/board/ti/omap5_uevm/evm.c:172:2: note: in expansion of
macro 'setbits_le32'
setbits_le32((*prcm)->cm_l3init_usb_otg_ss_clkctrl,
^
/home/work/u-boot/board/ti/omap5_uevm/evm.c: At top level:
/home/work/u-boot/board/ti/omap5_uevm/evm.c:269:5: error: redefinition
of 'board_usb_init'
int board_usb_init(int index, enum usb_init_type init)
^
/home/work/u-boot/board/ti/omap5_uevm/evm.c:83:5: note: previous
definition of 'board_usb_init' was here
int board_usb_init(int index, enum usb_init_type init)
^
/home/work/u-boot/board/ti/omap5_uevm/evm.c: In function 'board_usb_init':
/home/work/u-boot/board/ti/omap5_uevm/evm.c:271:6: warning: unused
variable 'ret' [-Wunused-variable]
int ret;
^
--
Thanks and Regards,
Uri
next prev parent reply other threads:[~2017-03-01 9:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 13:39 [U-Boot] [PATCH v4 0/7] am57xx: cl-som-am57x: fix usb Uri Mashiach
2017-02-23 13:39 ` [U-Boot] [PATCH v4 1/7] arm: dra7xx: move CONFIG_DRA7XX to Kconfig Uri Mashiach
2017-02-26 15:16 ` Tom Rini
2017-05-08 19:38 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 2/7] arm: usb: dra7xx: xHCI registers based on USB port index Uri Mashiach
2017-02-26 12:26 ` Marek Vasut
2017-02-26 15:16 ` Tom Rini
2017-02-27 16:14 ` Roger Quadros
2017-02-27 20:39 ` Marek Vasut
2017-02-27 20:38 ` Marek Vasut
2017-05-08 19:38 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 3/7] usb: host: xhci-omap: fix double weak board_usb_init functions Uri Mashiach
2017-02-26 12:25 ` Igor Grinberg
2017-02-26 12:29 ` Marek Vasut
2017-02-27 16:22 ` Roger Quadros
2017-02-28 8:00 ` Uri Mashiach
2017-02-28 13:13 ` Roger Quadros
2017-03-01 9:12 ` Uri Mashiach [this message]
2017-03-01 15:13 ` Roger Quadros
2017-03-01 15:13 ` Roger Quadros
2017-05-08 19:39 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 4/7] arm: am57xx: cl-som-am57x: invoke clock API to enable/disable clocks Uri Mashiach
2017-02-26 12:27 ` Marek Vasut
2017-02-27 16:24 ` Roger Quadros
2017-02-27 18:14 ` Marek Vasut
2017-05-08 19:39 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 5/7] arm: am57xx: cl-som-am57x: fix USB scan Uri Mashiach
2017-05-08 19:39 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 6/7] arm: am57xx: cl-som-am57x: enable USB storage Uri Mashiach
2017-05-08 19:39 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-02-23 13:39 ` [U-Boot] [PATCH v4 7/7] arm: am57xx: cl-som-am57x: enable USB commands Uri Mashiach
2017-05-08 19:39 ` [U-Boot] [U-Boot, v4, " Tom Rini
2017-04-23 8:18 ` [U-Boot] [PATCH v4 0/7] am57xx: cl-som-am57x: fix usb Uri Mashiach
2017-04-25 1:09 ` Tom Rini
2017-04-25 19:27 ` Marek Vasut
2017-05-04 7:05 ` Igor Grinberg
2017-05-04 10:08 ` Marek Vasut
2017-05-05 14:17 ` Tom Rini
2017-05-08 12:45 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7643218-ed71-26e1-1e8d-e941dbab7efa@compulab.co.il \
--to=uri.mashiach@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.