From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH] example/ipv4_multicast: fix app hanging when
 using clone
Date: Tue, 13 Nov 2018 10:21:49 +0000
Message-ID: <d771c18a-9675-a083-6c72-0187d2a6eba1@intel.com>
References: <20181112204650.7175-1-herakliusz.lipiec@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: konstantin.ananyev@intel.com
To: Herakliusz Lipiec <herakliusz.lipiec@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id C48512BD5
 for <dev@dpdk.org>; Tue, 13 Nov 2018 11:21:51 +0100 (CET)
In-Reply-To: <20181112204650.7175-1-herakliusz.lipiec@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12-Nov-18 8:46 PM, Herakliusz Lipiec wrote:
> This example was dropping packets when using clone (ip 224.0.0.103).
> The problem was that mbufs were not freed. This was caused by coping
> ol_flags from cloned mbuf to header mbufs.
> 
> Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> ---

I agree with Thomas, needs clearer description. Suggest using some of 
the wording provided by Konstantin in later replies. Also, needs a 
Fixes: tag and a CC: stable, because it appears that this bug has been 
around for a few releases.

-- 
Thanks,
Anatoly