All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next] net: dsa: sja1105: stop using priv->vlan_aware
Date: Wed, 22 Sep 2021 11:40:19 -0700	[thread overview]
Message-ID: <d78f2bab-6c2a-73d3-080a-d5607af9be6e@gmail.com> (raw)
In-Reply-To: <20210922183837.z2ujekutxyasvxde@skbuf>

On 9/22/21 11:38 AM, Vladimir Oltean wrote:
> On Wed, Sep 22, 2021 at 07:24:43PM +0300, Vladimir Oltean wrote:
>> On Wed, Sep 22, 2021 at 05:44:01PM +0300, Vladimir Oltean wrote:
>>> +	if (!dsa_port_is_vlan_filtering(ds, port) &&
>>
>> omg, what did I just send....
>> I amended the commit a few times but forgot to format-patch it again.
>> The dsa_port_is_vlan_filtering prototype takes a "dp" argument, this
>> patch doesn't even build. Please toss it to the bin where it belongs.
> 
> Superseded by v2 which has message ID 20210922183655.2680551-1-vladimir.oltean@nxp.com
> Florian, please note that I did not preserve your Reviewed-by tag, due
> to the patch looking fairly differently now.

Yes I completely missed that argument misuse, the changes look logically
correct, too quick in reviewing I guess :)
-- 
Florian

  reply	other threads:[~2021-09-22 18:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 14:44 [PATCH net-next] net: dsa: sja1105: stop using priv->vlan_aware Vladimir Oltean
2021-09-22 16:10 ` Florian Fainelli
2021-09-22 16:24 ` Vladimir Oltean
2021-09-22 18:38   ` Vladimir Oltean
2021-09-22 18:40     ` Florian Fainelli [this message]
2021-10-02  4:25 ` kernel test robot
2021-10-02  4:25   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d78f2bab-6c2a-73d3-080a-d5607af9be6e@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=vivien.didelot@gmail.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.