From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3E9C433DF for ; Tue, 19 May 2020 16:17:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7FE12075F for ; Tue, 19 May 2020 16:17:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729238AbgESQRW (ORCPT ); Tue, 19 May 2020 12:17:22 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:54842 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728689AbgESQRW (ORCPT ); Tue, 19 May 2020 12:17:22 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: koike) with ESMTPSA id C3E642A00A3 Subject: Re: [PATCH] media: staging: rkisp1: set more precise size errors in debugfs To: Dafna Hirschfeld , linux-media@vger.kernel.org, ezequiel@collabora.com, hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com, sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org, mchehab@kernel.org, laurent.pinchart@ideasonboard.com References: <20200514142102.16111-1-dafna.hirschfeld@collabora.com> From: Helen Koike Message-ID: Date: Tue, 19 May 2020 13:17:13 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200514142102.16111-1-dafna.hirschfeld@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Dafna, Thanks for the patch. On 5/14/20 11:21 AM, Dafna Hirschfeld wrote: > When a size error is signaled, it is possible to read a register > to see where the error comes from. So, in debugfs the general > error 'pic_size_err' can be replaced with 3 more precise errors. > > Signed-off-by: Dafna Hirschfeld > --- > drivers/staging/media/rkisp1/rkisp1-common.h | 4 +++- > drivers/staging/media/rkisp1/rkisp1-dev.c | 8 ++++++-- > drivers/staging/media/rkisp1/rkisp1-isp.c | 7 ++++++- > 3 files changed, 15 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-common.h b/drivers/staging/media/rkisp1/rkisp1-common.h > index 0c4fe503adc9..95d54306bae6 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-common.h > +++ b/drivers/staging/media/rkisp1/rkisp1-common.h > @@ -226,7 +226,9 @@ struct rkisp1_resizer { > struct rkisp1_debug { > struct dentry *debugfs_dir; > unsigned long data_loss; > - unsigned long pic_size_error; > + unsigned long outform_size_error; > + unsigned long is_size_error; I would just do s/is/img_stabilization otherwise it is easy to read it as a verb, and it feels it's a boolean, and not a counter. With this: Acked-by: Helen Koike Regards, Helen > + unsigned long inform_size_error; > unsigned long mipi_error; > unsigned long stats_error; > unsigned long stop_timeout[2]; > diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c > index 9ac38bafb839..2298d3ae5950 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-dev.c > +++ b/drivers/staging/media/rkisp1/rkisp1-dev.c > @@ -438,8 +438,12 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1) > } > debugfs_create_ulong("data_loss", 0444, debug->debugfs_dir, > &debug->data_loss); > - debugfs_create_ulong("pic_size_error", 0444, debug->debugfs_dir, > - &debug->pic_size_error); > + debugfs_create_ulong("outform_size_err", 0444, debug->debugfs_dir, > + &debug->outform_size_error); > + debugfs_create_ulong("is_size_error", 0444, debug->debugfs_dir, > + &debug->is_size_error); > + debugfs_create_ulong("inform_size_error", 0444, debug->debugfs_dir, > + &debug->inform_size_error); > debugfs_create_ulong("mipi_error", 0444, debug->debugfs_dir, > &debug->mipi_error); > debugfs_create_ulong("stats_error", 0444, debug->debugfs_dir, > diff --git a/drivers/staging/media/rkisp1/rkisp1-isp.c b/drivers/staging/media/rkisp1/rkisp1-isp.c > index dc2b59a0160a..a7e5461e25a5 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-isp.c > +++ b/drivers/staging/media/rkisp1/rkisp1-isp.c > @@ -1123,8 +1123,13 @@ void rkisp1_isp_isr(struct rkisp1_device *rkisp1) > if (status & RKISP1_CIF_ISP_PIC_SIZE_ERROR) { > /* Clear pic_size_error */ > isp_err = rkisp1_read(rkisp1, RKISP1_CIF_ISP_ERR); > + if (isp_err & RKISP1_CIF_ISP_ERR_INFORM_SIZE) > + rkisp1->debug.inform_size_error++; > + if (isp_err & RKISP1_CIF_ISP_ERR_IS_SIZE) > + rkisp1->debug.is_size_error++; > + if (isp_err & RKISP1_CIF_ISP_ERR_OUTFORM_SIZE) > + rkisp1->debug.outform_size_error++; > rkisp1_write(rkisp1, isp_err, RKISP1_CIF_ISP_ERR_CLR); > - rkisp1->debug.pic_size_error++; > } else if (status & RKISP1_CIF_ISP_DATA_LOSS) { > /* keep track of data_loss in debugfs */ > rkisp1->debug.data_loss++; >