From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BA5DC34047 for ; Wed, 19 Feb 2020 14:31:57 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 158B824656 for ; Wed, 19 Feb 2020 14:31:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 158B824656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4QO6-0005Pe-Sl; Wed, 19 Feb 2020 14:31:42 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4QO5-0005PY-5Y for xen-devel@lists.xenproject.org; Wed, 19 Feb 2020 14:31:41 +0000 X-Inumbo-ID: 8a9f8024-5324-11ea-8382-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 8a9f8024-5324-11ea-8382-12813bfff9fa; Wed, 19 Feb 2020 14:31:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 819B6ACCA; Wed, 19 Feb 2020 14:31:39 +0000 (UTC) Message-ID: From: Dario Faggioli To: Juergen Gross , xen-devel@lists.xenproject.org Date: Wed, 19 Feb 2020 15:31:38 +0100 In-Reply-To: <20200213125449.14226-6-jgross@suse.com> References: <20200213125449.14226-1-jgross@suse.com> <20200213125449.14226-6-jgross@suse.com> Organization: SUSE User-Agent: Evolution 3.34.3 MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH 5/8] xen/sched: use keyhandler locks when dumping data to console X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: George Dunlap , Meng Xu Content-Type: multipart/mixed; boundary="===============1797895447277034140==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" --===============1797895447277034140== Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-CTHXzyZ8X4WRwH0OQ7C6" --=-CTHXzyZ8X4WRwH0OQ7C6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2020-02-13 at 13:54 +0100, Juergen Gross wrote: > Instead of using the normal locks use the keyhandler provided > trylocks > with timeouts. This requires a special primitive for the scheduler > lock. >=20 So, FWIW, I tend to agree with Andrew on the general aspects of this. I.e., I personally don't think that the added complexity, however small one may judge it to be, is worth it... I'm not even sure not using regular locks is really an improvement. When you mentioned, in your other mail, that having something like this would have saved a lot of reboots during the development of core- scheduling, would _just_ disabling the watchdog have achieved the same? Anyway, I've had a look at this patch. _If_ we go with this new lock thing, the modifications to the scheduler code done here seems fine to me. Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-CTHXzyZ8X4WRwH0OQ7C6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAl5NRsoACgkQFkJ4iaW4 c+4gTRAAsWcvavCEk0LPMHwt3V62ErulR1pLAtXsSDy6ZI7MCTBlMO0mONNfBFn5 u1345C4qWad2twv4KRZGDhVXp0CNjdufH8IAN0/faNko+myW6BxTZ9hWoIHAqnrF 7BoeHOSjoaNG9h/DDl2LdqX6haXRLN+5CBt/eSp1zDzL+1re5naTNwpFEVn/qN/L xPJYg3r0gW9Jl+v9J8SE9EVYpiz+TOAh4OuV/M/xNzPxUHgCR3aPWDsmg8NSDvDA y7m7JisBHTBxKOeMhAZT7TPPyNgZbnS0KfS1sN0TpH/SUwiML5hPF8S5YaRoppYW P4MNtgLwqXoReRxTTxcN1vBjDn9CC/U3CcC3KGihnjo4wc+NZSaq1fHOznkBAVYV lAvdifiCG7vBHtyoj5VQtoTzpqNz2b0F0C7kc2e5nxGqHqmCSUXqYlcl0EJ1Wgm9 CEPkHdKm6PNNoB4WlgtAfnKV8k5sx8xE2AtQ9NNaGFXL52t75JZX+EvYFckHxoHZ H+Jw3SYGcqtBdlhQEZr0hBcmmQxan72qt2tPGCFTZW7vx2o7FXbBOBqR4tuazETi r1CMOB6Jsam5GzZzEAzLcwhNWRdl8Q6asR9z4h2Uy9SJqYCVQbk+GUCDRTK3nnyX lvjkjhFoCxTqbzEPaMZ7+PB5bYegfb0N9UScKN0S56gQ8uiJx38= =mzuf -----END PGP SIGNATURE----- --=-CTHXzyZ8X4WRwH0OQ7C6-- --===============1797895447277034140== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============1797895447277034140==--