From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E09CC432BE for ; Wed, 25 Aug 2021 14:41:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DE01610CE for ; Wed, 25 Aug 2021 14:41:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241615AbhHYOmQ (ORCPT ); Wed, 25 Aug 2021 10:42:16 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:8774 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbhHYOmG (ORCPT ); Wed, 25 Aug 2021 10:42:06 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GvpYl0PgdzYrGg; Wed, 25 Aug 2021 22:40:43 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 25 Aug 2021 22:41:16 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 25 Aug 2021 22:41:16 +0800 Subject: Re: [PATCH 3/3] amba: Properly handle device probe without IRQ domain To: Rob Herring CC: Saravana Kannan , "linux-kernel@vger.kernel.org" , Frank Rowand , , Russell King , "Linus Walleij" , linux-arm-kernel , Ruizhe Lin References: <20210816074619.177383-1-wangkefeng.wang@huawei.com> <20210816074619.177383-4-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: Date: Wed, 25 Aug 2021 22:41:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/25 20:33, Rob Herring wrote: > On Tue, Aug 24, 2021 at 11:05 PM Kefeng Wang wrote: ... >>> Similar to other resources the AMBA bus "gets" for the device, I think >>> this should be moved into amba_probe() and not here. There's no reason >>> to delay the addition of the device (and loading its module) because >>> the IRQ isn't ready yet. >> The following code in the amba_device_try_add() will be called, it uses irq[0] >> and irq[1], so I put of_amba_device_decode_irq() into amba_device_try_add(). >> >> 470 if (dev->irq[0]) >> 471 ret = device_create_file(&dev->dev, &dev_attr_irq0); >> 472 if (ret == 0 && dev->irq[1]) >> 473 ret = device_create_file(&dev->dev, &dev_attr_irq1); >> 474 if (ret == 0) >> 475 return ret; > I wonder if we could just remove these. Why does userspace need them > in the first place? It's only an ABI if someone notices. Looking at > the history, AMBA bus was added in 2003 with just 'irq' and then > changed (ABI break) in 2004 to 'irq0' and 'irq1'. > > Rob Ok, I will kill all irq parts, diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 962041148482..c08e8b30e02c 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -20,8 +20,6 @@  #include  #include -#include -  #define to_amba_driver(d)      container_of(d, struct amba_driver, drv)  /* called on periphid match and class 0x9 coresight device. */ @@ -135,8 +133,6 @@ static ssize_t name##_show(struct device *_dev,                             \  static DEVICE_ATTR_RO(name)  amba_attr_func(id, "%08x\n", dev->periphid); -amba_attr_func(irq0, "%u\n", dev->irq[0]); -amba_attr_func(irq1, "%u\n", dev->irq[1]);  amba_attr_func(resource, "\t%016llx\t%016llx\t%016lx\n",          (unsigned long long)dev->res.start, (unsigned long long)dev->res.end,          dev->res.flags); @@ -467,10 +463,6 @@ static int amba_device_try_add(struct amba_device *dev, struct resource *parent)         if (ret)                 goto err_release; -       if (dev->irq[0]) -               ret = device_create_file(&dev->dev, &dev_attr_irq0); -       if (ret == 0 && dev->irq[1]) -               ret = device_create_file(&dev->dev, &dev_attr_irq1); and do some cleanup about error handling in the next version. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/log/arch/arm/common/amba.c > . > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F175C4338F for ; Wed, 25 Aug 2021 14:43:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE74660E97 for ; Wed, 25 Aug 2021 14:43:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CE74660E97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CZAP6bzZT20btt1A7NLxbZc1zPEFJsdBAgyEnYCSRZg=; b=tPKRNHnIbPcuHZ5ptiTIRzWbFY ETDPqBTtV5z5bJXLrnMqJXx4c1BE8GqeYBPPy7wxyZGqGdB9rL8gXePRx4jNciClvItb3/fTsc1Vf QdCbG9UhOJ2fCLwKWukLOZr8uSdxXbEuBvoNpB/Dw5c4RalUjkaQ3cjk7D06GmqX1Hm/VS/eREiT+ Xo5TSNoJ7mjA583nb8Kk5R4Pndo7QlbWlExlYP3Tj+DWAFENKTH6LCH08lUIiwCQS4s6Gfoced9PP j4oUHy7XscdasuoUfGbUzCI/UKjlYjJlCXk3InWP9QqYs52F/gCbf3wEv6y8a1NDcuvUlfborl+G8 khSptwJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIu5k-007IFC-O1; Wed, 25 Aug 2021 14:41:24 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIu5g-007IEb-E0 for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 14:41:22 +0000 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GvpYl0PgdzYrGg; Wed, 25 Aug 2021 22:40:43 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 25 Aug 2021 22:41:16 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 25 Aug 2021 22:41:16 +0800 Subject: Re: [PATCH 3/3] amba: Properly handle device probe without IRQ domain To: Rob Herring CC: Saravana Kannan , "linux-kernel@vger.kernel.org" , Frank Rowand , , Russell King , "Linus Walleij" , linux-arm-kernel , Ruizhe Lin References: <20210816074619.177383-1-wangkefeng.wang@huawei.com> <20210816074619.177383-4-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: Date: Wed, 25 Aug 2021 22:41:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_074121_057324_BAFE5B99 X-CRM114-Status: GOOD ( 19.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjEvOC8yNSAyMDozMywgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gT24gVHVlLCBBdWcgMjQs IDIwMjEgYXQgMTE6MDUgUE0gS2VmZW5nIFdhbmcgPHdhbmdrZWZlbmcud2FuZ0BodWF3ZWkuY29t PiB3cm90ZToKCi4uLgoKPj4+IFNpbWlsYXIgdG8gb3RoZXIgcmVzb3VyY2VzIHRoZSBBTUJBIGJ1 cyAiZ2V0cyIgZm9yIHRoZSBkZXZpY2UsIEkgdGhpbmsKPj4+IHRoaXMgc2hvdWxkIGJlIG1vdmVk IGludG8gYW1iYV9wcm9iZSgpIGFuZCBub3QgaGVyZS4gVGhlcmUncyBubyByZWFzb24KPj4+IHRv IGRlbGF5IHRoZSBhZGRpdGlvbiBvZiB0aGUgZGV2aWNlIChhbmQgbG9hZGluZyBpdHMgbW9kdWxl KSBiZWNhdXNlCj4+PiB0aGUgSVJRIGlzbid0IHJlYWR5IHlldC4KPj4gVGhlIGZvbGxvd2luZyBj b2RlIGluIHRoZSBhbWJhX2RldmljZV90cnlfYWRkKCkgd2lsbCBiZSBjYWxsZWQsIGl0IHVzZXMg aXJxWzBdCj4+IGFuZCBpcnFbMV0sIHNvIEkgcHV0IG9mX2FtYmFfZGV2aWNlX2RlY29kZV9pcnEo KSBpbnRvIGFtYmFfZGV2aWNlX3RyeV9hZGQoKS4KPj4KPj4gNDcwICAgICAgICAgaWYgKGRldi0+ aXJxWzBdKQo+PiA0NzEgICAgICAgICAgICAgICAgIHJldCA9IGRldmljZV9jcmVhdGVfZmlsZSgm ZGV2LT5kZXYsICZkZXZfYXR0cl9pcnEwKTsKPj4gNDcyICAgICAgICAgaWYgKHJldCA9PSAwICYm IGRldi0+aXJxWzFdKQo+PiA0NzMgICAgICAgICAgICAgICAgIHJldCA9IGRldmljZV9jcmVhdGVf ZmlsZSgmZGV2LT5kZXYsICZkZXZfYXR0cl9pcnExKTsKPj4gNDc0ICAgICAgICAgaWYgKHJldCA9 PSAwKQo+PiA0NzUgICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gSSB3b25kZXIgaWYgd2Ug Y291bGQganVzdCByZW1vdmUgdGhlc2UuIFdoeSBkb2VzIHVzZXJzcGFjZSBuZWVkIHRoZW0KPiBp biB0aGUgZmlyc3QgcGxhY2U/IEl0J3Mgb25seSBhbiBBQkkgaWYgc29tZW9uZSBub3RpY2VzLiBM b29raW5nIGF0Cj4gdGhlIGhpc3RvcnksIEFNQkEgYnVzIHdhcyBhZGRlZCBpbiAyMDAzIHdpdGgg anVzdCAnaXJxJyBhbmQgdGhlbgo+IGNoYW5nZWQgKEFCSSBicmVhaykgaW4gMjAwNCB0byAnaXJx MCcgYW5kICdpcnExJy4KPgo+IFJvYgoKT2ssIEkgd2lsbCBraWxsIGFsbCBpcnEgcGFydHMsCgpk aWZmIC0tZ2l0IGEvZHJpdmVycy9hbWJhL2J1cy5jIGIvZHJpdmVycy9hbWJhL2J1cy5jCmluZGV4 IDk2MjA0MTE0ODQ4Mi4uYzA4ZThiMzBlMDJjIDEwMDY0NAotLS0gYS9kcml2ZXJzL2FtYmEvYnVz LmMKKysrIGIvZHJpdmVycy9hbWJhL2J1cy5jCkBAIC0yMCw4ICsyMCw2IEBACiDCoCNpbmNsdWRl IDxsaW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4KIMKgI2luY2x1ZGUgPGxpbnV4L3Jlc2V0Lmg+Cgot I2luY2x1ZGUgPGFzbS9pcnEuaD4KLQogwqAjZGVmaW5lIHRvX2FtYmFfZHJpdmVyKGQpwqDCoMKg wqDCoCBjb250YWluZXJfb2YoZCwgc3RydWN0IGFtYmFfZHJpdmVyLCBkcnYpCgogwqAvKiBjYWxs ZWQgb24gcGVyaXBoaWQgbWF0Y2ggYW5kIGNsYXNzIDB4OSBjb3Jlc2lnaHQgZGV2aWNlLiAqLwpA QCAtMTM1LDggKzEzMyw2IEBAIHN0YXRpYyBzc2l6ZV90IG5hbWUjI19zaG93KHN0cnVjdCBkZXZp Y2UgCipfZGV2LMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIFwKIMKgc3RhdGljIERFVklDRV9BVFRSX1JPKG5hbWUpCgogwqBhbWJhX2F0dHJf ZnVuYyhpZCwgIiUwOHhcbiIsIGRldi0+cGVyaXBoaWQpOwotYW1iYV9hdHRyX2Z1bmMoaXJxMCwg IiV1XG4iLCBkZXYtPmlycVswXSk7Ci1hbWJhX2F0dHJfZnVuYyhpcnExLCAiJXVcbiIsIGRldi0+ aXJxWzFdKTsKIMKgYW1iYV9hdHRyX2Z1bmMocmVzb3VyY2UsICJcdCUwMTZsbHhcdCUwMTZsbHhc dCUwMTZseFxuIiwKIMKgwqDCoMKgwqDCoMKgwqAgKHVuc2lnbmVkIGxvbmcgbG9uZylkZXYtPnJl cy5zdGFydCwgKHVuc2lnbmVkIGxvbmcgCmxvbmcpZGV2LT5yZXMuZW5kLAogwqDCoMKgwqDCoMKg wqDCoCBkZXYtPnJlcy5mbGFncyk7CkBAIC00NjcsMTAgKzQ2Myw2IEBAIHN0YXRpYyBpbnQgYW1i YV9kZXZpY2VfdHJ5X2FkZChzdHJ1Y3QgYW1iYV9kZXZpY2UgCipkZXYsIHN0cnVjdCByZXNvdXJj ZSAqcGFyZW50KQogwqDCoMKgwqDCoMKgwqAgaWYgKHJldCkKIMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBnb3RvIGVycl9yZWxlYXNlOwoKLcKgwqDCoMKgwqDCoCBpZiAoZGV2LT5pcnFb MF0pCi3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9IGRldmljZV9jcmVhdGVfZmls ZSgmZGV2LT5kZXYsICZkZXZfYXR0cl9pcnEwKTsKLcKgwqDCoMKgwqDCoCBpZiAocmV0ID09IDAg JiYgZGV2LT5pcnFbMV0pCi3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldCA9IGRldmlj ZV9jcmVhdGVfZmlsZSgmZGV2LT5kZXYsICZkZXZfYXR0cl9pcnExKTsKCmFuZCBkbyBzb21lIGNs ZWFudXAgYWJvdXQgZXJyb3IgaGFuZGxpbmcgaW4gdGhlIG5leHQgdmVyc2lvbi4KCj4KPiBbMV0g aHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdGdseC9oaXN0 b3J5LmdpdC9sb2cvYXJjaC9hcm0vY29tbW9uL2FtYmEuYwo+IC4KPgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=