From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 589377A for ; Fri, 15 Apr 2022 05:09:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1649999376; x=1681535376; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6js5zQuBI=; b=ZSvt3T8OQ2Jm2/Xfxgrk/uVbw7y49fZfGvJ4GiWDoRq4bIXAVHddFrqp frzmY79dJgOJMC3dLLRPg9ZopZK/RjU7vHU1miL3Wl2zHgR18o5Uk04mM aWiEO9FR7d7MnU/wJ8S/xTMddAI1bGlAv7yadtHeX9nMYym1RiL2rsHU8 VLqE/MSDtgc01uz5LoIRWA8WHeFR+u8eUQdtcUnoMDNpJHIq4y6dc6lia X5E4v2yk63S2lHtgYLpgW4LnLsIJK3g+/vudri9h99FurVjVmiMWbGc/q oHQufLJgcWaqkJHE2CUDaNKLj12mpBCp5XuNVagbRt2k8iN2FsfPDtV1M g==; X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; d="scan'208";a="198866561" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:08:29 +0800 IronPort-SDR: FHgERS8KOIIRGBSL3BGvaf5Z1gFPfd0ggrHxe6SAM6n7KSiJXDgBoSUvoySuGvh6aa73gxPgRd +khkhpPsiwT3x8Hfb+9akztC3JXA5ALWh2MYLg+8SY7Rmbn0T10go6niunfQ8qY+renDa0Rtxi A8Zgf3RWmjIsS9vvr5GrmMoEwY/IQ56DJuDU+B9Arlc7znWt6lIUGMFaM05vXX1d1qsvDoID4d J9yz3MEy/fK/k8bEf6DRSJebuc+vbz/0PMngjq+jSdirGlowZ7+iio46sRWv7p4FzN9iXfUUE1 7mtCVJ9Qv4n263TsvqsL0Wrq Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 21:39:39 -0700 IronPort-SDR: 98ZV1nWfudwPOzr6+40En8gQWowCxF7vlbTPqOTzWbV650uiD1GlBA8lLZfdjJ1VxT/RCSrfVn NYwiXcwLM1pFkGvhmT43CYa13HbkohuV2NZMgL/+hoajJhkZtvn1xYRbwVEU7n6Vvx5o2DHT3j GOhzSLD1tSQ8/zi0omrauPkBfeQNGf9LfkL4+PHb5k2lkHFMAVuoKlKlMKPa48W5CTGwXJQs4z AtbvVnZA6+qCGeSv/EobdLjvlvVrdRL6+8s7I3usc110O1iMzCyfHBE3ih3AeZ0pEfiCSFwUME BMk= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 22:08:29 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Kfkqv63f7z1Rwrw for ; Thu, 14 Apr 2022 22:08:27 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1649999307; x=1652591308; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6 js5zQuBI=; b=PnLGxxEK3pLyssa8yxGNdC4XjW2wbor1ccVbtGFYLuF6J3cLtHd AbpMYH7aDhgG/pTbCzP2Jz5UXeITA2uAAyiR/Fy6attbFAobIm77MiZ1d9JwxmK8 shfFnnjg3a2RytIj37jVhbyrF9O4v+hLyhCzQz2dnHJygtOnBuY0SiH0emrVEC5V 37Q51RwNl9CEkvSI7J63mNoy2HlvXkxHid/Xl33/pVaD25Hfmrh/cyibuFKv7AtS /tmUO1ElBPCNJo60JkfPy33eMUDO0eae+UlOxVUV5CwFdxfl0b0VIs1osnbs2TmY qPuOzeMMi/kXJvdALFOBXWDwdlihcT0EYFQ== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kyUCwL3vygvr for ; Thu, 14 Apr 2022 22:08:27 -0700 (PDT) Received: from [10.225.163.9] (unknown [10.225.163.9]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Kfkqn6sCZz1Rvlx; Thu, 14 Apr 2022 22:08:21 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 14:08:20 +0900 Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 27/27] direct-io: remove random prefetches Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-28-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220415045258.199825-28-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/15/22 13:52, Christoph Hellwig wrote: > Randomly poking into block device internals for manual prefetches isn't > exactly a very maintainable thing to do. And none of the performance > criticil direct I/O implementations still use this library function s/criticil/critical > anyway, so just drop it. > > Signed-off-by: Christoph Hellwig Looks good to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 027B0C433EF for ; Fri, 15 Apr 2022 05:08:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-111-dQW_WL6wN0S2VrMM_MET8A-1; Fri, 15 Apr 2022 01:08:35 -0400 X-MC-Unique: dQW_WL6wN0S2VrMM_MET8A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7172B296A621; Fri, 15 Apr 2022 05:08:33 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 084A9200BCD8; Fri, 15 Apr 2022 05:08:33 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AB741194034A; Fri, 15 Apr 2022 05:08:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9F83119451EC for ; Fri, 15 Apr 2022 05:08:31 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 704E44644E5; Fri, 15 Apr 2022 05:08:31 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C11B4021D9 for ; Fri, 15 Apr 2022 05:08:31 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 533E2101AA42 for ; Fri, 15 Apr 2022 05:08:31 +0000 (UTC) Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-bFAAL9YKOiCJRSxpz5CFMw-2; Fri, 15 Apr 2022 01:08:29 -0400 X-MC-Unique: bFAAL9YKOiCJRSxpz5CFMw-2 X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; d="scan'208";a="309936192" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:08:27 +0800 IronPort-SDR: lj47UAAc/Kn31swVMIewKjkB4948++5rwGCVMmG3sT85K9vgG+c03N+XvfQZOzwxgc0YttG1YJ TiZGiY99PvViTRlSuhOcsEPScMVayEX9GXVpZfxa0G1abOZYso6OLG32sKYjpb0CC/FWcHMDCw 0zmUd1k2XsDMFObatr2XJ3CSjUitcgfQ6MgdErpEL7AvtZYw5Q0cUb9ljMRpNXzE5BqUn2/76X Jrmvamh1ZK9wSlzjSpiBYRZOnMpX/crguKx9MnM4/r3XY19tadY0oi4E9f0l0e2VzcndXqaH8w jr0FWll4iXZCOpV0s4to6E4P Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 21:39:38 -0700 IronPort-SDR: GWVQqcU8Vr7xZO5dwI5Sor0USXHhG7q7NN8e1PaYnaSbbXlFmO+bKHyx9Qn66vNQd5x462xT7Y KKu2i07dHJPngLeTtvZVW7I8gtnoS5eL2wGreeFE0I6Pkyxb3uZ80OPiC4ZymsTNq0V3+OIRUH ITtDTZJytezGTxU3cgPBPK05ARj91qqpzTcm4hxT3phLSHZCHRnU5F/n/S7/odVKiRXoz/wcE0 JiaYfREHxXSEkzAE37+KEyWdYUs3YE4hOlB3MnZriI8DeJ55EMSbTlWhocw5Vkw6XJ6UqakQ7q aSg= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 22:08:28 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Kfkqt4YNtz1SVp0 for ; Thu, 14 Apr 2022 22:08:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id oJO6gczxXB3n for ; Thu, 14 Apr 2022 22:08:25 -0700 (PDT) Received: from [10.225.163.9] (unknown [10.225.163.9]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Kfkqn6sCZz1Rvlx; Thu, 14 Apr 2022 22:08:21 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 14:08:20 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 To: Christoph Hellwig , Jens Axboe References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-28-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220415045258.199825-28-hch@lst.de> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Subject: Re: [dm-devel] [PATCH 27/27] direct-io: remove random prefetches X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, cluster-devel@redhat.com, xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org, linux-um@lists.infradead.org, nbd@other.debian.org, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 4/15/22 13:52, Christoph Hellwig wrote: > Randomly poking into block device internals for manual prefetches isn't > exactly a very maintainable thing to do. And none of the performance > criticil direct I/O implementations still use this library function s/criticil/critical > anyway, so just drop it. > > Signed-off-by: Christoph Hellwig Looks good to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFC3FC433EF for ; Fri, 15 Apr 2022 05:11:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PKvcXR+M2pMSbFh0HxTIXX/qPHthT+yyyM9n+mn5FQ0=; b=spQCfY4kNuBQmu uokYEojaEonmE/fOUIywVGfEKs8oH3pYYgOiAnJFe+rYaUi2W69t/9cQfk5UQFbAS3YmGWxmEzdqe fmsFUHP1gMhBMKYnEdNS5Yz9Z/jMjog2SfZnS40YbEb5ENwL4uhQ46qV14OoRJiiZpTn8rb8LEM1A X6AxcCVbyJWu9tZUJjMn0SiOrpSVqgTI00sDvZ4xjj6wgvoJPoQUUSg6xkND0PBW2cJLJBGcAj70+ 8lnm1KYI6NOYZOIFOe2vKz/qNy7KauQfHL+k3MVKeME4O2nERpblJvOXczgYuDpUr+n+PLoUShfjY yOEUdJSRPRnlnHg7599Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfEEO-008bRd-2N; Fri, 15 Apr 2022 05:10:52 +0000 Received: from esa1.hgst.iphmx.com ([68.232.141.245]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfEC5-008aDI-Kp for linux-mtd@lists.infradead.org; Fri, 15 Apr 2022 05:08:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1649999309; x=1681535309; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6js5zQuBI=; b=CeodHj5AU0alJr2r4eFscU+D8m0kJXg1ODgX9nrmamfCnysDgYDih22x A4/4CNNDVJqetnitRhP6wlNYKCh51OoqZs/JpkVdBXrzAw7MjvRXiCuCA sEGzd1ON9AuuxolKxnCdScJO0/KGz3U4+0aVIT2Oniu/0tRDxkDlefefE aBVcr4cb1mtfuWvGR70CKnKu0E9O8bgUM+ieBmu1if8AEiGLt0Iq876Ie RRwzUpkQndC5L1W1oyQJ1SMWwbPVZ4ELzZL/38iaxBRBDIHBD1UsLmqoG P4slNwlBXE8J3zUa0jzEzdJ7D1+/5RIjzNeVmCCxKHslzHDp9bp2H9SE3 w==; X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; d="scan'208";a="309936197" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:08:28 +0800 IronPort-SDR: zyB1mXfYUQb65Ge5AU2xRcfX45jlOXkUBt4XLQzfhuJJ31CDzopvi3ceRbW5CQfdqaW/pIvSwN N9wV/qK5dCuTWTOVfGtYBMATe/8ZDvt1Ky3IPv3oU73mjka/obW928jrBiGmX+G+BeTl46BrBD lnYsS/qfS7r4wzaFG7u7zfcGSYTOKUnGV1P36H8vmsb+/znUac1IigxOc11RRQzS72si9OGeXV GyqfzbfM6vTn7Q0nKcwLR3XlUZW0svhk5osTmEZpLpQ1TRJENfqimRONnbB5bsxhOSzz8rY6bi k63vBuSiOZEkOkIlAPh/SUyc Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 21:39:39 -0700 IronPort-SDR: pAllGb8f5D7jmPb603Xt+OXry/SytyywZN/TgOnN6fT0oyQ5i5e/Ly1ZJmCDsz3pLkSImoDodn ayySVZUHjGdmI2vbPNDa45SdhjG9jSnivqXaRdxkUHakX3xMBnOOWZdNUNc5AZPP2tVa2iHaOL gqy/SUFHk/Xc11YLWXVNIdLg81Ejm0ChXKtsg3dMee/qwFKFMfnha3WeHgvk1cKjM3jCUQ1zfs Bf0BxVNZtqJvX/vZfFIb00FC0M+BCu1hSWCu7nZ1NrDfRjZxRq4N6SChkf0yyxcziRxO3HPMzy Kqg= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 22:08:29 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Kfkqv4l0hz1SVp1 for ; Thu, 14 Apr 2022 22:08:27 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1649999306; x=1652591307; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6 js5zQuBI=; b=ImgmXK0ljefxmjcwwGCZe/P1ZAiYRfxiStEm0q2wFeKQMvkTL85 MoEiv1WWngR6yiDdywhy6m6c7CHetStsP2KPL7aGmRBSEDoQ0BBkWf7uSl7GctxX seFLiVHTqharLpAbcplk3yzDBSQpNNHnyTWqCGnT6SDEQPGGz4njOldB2JpZjV0c Fn1jBi13ZsAeHMQyLgImvLHIeNwH3xSreGo+kohOYlio/FQU9mPmWWTRsJd3G6Vg s7uGQ1kCv0yoS1gOWClHM7ArPs0jj6m4kJVcJWYcgsITqalXpkzGP3XvQ+R3owbL r+qmM2ogk4tvzMNidepDhru5fT38QuGd/Yg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id f0cmGJ7FUSO9 for ; Thu, 14 Apr 2022 22:08:26 -0700 (PDT) Received: from [10.225.163.9] (unknown [10.225.163.9]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Kfkqn6sCZz1Rvlx; Thu, 14 Apr 2022 22:08:21 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 14:08:20 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 27/27] direct-io: remove random prefetches Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: dm-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-um@lists.infradead.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-28-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220415045258.199825-28-hch@lst.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_220829_806196_8481D8B6 X-CRM114-Status: GOOD ( 11.14 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 4/15/22 13:52, Christoph Hellwig wrote: > Randomly poking into block device internals for manual prefetches isn't > exactly a very maintainable thing to do. And none of the performance > criticil direct I/O implementations still use this library function s/criticil/critical > anyway, so just drop it. > > Signed-off-by: Christoph Hellwig Looks good to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1721C433F5 for ; Fri, 15 Apr 2022 05:24:19 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.94.2) (envelope-from ) id 1nfERN-0004M2-C5; Fri, 15 Apr 2022 05:24:18 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nfERL-0004Lw-Lg for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Apr 2022 05:24:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vKRwgfC4ED3wBU2n2i2ZES29ZkioKhUCaYEzFIzNAoM=; b=fcv6hhypEqrGYXKW0fcztP35ZR 81xGICF5l2gd6HalvSvp/Mlcnudj5l1In0gOK85iVkGzOAm5xbCJ9Jnnuo3Bf5YBIku3r3nDRXlZx 0XVV5OOf6ov9CoAEvwx/cI2F//RnCYHZVaw3mLN6/fmvxngTfTvDD6eZXDAoUqWUXmvk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vKRwgfC4ED3wBU2n2i2ZES29ZkioKhUCaYEzFIzNAoM=; b=ZVALLBoSKrQ8gxxlvlI9REs4xR 2wr0N2PSZ2cDhGMCQIW0Eu5nte5Oc8UVmycdnxm6J4jS+qw9RezlxTN4IC0qhI3sHD5HiNPl2NUq+ qoygseeORPkvAACiWl0VLywTuSugma2zLZe0hP4nUdXqEU6ZGyZdb+hRsnE3kYToltWI=; Received: from esa4.hgst.iphmx.com ([216.71.154.42]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.94.2) id 1nfERL-0003QP-6r for linux-f2fs-devel@lists.sourceforge.net; Fri, 15 Apr 2022 05:24:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1650000254; x=1681536254; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6js5zQuBI=; b=SjLutd0K7JvZm9ejuCThoO69HBa1+l0KMb7WWoa1JNgiw3dHXXCf0ZP+ CNCMie+/ES/tdIbFc5r+/N1GlIaAB/t1nMquCfKsm43JMF4QMkyTT14Gn mBVF4zUMoU+KwmJqPWi/d3xGbGdRbbXqoorOVfACaHhLwXpP/TkoF06/x AV/ygyLCxSq7DBVH9/Xg+yqXXVDsSYvpgkv2e8IWRBDu3enihm+JEPoZS gBH4Z5PieHc80i44WW0fRS0pavRBGs4XCYjerwQ+0JigH+3F1vx0bntKO ejReL5e5CJluQtwBTKuPyJAKF4XwdJXiD0D8l2gTUhtE+kOqO/7gxyMdq w==; X-IronPort-AV: E=Sophos;i="5.90,261,1643644800"; d="scan'208";a="196832496" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 15 Apr 2022 13:08:27 +0800 IronPort-SDR: FLYPvl0cPWBpJbc3CmzMBttZUkeFHr9jMiIbgELwW5FsGBgt+Wti8QeLnalx4mfwvAGCGg0/5G ZPYzOTrVlBJtwj5heYLhnFJWB9u41UJ7+9iLE0jLCiqhOqHBMqCFbvH3jbAHfo8SDQfLd514E7 h8flJTH8Aa/fVKoYlFuIeDmenD5jpl6kPa5HOk9G55HeiVlycwKS4NB+Q4v1mlIBdGwK7Iu1WK vbPGHw/vjcFOMMvLhwInH3xi3mo3IeHKS0LABxuKniPLQx/HVUVbGCKP8APi5eI1gPRQXv+W60 F2tmW/61TYylqqghlx9+OXw7 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 21:39:39 -0700 IronPort-SDR: I6S7h6CVU4ioHGTExGSjxajV9QAoB14VsxM0FNSS6wmqrpXtlY3RAV7TK89oz6dS6FWf7ZKNHJ n45YRJWmWVNSyVz9m359BoyWroRPyXM/FVWbtHvSTZd5D48EPrr2DUlgHecq4pN1YUNEv414iU Jko30+7zpIMGgptwTHJxv9V7nTm/8agyexWov3CUL0EQ9vlEKFPatlhyHWxEOnhp+ET8YSYLv3 P6JHWe66MOqM0hZqVCB9HwSkx4GbWGPMBp4ERgXCdGBsk3jx2O/wfQJvPzI2sO79oZwhEk47tC mA0= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Apr 2022 22:08:28 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Kfkqv2lspz1SVnx for ; Thu, 14 Apr 2022 22:08:27 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1649999306; x=1652591307; bh=Fza98p6Hk/Oo3R5YjAQC2Nws92s1JhenlM6 js5zQuBI=; b=ImgmXK0ljefxmjcwwGCZe/P1ZAiYRfxiStEm0q2wFeKQMvkTL85 MoEiv1WWngR6yiDdywhy6m6c7CHetStsP2KPL7aGmRBSEDoQ0BBkWf7uSl7GctxX seFLiVHTqharLpAbcplk3yzDBSQpNNHnyTWqCGnT6SDEQPGGz4njOldB2JpZjV0c Fn1jBi13ZsAeHMQyLgImvLHIeNwH3xSreGo+kohOYlio/FQU9mPmWWTRsJd3G6Vg s7uGQ1kCv0yoS1gOWClHM7ArPs0jj6m4kJVcJWYcgsITqalXpkzGP3XvQ+R3owbL r+qmM2ogk4tvzMNidepDhru5fT38QuGd/Yg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NAIXMllB-sQM for ; Thu, 14 Apr 2022 22:08:26 -0700 (PDT) Received: from [10.225.163.9] (unknown [10.225.163.9]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Kfkqn6sCZz1Rvlx; Thu, 14 Apr 2022 22:08:21 -0700 (PDT) Message-ID: Date: Fri, 15 Apr 2022 14:08:20 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: Christoph Hellwig , Jens Axboe References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-28-hch@lst.de> Organization: Western Digital Research In-Reply-To: <20220415045258.199825-28-hch@lst.de> X-Headers-End: 1nfERL-0003QP-6r Subject: Re: [f2fs-dev] [PATCH 27/27] direct-io: remove random prefetches X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Damien Le Moal via Linux-f2fs-devel Reply-To: Damien Le Moal Cc: jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, cluster-devel@redhat.com, xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org, linux-um@lists.infradead.org, nbd@other.debian.org, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 4/15/22 13:52, Christoph Hellwig wrote: > Randomly poking into block device internals for manual prefetches isn't > exactly a very maintainable thing to do. And none of the performance > criticil direct I/O implementations still use this library function s/criticil/critical > anyway, so just drop it. > > Signed-off-by: Christoph Hellwig Looks good to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Le Moal Date: Fri, 15 Apr 2022 14:08:20 +0900 Subject: [Cluster-devel] [PATCH 27/27] direct-io: remove random prefetches In-Reply-To: <20220415045258.199825-28-hch@lst.de> References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-28-hch@lst.de> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 4/15/22 13:52, Christoph Hellwig wrote: > Randomly poking into block device internals for manual prefetches isn't > exactly a very maintainable thing to do. And none of the performance > criticil direct I/O implementations still use this library function s/criticil/critical > anyway, so just drop it. > > Signed-off-by: Christoph Hellwig Looks good to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research From mboxrd@z Thu Jan 1 00:00:00 1970 From: Damien Le Moal Subject: Re: [PATCH 27/27] direct-io: remove random prefetches Date: Fri, 15 Apr 2022 14:08:20 +0900 Message-ID: References: <20220415045258.199825-1-hch@lst.de> <20220415045258.199825-28-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20220415045258.199825-28-hch@lst.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: jfs-discussion@lists.sourceforge.net, linux-nvme@lists.infradead.org, virtualization@lists.linux-foundation.org, linux-mm@kvack.org, dm-devel@redhat.com, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-scsi@vger.kernel.org, cluster-devel@redhat.com, xen-devel@lists.xenproject.org, linux-ext4@vger.kernel.org, linux-um@lists.infradead.org, nbd@other.debian.org, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, ceph-devel@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org, ntfs3@lists.linux.dev, linux-btrfs@vger.kernel.org On 4/15/22 13:52, Christoph Hellwig wrote: > Randomly poking into block device internals for manual prefetches isn't > exactly a very maintainable thing to do. And none of the performance > criticil direct I/O implementations still use this library function s/criticil/critical > anyway, so just drop it. > > Signed-off-by: Christoph Hellwig Looks good to me. Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research