From mboxrd@z Thu Jan 1 00:00:00 1970 From: sagi@grimberg.me (Sagi Grimberg) Date: Wed, 13 Mar 2019 17:00:21 -0700 Subject: [PATCH nvme-cli rfc 0/6] Support discovery log change events In-Reply-To: References: <20190223023257.21227-1-sagi@grimberg.me> Message-ID: >>> Hmm. >>> >>> Last time I've posted the autoconnect scripts you said you'd rather >>> have them updated to be useful for generic discovery events. >>> So what happened to that? >> >> I would like to have a single event, but the one difference is that >> the discovery log page events come on a discovery controller and in >> the fc case we don't have such a controller (the NVME_INSTANCE env). >> >> If we can resolve this difference we can unite and have a single udev >> handler for both... > > We shouldn't unite them. They are very different things.? One is an > event that says I found a discovery controller go probe it, while the > other is a discovery controller saying I have a discovery log entry go > connect to it.?? My position is we should have both. Well I agree with you, but these the question is would userspace do something different for each? As of now it doesn't. >>> I do have some patches, but still need to polish them off (and >>> possibly test them :-) before sending. >> >> Not sure if that is any better, but lets see patches... > > any updates on these ? Good question...