From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5963C43461 for ; Fri, 11 Sep 2020 16:07:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 033AE206CA for ; Fri, 11 Sep 2020 16:07:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qezlw+GN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 033AE206CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGlaK-0002yk-0S for qemu-devel@archiver.kernel.org; Fri, 11 Sep 2020 12:07:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGlZT-00023l-1h for qemu-devel@nongnu.org; Fri, 11 Sep 2020 12:06:43 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:52651 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kGlZQ-0005Ox-NC for qemu-devel@nongnu.org; Fri, 11 Sep 2020 12:06:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599840399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c4ygajeVSmt2c4Tfp7UiD59+U3C9CgyYcM/rJ1HeOrg=; b=Qezlw+GNymHt2x4SgwYWDIBotvU7HrS5HIQt6ZPFz2NYMh/KBoDwMQyeBvu8sjEHG47MHE AKlY1z2qEQuIhZ8uvRmj7Rg5gtDAOEa2lI+A+xpXZcMvoeCP2QuYeRrJ3jy/kygGXYkOzk +WQ1jqRI1CPaJJZhT9CfJfPylWR+SlM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-320-KcQbrIajNcyLgxkiwzUNGQ-1; Fri, 11 Sep 2020 12:06:37 -0400 X-MC-Unique: KcQbrIajNcyLgxkiwzUNGQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55A3E18BE167; Fri, 11 Sep 2020 16:06:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-62.ams2.redhat.com [10.36.113.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 87D4519C66; Fri, 11 Sep 2020 16:06:28 +0000 (UTC) Subject: Re: PATCH: Increase System Firmware Max Size To: =?UTF-8?Q?Daniel_P._Berrang=c3=a9?= , "Dr. David Alan Gilbert" References: <20c5210f-8199-a9e7-9297-0bea06c4d9ae@redhat.com> <20200911083408.GA3310@work-vm> <20200911150602.GH3310@work-vm> <20200911152353.GI1203593@redhat.com> From: Laszlo Ersek Message-ID: Date: Fri, 11 Sep 2020 18:06:27 +0200 MIME-Version: 1.0 In-Reply-To: <20200911152353.GI1203593@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=205.139.110.120; envelope-from=lersek@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/11 03:28:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mst@redhat.com" , "qemu-trivial@nongnu.org" , "qemu-devel@nongnu.org" , Markus Armbruster , "McMillan, Erich" , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 09/11/20 17:23, Daniel P. Berrangé wrote: > I don't see why we should have this as a hard coded > limit that is not runtime configurable. > > IOW, why can't we keep our current default and provide a machine type > property "firmware_max_size" which users can opt-in to setting if > their particular firmware exceeds normal defaults. That won't impact > us for migration compat in any way, and lets users have flexibility t > do what they want. Technically, this is fine, in my opinion. My concerns (in distilled form, this time): - The change increases maintenance burden. - The change does not benefit most users of QEMU, as the intended guest payload will not available to most of them at all (regardless of licensing terms). - The existence of the property may entice OVMF users to ask us to enlarge the *current* OVMF firmware platform and to pack more stuff in it. That is not OK. My counter-proposal ("please contribute a new platform DSC/FDF under OvmfPkg, and assume co-reviewership for it") would almost certainly not be acted upon. That's all. Thanks Laszlo