From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF2ADC433F5 for ; Fri, 1 Oct 2021 06:14:41 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E36AF61A56 for ; Fri, 1 Oct 2021 06:14:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E36AF61A56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2990F82021; Fri, 1 Oct 2021 08:14:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633068879; bh=6WJ9jg2O7vN22M6bNJl5cxGQt+Dz4goi63LEwt3vSUU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lt4zYLaLBkE1N7UJrzwLcHtVSHRfDMw11lKOVEsZYiQsjgZxqaqvW9tAaIM0im2Gw yCeud2ZUw9JZwl5qZFtXyMi0ISKnelfZBqOKObaL2kLFHGh3SXesds2vFA1J0d8kUT m4VgfTGXXfCfth6A7BdsUNyFwR0Vo2tsOj2IyaGRqCcmujNyfni/Z+gk6F0KKpr74m SOeCXUOc5nZ4MWR/jNOEL1U8s4461BbGS3h3UV7UhTeFMsMyuVYgIFGdoD9BiZYHiJ 6yzB+BSN0WuomMUZgrtCUY17ct08pu65NZtY5tqAbMKOp5bmkf9CjaIfZel3wdSNT1 TXfmqYQbTcHGQ== Received: by phobos.denx.de (Postfix, from userid 109) id 53FBC820E3; Fri, 1 Oct 2021 08:14:36 +0200 (CEST) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [91.198.250.253]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 088AD82B68 for ; Fri, 1 Oct 2021 08:14:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4HLKZY6dQqzQkd5; Fri, 1 Oct 2021 08:14:29 +0200 (CEST) Subject: Re: [PATCH u-boot-marvell v3 03/39] tools: kwboot: Make the quit sequence buffer const To: =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: u-boot@lists.denx.de, pali@kernel.org, Chris Packham , Baruch Siach , Dennis Gilmore , Mario Six , Jon Nettleton , =?UTF-8?Q?Marek_Beh=c3=ban?= References: <20210924210716.29752-1-kabel@kernel.org> <20210924210716.29752-4-kabel@kernel.org> From: Stefan Roese Message-ID: Date: Fri, 1 Oct 2021 08:14:26 +0200 MIME-Version: 1.0 In-Reply-To: <20210924210716.29752-4-kabel@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: BB7EE18B8 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 24.09.21 23:06, Marek Behún wrote: > From: Marek Behún > > This buffer is never written to. Make it const. > > Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > tools/kwboot.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/kwboot.c b/tools/kwboot.c > index e6e99849a7..f18f6d2134 100644 > --- a/tools/kwboot.c > +++ b/tools/kwboot.c > @@ -460,7 +460,7 @@ can: > } > > static int > -kwboot_term_pipe(int in, int out, char *quit, int *s) > +kwboot_term_pipe(int in, int out, const char *quit, int *s) > { > ssize_t nin, nout; > char _buf[128], *buf = _buf; > @@ -504,7 +504,7 @@ static int > kwboot_terminal(int tty) > { > int rc, in, s; > - char *quit = "\34c"; > + const char *quit = "\34c"; > struct termios otio, tio; > > rc = -1; > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de