From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MhkiU-0004zk-GH for mharc-grub-devel@gnu.org; Sun, 30 Aug 2009 09:45:10 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MhkiQ-0004yO-Ks for grub-devel@gnu.org; Sun, 30 Aug 2009 09:45:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MhkiK-0004t9-Tn for grub-devel@gnu.org; Sun, 30 Aug 2009 09:45:06 -0400 Received: from [199.232.76.173] (port=54306 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MhkiK-0004t3-OZ for grub-devel@gnu.org; Sun, 30 Aug 2009 09:45:00 -0400 Received: from mail-bw0-f222.google.com ([209.85.218.222]:39854) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MhkiJ-0003QO-RM for grub-devel@gnu.org; Sun, 30 Aug 2009 09:45:00 -0400 Received: by bwz22 with SMTP id 22so2897858bwz.42 for ; Sun, 30 Aug 2009 06:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=yg41XGH99hnp5ThB5eDzxGSpE12g5w9T461oZCy2CKE=; b=JvVEY15MLXDI9/ptNYFQkhaNvR08N+Uoa4PMWtsHI2WyQ1IdFZNk8hBzPfWlufMszd /dWHJp6dAYgTfbQQf5MEXzHdK8aaTsRjeF3OcdywAPz1pxf8RPrSM6guprHpb/VvobCN 3r4MCrsxDEx89YFJdBP/CAfhD1A7w2AxVbAFw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=uZguLBGx2CnixKsmxMd03fQPTu575nX14bIS9Yki6OmVIuR8OMaKigeptjC4DPZ9iW uyaTVFEMhQjz52JFk+GmIEDk0UERt7kOBdC42C2DaKzOedc84FKaiv6edet/FK+mdJXR PLWfSQBP73PxriDkW1+oiKayqQASmlcoHkU/A= MIME-Version: 1.0 Received: by 10.204.154.76 with SMTP id n12mr3157679bkw.162.1251639891167; Sun, 30 Aug 2009 06:44:51 -0700 (PDT) In-Reply-To: <20090830133329.GA17120@thorin> References: <20090830133329.GA17120@thorin> Date: Sun, 30 Aug 2009 15:44:51 +0200 Message-ID: From: "Vladimir 'phcoder' Serbinenko" To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] Remove has_paritions X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Aug 2009 13:45:07 -0000 On Sun, Aug 30, 2009 at 3:33 PM, Robert Millan wrote: > On Fri, Aug 28, 2009 at 09:25:15PM +0200, Vladimir 'phcoder' Serbinenko w= rote: >> diff --git a/disk/lvm.c b/disk/lvm.c >> index 126b494..59bf2d7 100644 >> --- a/disk/lvm.c >> +++ b/disk/lvm.c >> @@ -97,7 +97,6 @@ grub_lvm_open (const char *name, grub_disk_t disk) >> =A0 =A0if (! lv) >> =A0 =A0 =A0return grub_error (GRUB_ERR_UNKNOWN_DEVICE, "Unknown LVM devi= ce %s", name); >> >> - =A0disk->has_partitions =3D 0; >> =A0 =A0disk->id =3D lv->number; >> =A0 =A0disk->data =3D lv; >> =A0 =A0disk->total_sectors =3D lv->size; > > Why would LVM users want to nest partition maps in them? > > This makes me think removing has_partitions is not such a good idea. > Probing for partition map when already probing for fs is cheap. has_partitions gets in the way of probing and the need for it was dictated by FAT floppies being detected as msdos partmap. This was recently fixed (by checking bootflags) and now has_partitions has become an artifact needing support in code, increasing code size and no benefit. > Actually, LVM is a partition map of sorts. =A0If we're going to refurbish= our > partition handling model, I think we should contemplate the possibility o= f > LVM (and perhaps swRAID) becoming less ad-hoc. > I would happy if we could do it someway considering LVM can span across multiple devices. We have to consider multidrive filesystems like zfs and btrfs too. > But that is more an idea for 2.0. =A0What are our inmediate needs? This was actually triggered by grub2 not seeing partitions on Apple bootable CDs just because has_partitions=3D0. I vaguely remember I noticed other places where has_partitions was set in a heuristical way but can't point it now > > -- > Robert Millan > > =A0The DRM opt-in fallacy: "Your data belongs to us. We will decide when = (and > =A0how) you may access your data; but nobody's threatening your freedom: = we > =A0still allow you to remove your data and not access it at all." > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel > --=20 Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git