* rtl8723bs: rtnl_is_locked() misuse
@ 2018-01-27 8:13 Kirill Tkhai
0 siblings, 0 replies; only message in thread
From: Kirill Tkhai @ 2018-01-27 8:13 UTC (permalink / raw)
To: linux-wireless; +Cc: Jes.Sorensen
Hi,
I'm reporting you about misuse of rtnl_is_locked() in rtw_change_ifname() function.
Note, that rtnl_is_locked() *does not mean* rtnl is locked on the *current cpu*.
This primitive returns true in case of rtnl is locked somewhere in the system.
So, it can't be used in the below code:
if (!rtnl_is_locked())
unregister_netdev(cur_pnetdev);
else
unregister_netdevice(cur_pnetdev);
Kirill
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-01-27 8:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-27 8:13 rtl8723bs: rtnl_is_locked() misuse Kirill Tkhai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.